Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp115061imu; Wed, 19 Dec 2018 14:45:53 -0800 (PST) X-Google-Smtp-Source: AFSGD/Vr9AVjN8CbcmhqW09WI6IMxywcw268Gr1F92vvt/WolG9/GyI+oLx0P5c9Y/9tl83cliM7 X-Received: by 2002:a62:1484:: with SMTP id 126mr7664913pfu.257.1545259553595; Wed, 19 Dec 2018 14:45:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545259553; cv=none; d=google.com; s=arc-20160816; b=zQB7OMKYFxcoboVgfqLloysCo0tVE+ZdmR6kzmnTmQMpp/pmoJus2XQgcIUtTAH89H QBWcVlLxaumRIpSzO0m1Oa753fDNIpuGkivaxWKsLjxg9DKydwxJNFPrdXyixN0sCTzz 5VIRixvMHm/fGH5OXKdJ/qnQyTyCIOfR5vR4oQvCKd+Ioh0dahsbCbXwCT97C9MFcXiK ia4sGH5TuZCZBTZ79AkOVDwJWS3fxvEsSTGe41l6Tyny3yAMe+euapa8/EXc8YL9wu2C kg3jBEHoiFiWjzHqbWkqTNC6j1fHNuaFjf19tq8y7qwWOSaIzx8sh/u5frQZzJugmeVU 60RA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=JTNZpOKRC/ITuufP+mFFNsXb+e6vN1CRNRu7IWV2IsU=; b=dNUIuFeRjkzOGbJZtoQgrFTygdMP2HYbFz49x9UnloNb6KasdB09tkVXEE6Xr6wv5/ yls0OewYHsvsMcCtOPLvHUdY8Y2NOmyk/Vf5A7e7LbLcbMA5i2Xyh5vP4p3aCVBfrJl6 zdWSM9JF++99R3hX/Cx8OyM06quiMtdmmIULZTJH4Koya+C/WoZ4xqGc6/VobgZzO/j9 S7Sm86qvhNhxpHpvEjjpZWyZpcdM7h90ghgtvm4DH6ZZcFIxUOgjhurCNGYEt6opIFSF HOI7PwwfZRYShia3tr5m2DJ81p87BAtUjuk9aFo5ztWO9k3pTVaeDaNgqa+zhmJ0oDLx 13BQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l8si17171002pfc.98.2018.12.19.14.45.37; Wed, 19 Dec 2018 14:45:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729984AbeLSW1u (ORCPT + 99 others); Wed, 19 Dec 2018 17:27:50 -0500 Received: from gateway23.websitewelcome.com ([192.185.50.185]:21579 "EHLO gateway23.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727502AbeLSW1t (ORCPT ); Wed, 19 Dec 2018 17:27:49 -0500 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway23.websitewelcome.com (Postfix) with ESMTP id A493B12903 for ; Wed, 19 Dec 2018 16:27:48 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id ZkJgg0NYPdnCeZkJggACIP; Wed, 19 Dec 2018 16:27:48 -0600 X-Authority-Reason: nr=8 Received: from [189.250.106.44] (port=47220 helo=[192.168.1.76]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gZkJg-000Dot-8r; Wed, 19 Dec 2018 16:27:48 -0600 Subject: Re: [PATCH 25/41] scsi: lpfc: lpfc_nportdisc: Mark expected switch fall-through To: James Smart , Dick Kennedy Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <8d1c41fb93d54415cfd0a8c1fa6d31a6a76db461.1543374820.git.gustavo@embeddedor.com> From: "Gustavo A. R. Silva" Message-ID: <7e647723-0fdf-97c0-4e54-3d663db91392@embeddedor.com> Date: Wed, 19 Dec 2018 16:27:46 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <8d1c41fb93d54415cfd0a8c1fa6d31a6a76db461.1543374820.git.gustavo@embeddedor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.106.44 X-Source-L: No X-Exim-ID: 1gZkJg-000Dot-8r X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.76]) [189.250.106.44]:47220 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 52 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/scsi/lpfc/lpfc_nportdisc.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/scsi/lpfc/lpfc_nportdisc.c b/drivers/scsi/lpfc/lpfc_nportdisc.c > index 7d5693cfaa87..e8583496feaf 100644 > --- a/drivers/scsi/lpfc/lpfc_nportdisc.c > +++ b/drivers/scsi/lpfc/lpfc_nportdisc.c > @@ -360,6 +360,7 @@ lpfc_rcv_plogi(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, > case NLP_STE_NPR_NODE: > if (!(ndlp->nlp_flag & NLP_NPR_ADISC)) > break; > + /* fall through */ > case NLP_STE_REG_LOGIN_ISSUE: > case NLP_STE_PRLI_ISSUE: > case NLP_STE_UNMAPPED_NODE: >