Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp118960imu; Wed, 19 Dec 2018 14:51:30 -0800 (PST) X-Google-Smtp-Source: AFSGD/V3xzWfPOLpjSA7hRDEo/OVfbOjsA/nIwojGx/Af1VfWQYtAZANBCTDr6PcdiqdvcvhAB2i X-Received: by 2002:a62:2292:: with SMTP id p18mr22774285pfj.9.1545259890604; Wed, 19 Dec 2018 14:51:30 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545259890; cv=none; d=google.com; s=arc-20160816; b=Nx7vgiip+GvKErRZYtWDhYbl2ydyBltFWnW3zF2fw5XbgDvkz9+0Y7zknAXnnvASRj W7yCCgbJwcrGmayxN4pSeCDf3wr1Y29REvS6KMqMElVPaYHN6NYKcZXDzzaUVcnTF261 u8ci2LA0/bGqJ20//CaibEhJUek/XPM4VQF45DvK9AL00ldrlJT3Ub7ZD9G2N4YBDkzH xQW74LQpMk+i0uG452m7B/HTWVXVVzmkmdZTg7zSs2Xw72bTwHeSnVqDuInvtkLoVujT Yc51Lu8KH8LlvVqNoO9+yHg4q+tZSq0ndTgfdybThr0/2cV91Sx9nPvhFdHOJq7tYumz NVzQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject; bh=DMqVrfZ4p5PmjsV2e+cujZf89MGSJNNdLCiCvC9J8yo=; b=Z/67mS145Jctnkehczpp+h78aTuYEOyrziiAK5/LHVhAHnGjiDz63rDQ4XZVoBoOEV pLt/o+nmG1kKAd1irTpfrb/E9z2g4XCxXLTAxtC3OkwDWscQg7jdyQE0VCa5NDWxLZTv Ng0+i2EfumcN7j31CfWz8H9tE/RmMd4b+AV94xqYFQ9bkE++ki27z6b2WNWh9+5TGZOv bn0oKIYhPnSoyX9OT4jXF5aLkRU7rt5DC5IL91+dIwG9lWrtCc5AvLxjqgl07uOyYUMF mnieY2GVgwK27rLskgxvl6YWIjEQUzHcKOENUu2CtnEk44t23x8dJX3/0rWYLOmIppwr tk8Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id a124si19177784pfb.263.2018.12.19.14.51.14; Wed, 19 Dec 2018 14:51:30 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729003AbeLSWuK (ORCPT + 99 others); Wed, 19 Dec 2018 17:50:10 -0500 Received: from gateway20.websitewelcome.com ([192.185.48.38]:23468 "EHLO gateway20.websitewelcome.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728249AbeLSWuJ (ORCPT ); Wed, 19 Dec 2018 17:50:09 -0500 Received: from cm11.websitewelcome.com (cm11.websitewelcome.com [100.42.49.5]) by gateway20.websitewelcome.com (Postfix) with ESMTP id F0D74400CE506 for ; Wed, 19 Dec 2018 16:27:20 -0600 (CST) Received: from gator4166.hostgator.com ([108.167.133.22]) by cmsmtp with SMTP id ZkJEg0N73dnCeZkJEgABrH; Wed, 19 Dec 2018 16:27:20 -0600 X-Authority-Reason: nr=8 Received: from [189.250.106.44] (port=47208 helo=[192.168.1.76]) by gator4166.hostgator.com with esmtpsa (TLSv1.2:ECDHE-RSA-AES128-GCM-SHA256:128) (Exim 4.91) (envelope-from ) id 1gZkJE-000DYr-Jy; Wed, 19 Dec 2018 16:27:20 -0600 Subject: Re: [PATCH 22/41] scsi: lpfc: lpfc_ct: Mark expected switch fall-throughs To: James Smart , Dick Kennedy Cc: "James E.J. Bottomley" , "Martin K. Petersen" , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org References: <4e80e3ae7cd0f0c54b45530a3772af4f606b0c8e.1543374820.git.gustavo@embeddedor.com> From: "Gustavo A. R. Silva" Message-ID: Date: Wed, 19 Dec 2018 16:27:19 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.2.1 MIME-Version: 1.0 In-Reply-To: <4e80e3ae7cd0f0c54b45530a3772af4f606b0c8e.1543374820.git.gustavo@embeddedor.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - gator4166.hostgator.com X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - embeddedor.com X-BWhitelist: no X-Source-IP: 189.250.106.44 X-Source-L: No X-Exim-ID: 1gZkJE-000DYr-Jy X-Source: X-Source-Args: X-Source-Dir: X-Source-Sender: ([192.168.1.76]) [189.250.106.44]:47208 X-Source-Auth: gustavo@embeddedor.com X-Email-Count: 34 X-Source-Cap: Z3V6aWRpbmU7Z3V6aWRpbmU7Z2F0b3I0MTY2Lmhvc3RnYXRvci5jb20= X-Local-Domain: yes Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, Friendly ping: Who can ack or review this patch, please? Thanks -- Gustavo On 11/27/18 10:31 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Signed-off-by: Gustavo A. R. Silva > --- > drivers/scsi/lpfc/lpfc_ct.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/scsi/lpfc/lpfc_ct.c b/drivers/scsi/lpfc/lpfc_ct.c > index 6305ffeba7ea..b2b7fcc23654 100644 > --- a/drivers/scsi/lpfc/lpfc_ct.c > +++ b/drivers/scsi/lpfc/lpfc_ct.c > @@ -3050,6 +3050,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, > case SLI_MGMT_GHAT: > case SLI_MGMT_GRPL: > rsp_size = FC_MAX_NS_RSP; > + /* fall through */ > case SLI_MGMT_DHBA: > case SLI_MGMT_DHAT: > pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID; > @@ -3062,6 +3063,7 @@ lpfc_fdmi_cmd(struct lpfc_vport *vport, struct lpfc_nodelist *ndlp, > case SLI_MGMT_GPAT: > case SLI_MGMT_GPAS: > rsp_size = FC_MAX_NS_RSP; > + /* fall through */ > case SLI_MGMT_DPRT: > case SLI_MGMT_DPA: > pe = (struct lpfc_fdmi_port_entry *)&CtReq->un.PortID; >