Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp564116imu; Thu, 20 Dec 2018 01:26:20 -0800 (PST) X-Google-Smtp-Source: AFSGD/Xg7uwGtcCuUNAVEP/tUgqt4uXkPJaDWIy9+kgspuFpBResDqD7VwIeJJLHtSInsv4o9uN/ X-Received: by 2002:a63:585c:: with SMTP id i28mr22650487pgm.178.1545297980818; Thu, 20 Dec 2018 01:26:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545297980; cv=none; d=google.com; s=arc-20160816; b=j/pFXBbuVjefAqKIlQrXNCB3kqJweMBE8fapu1lLpIcmzg25CxmZJqbQ5ypn61+SB6 jxgM1vCeZimrYRPa9dBCBRJYIf2CN4AZzFW8OtCYz/Hpoa4W9iuczLm+m5PtWTDdoht+ MvBCjqzwa6H71gSZBdBDn+SOSmY6b6v+K89K6k/iXywCq2CNm5YR4yUaPDplQojnYAJs yW7L5obdAXtVtVahLrtOvLoamUARN4MVTICuwxoIaAPy7GBDZ9mj6kF1/LyObgYHS9rt FjejfhR/WFy2FXGTE9T/Gp1RnD2r1t8/s644/seg6s06fc/TZ/dgzPZaOuS319g3Lde1 d/Mw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=wRRhFbRKaHxOCgquvNEGdauSzJsNgkcSk5aS2PfN7E8=; b=t1l2n9463VYSVOMNXtTPtU1aeft/IG24wspT5jEzVWHRKmCtF2aLrGs4g/d7W+92vb lfJsu6kZx9eTKTfnKc2B2oxEVXmYs4X7Xnd1+uhicWKTAKyl7laXgSa1kiTtAW5NhzN/ SyE6XrUOqnC2aKJ6tYnSP3rfnQ6walZutz/tSaJqiAhf6dJzBFE75kMFAUzH9EbtoE0o YwbtRQxIlEXvBQT5U+YC+C0Dp1VsD6ImXuXqsMwoGISlE7qWniY/f+7MJwq4JuNvmeoL jv8bJDePeG0lgy71KFcV3mMUEVbkr1w7hCXgL0hn419lZvKXsnjLcwyS4TMMhUkjLmVZ BTSQ== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2BNVcAvT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y191si17171813pgd.4.2018.12.20.01.26.05; Thu, 20 Dec 2018 01:26:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=2BNVcAvT; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731603AbeLTJXc (ORCPT + 99 others); Thu, 20 Dec 2018 04:23:32 -0500 Received: from mail.kernel.org ([198.145.29.99]:54038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731596AbeLTJXa (ORCPT ); Thu, 20 Dec 2018 04:23:30 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id ECE8A21841; Thu, 20 Dec 2018 09:23:28 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545297809; bh=klNhD7COncAyMc1KRzXzz7VTFlaiVCFrXteP8vMDyaE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=2BNVcAvTHECFsRNki4iLsouk4qbMPhmAEhTTkHAgBm+ThwnUV+KWzby9do/nNYHz4 eCdsWrI+RUTMy02VonEW2wuQ6aDXGPSUHyCW1DoSLJDkhvv2AUBJ5vnMojp1mG4feg BanEBz1Jw1wfFI5sLRC+7B/IOSKYDK+8trk4aA8A= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Waiman Long , Will Deacon , Linus Torvalds , Peter Zijlstra , Thomas Gleixner , boqun.feng@gmail.com, linux-arm-kernel@lists.infradead.org, paulmck@linux.vnet.ibm.com, Ingo Molnar , Sebastian Andrzej Siewior , Sasha Levin Subject: [PATCH 4.9 25/61] locking/qspinlock: Remove duplicate clear_pending() function from PV code Date: Thu, 20 Dec 2018 10:18:25 +0100 Message-Id: <20181220085844.749782306@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181220085843.743900603@linuxfoundation.org> References: <20181220085843.743900603@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ commit 3bea9adc96842b8a7345c7fb202c16ae9c8d5b25 upstream. The native clear_pending() function is identical to the PV version, so the latter can simply be removed. This fixes the build for systems with >= 16K CPUs using the PV lock implementation. Reported-by: Waiman Long Signed-off-by: Will Deacon Cc: Linus Torvalds Cc: Peter Zijlstra Cc: Thomas Gleixner Cc: boqun.feng@gmail.com Cc: linux-arm-kernel@lists.infradead.org Cc: paulmck@linux.vnet.ibm.com Link: http://lkml.kernel.org/r/20180427101619.GB21705@arm.com Signed-off-by: Ingo Molnar Signed-off-by: Sebastian Andrzej Siewior Signed-off-by: Sasha Levin --- kernel/locking/qspinlock_paravirt.h | 5 ----- 1 file changed, 5 deletions(-) diff --git a/kernel/locking/qspinlock_paravirt.h b/kernel/locking/qspinlock_paravirt.h index 9c07c72fb10e..af2a24d484aa 100644 --- a/kernel/locking/qspinlock_paravirt.h +++ b/kernel/locking/qspinlock_paravirt.h @@ -105,11 +105,6 @@ static __always_inline void set_pending(struct qspinlock *lock) atomic_or(_Q_PENDING_VAL, &lock->val); } -static __always_inline void clear_pending(struct qspinlock *lock) -{ - atomic_andnot(_Q_PENDING_VAL, &lock->val); -} - static __always_inline int trylock_clear_pending(struct qspinlock *lock) { int val = atomic_read(&lock->val); -- 2.19.1