Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp746998imu; Thu, 20 Dec 2018 04:50:29 -0800 (PST) X-Google-Smtp-Source: AFSGD/UVLi7+FjVlJS7TfuvkbnbmB885IXLq/LEugonoSbb4/ms1YmyZEuoXhUvtg6kvvSBes30o X-Received: by 2002:a63:77ce:: with SMTP id s197mr22773225pgc.89.1545310229645; Thu, 20 Dec 2018 04:50:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545310229; cv=none; d=google.com; s=arc-20160816; b=ZmfcStu9kH4g/HHg517qC8drIzFgVYU7vIQ2W2UiKtMFi2BenT2xN4OYMG+jU7EB9d 20zTFwwY/hQc2X3wTjj0w1iSPQId6DLGGTl+YBjQpvB8+qkNqs+6j72VaNlfJ7+f6wBd 93/+3NClgnCW56L9rDFnwp/FWSXl113QiIaIqMzoW+Bsl0mBNX+cqyb9WfkDbh+N6eOT i6KP6fX+2CDOvk0MkUpgJ4yUC9xXgsomxAwfbWBb6hFpq+IrocrC8jej5Zqmt0i8zBj/ NxKgtyYU5okseGcP5GORtYHQG+iFF46x1bKclDbuIa3BVTy/vLOX4aQzHLO4uLgxvgaO 3Ccg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=GjDVtQQoY1ksin+RcCutbqylYzQqUgZsjSfbFGdsSFU=; b=lH6Sase3K6tjicSmbLgH3COoZ4UXbxA4gl9/Dc/oIvxff3St5CG95annbUXIBnir7n T9PDD3957OktuienT8jXAh0G5thuqisMdq58uEL3QZOfIdAwPLx6dmVx48sPX89Kd5GZ DCExyvKCJRpAuLLZmH0xZJVJ6eMBQCxYZQtM3qQKPy4LNf+x88UXTUquILYUkBnC84S0 zyx7xlkWqnzoKigo4zZNiMJLNqcpWp83BH2MCfIHfej35oswW4n9s+HiJiRQyGsFQEf/ I7PKjc5sIVyBdKYaJYUtSA3gMbX4QiTFqnz5JLRzbNZWHgPM44/o5RXJCEnWNdvr2KUZ RwQw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Pf+GUGiJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 62si18060370pgb.298.2018.12.20.04.50.10; Thu, 20 Dec 2018 04:50:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=Pf+GUGiJ; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731496AbeLTJXK (ORCPT + 99 others); Thu, 20 Dec 2018 04:23:10 -0500 Received: from mail.kernel.org ([198.145.29.99]:50624 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1731481AbeLTJXI (ORCPT ); Thu, 20 Dec 2018 04:23:08 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 70AB5217D7; Thu, 20 Dec 2018 09:23:07 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545297787; bh=1OXtr2E1R0eBTHih6cubPHW0x2i27rJeQ0lvtDrpY5s=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=Pf+GUGiJlOflIUXFLbE1FPt4+5dPIAGT3RYWJk5zNC/njOwevJw7D7wmzEibaOLcl a7p5AmYjOt5AyD9RspDhaZW8PBhUnU1HcKicQdKgc38XUL9DDZRw1YwGVcDe5eUSvK iDfanFifEVMOms13WpRA6W23FehjnhshITfP0c9w= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, Davidlohr Bueso , Andrew Morton , Linus Torvalds , Sasha Levin Subject: [PATCH 4.9 04/61] lib/rbtree_test.c: make input module parameters Date: Thu, 20 Dec 2018 10:18:04 +0100 Message-Id: <20181220085843.917841115@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181220085843.743900603@linuxfoundation.org> References: <20181220085843.743900603@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ [ Upstream commit 223f8911eace60c787f8767c25148b80ece9732a ] Allows for more flexible debugging. Link: http://lkml.kernel.org/r/20170719014603.19029-5-dave@stgolabs.net Signed-off-by: Davidlohr Bueso Signed-off-by: Andrew Morton Signed-off-by: Linus Torvalds Signed-off-by: Sasha Levin --- lib/rbtree_test.c | 55 +++++++++++++++++++++++++++++------------------ 1 file changed, 34 insertions(+), 21 deletions(-) diff --git a/lib/rbtree_test.c b/lib/rbtree_test.c index 8b3c9dc88262..e83331aa1b7f 100644 --- a/lib/rbtree_test.c +++ b/lib/rbtree_test.c @@ -1,11 +1,18 @@ #include +#include #include #include +#include #include -#define NODES 100 -#define PERF_LOOPS 100000 -#define CHECK_LOOPS 100 +#define __param(type, name, init, msg) \ + static type name = init; \ + module_param(name, type, 0444); \ + MODULE_PARM_DESC(name, msg); + +__param(int, nnodes, 100, "Number of nodes in the rb-tree"); +__param(int, perf_loops, 100000, "Number of iterations modifying the rb-tree"); +__param(int, check_loops, 100, "Number of iterations modifying and verifying the rb-tree"); struct test_node { u32 key; @@ -17,7 +24,7 @@ struct test_node { }; static struct rb_root root = RB_ROOT; -static struct test_node nodes[NODES]; +static struct test_node *nodes = NULL; static struct rnd_state rnd; @@ -95,7 +102,7 @@ static void erase_augmented(struct test_node *node, struct rb_root *root) static void init(void) { int i; - for (i = 0; i < NODES; i++) { + for (i = 0; i < nnodes; i++) { nodes[i].key = prandom_u32_state(&rnd); nodes[i].val = prandom_u32_state(&rnd); } @@ -177,6 +184,10 @@ static int __init rbtree_test_init(void) int i, j; cycles_t time1, time2, time; + nodes = kmalloc(nnodes * sizeof(*nodes), GFP_KERNEL); + if (!nodes) + return -ENOMEM; + printk(KERN_ALERT "rbtree testing"); prandom_seed_state(&rnd, 3141592653589793238ULL); @@ -184,27 +195,27 @@ static int __init rbtree_test_init(void) time1 = get_cycles(); - for (i = 0; i < PERF_LOOPS; i++) { - for (j = 0; j < NODES; j++) + for (i = 0; i < perf_loops; i++) { + for (j = 0; j < nnodes; j++) insert(nodes + j, &root); - for (j = 0; j < NODES; j++) + for (j = 0; j < nnodes; j++) erase(nodes + j, &root); } time2 = get_cycles(); time = time2 - time1; - time = div_u64(time, PERF_LOOPS); + time = div_u64(time, perf_loops); printk(" -> %llu cycles\n", (unsigned long long)time); - for (i = 0; i < CHECK_LOOPS; i++) { + for (i = 0; i < check_loops; i++) { init(); - for (j = 0; j < NODES; j++) { + for (j = 0; j < nnodes; j++) { check(j); insert(nodes + j, &root); } - for (j = 0; j < NODES; j++) { - check(NODES - j); + for (j = 0; j < nnodes; j++) { + check(nnodes - j); erase(nodes + j, &root); } check(0); @@ -216,32 +227,34 @@ static int __init rbtree_test_init(void) time1 = get_cycles(); - for (i = 0; i < PERF_LOOPS; i++) { - for (j = 0; j < NODES; j++) + for (i = 0; i < perf_loops; i++) { + for (j = 0; j < nnodes; j++) insert_augmented(nodes + j, &root); - for (j = 0; j < NODES; j++) + for (j = 0; j < nnodes; j++) erase_augmented(nodes + j, &root); } time2 = get_cycles(); time = time2 - time1; - time = div_u64(time, PERF_LOOPS); + time = div_u64(time, perf_loops); printk(" -> %llu cycles\n", (unsigned long long)time); - for (i = 0; i < CHECK_LOOPS; i++) { + for (i = 0; i < check_loops; i++) { init(); - for (j = 0; j < NODES; j++) { + for (j = 0; j < nnodes; j++) { check_augmented(j); insert_augmented(nodes + j, &root); } - for (j = 0; j < NODES; j++) { - check_augmented(NODES - j); + for (j = 0; j < nnodes; j++) { + check_augmented(nnodes - j); erase_augmented(nodes + j, &root); } check_augmented(0); } + kfree(nodes); + return -EAGAIN; /* Fail will directly unload the module */ } -- 2.19.1