Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp972438imu; Thu, 20 Dec 2018 08:09:01 -0800 (PST) X-Google-Smtp-Source: AFSGD/XGcrg0mFJ/uZDcL2s2XqSS/hhcQC3m8MHDLJbGTs1O1QksJ4G2Cmdaf62HH+9AunFHODFB X-Received: by 2002:a17:902:9a07:: with SMTP id v7mr23928518plp.247.1545322141288; Thu, 20 Dec 2018 08:09:01 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545322141; cv=none; d=google.com; s=arc-20160816; b=XFgo3WRuSrj6eTqjy8pYes40wQuG7r6Gbih6OJDVt0Vntf3OTkIOUNoz4YubRDgv07 4Eqq1Y9yt/Qg25LO3wwJ1QVaF2aifo7sgxUA0M+vL7JukwvZCZ0K9LHCqiPdIPMS30hl ITKMMll1bxXCJi1bWLhRqNS2B5lcXozme7s3EdMn1hpDC+EE8+QT9di0dS0jgpE8lXsu KiVhHbGy27C8EucFE3Qke0ln9QzFqz2sCs3XRvNk/6i4aS8RnFLFBdBr7QlLvcuimMu2 ZKn/2NllxIHCGmADZL7G516EYxkeIbUYXRU0I/vYfuxDxBRBFY+k8ZUteCj141tKRYiy IyCQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:organization:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=/XzyAJw/k5hHZDCJ9uLdSPPK2Jzzgo0Xbtiz4wLqNdg=; b=mU7x78Ctu4qVAdw1u+WwXzQmne3LsmtifDQcdx/q4zxNeohhxWfFXge+H2cr3LzM7O PHG0cNZfnzfo4ixOGgH1ws100BZTTjOc2k5I7pNduQTrqR5le42zcck+eFnJKLmRkWQW 0R+rurSikqlX2BrAc3+OL7tvusqdFzaqUjsoXQWMzhrgwDuAMbHdudoBKMpUp483zHyZ xpZIBta/ef6um+TBrO04XkbbMJvxttTyCZ/wSxy3zQT9pulvPjgyW1SubnSFYhWy6Jc+ rNVB6s3AQYSJwIQFIiWYxaWd+Xl5e8oSRz2WqjfCbtVvJSxSTt/idJEu+SAcdoZPjFZJ EJoQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 27si18666780pgu.421.2018.12.20.08.08.43; Thu, 20 Dec 2018 08:09:01 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=intel.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732368AbeLTNMW (ORCPT + 99 others); Thu, 20 Dec 2018 08:12:22 -0500 Received: from mga06.intel.com ([134.134.136.31]:30973 "EHLO mga06.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730884AbeLTNMV (ORCPT ); Thu, 20 Dec 2018 08:12:21 -0500 X-Amp-Result: UNSCANNABLE X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga104.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 20 Dec 2018 05:12:21 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.56,377,1539673200"; d="scan'208";a="102148596" Received: from unknown (HELO localhost) ([10.249.254.232]) by orsmga006.jf.intel.com with ESMTP; 20 Dec 2018 05:12:14 -0800 Date: Thu, 20 Dec 2018 15:12:13 +0200 From: Jarkko Sakkinen To: Andy Lutomirski Cc: Sean Christopherson , Jethro Beekman , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "x86@kernel.org" , Dave Hansen , Peter Zijlstra , "H. Peter Anvin" , "linux-kernel@vger.kernel.org" , "linux-sgx@vger.kernel.org" , Josh Triplett , Haitao Huang , "Dr . Greg Wettstein" Subject: Re: x86/sgx: uapi change proposal Message-ID: <20181220131213.GA4848@linux.intel.com> References: <20181214215729.4221-1-sean.j.christopherson@intel.com> <7706b2aa71312e1f0009958bcab24e1e9d8d1237.camel@linux.intel.com> <598cd050-f0b5-d18c-96a0-915f02525e3e@fortanix.com> <20181219091148.GA5121@linux.intel.com> <613c6814-4e71-38e5-444a-545f0e286df8@fortanix.com> <20181219144515.GA30909@linux.intel.com> <20181220103204.GB26410@linux.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181220103204.GB26410@linux.intel.com> Organization: Intel Finland Oy - BIC 0357606-4 - Westendinkatu 7, 02160 Espoo User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 20, 2018 at 12:32:04PM +0200, Jarkko Sakkinen wrote: > On Wed, Dec 19, 2018 at 06:58:48PM -0800, Andy Lutomirski wrote: > > Can one of you explain why SGX_ENCLAVE_CREATE is better than just > > opening a new instance of /dev/sgx for each encalve? > > I think that fits better to the SCM_RIGHTS scenario i.e. you could send > the enclav to a process that does not have necessarily have rights to > /dev/sgx. Gives more robust environment to configure SGX. My only open for the implementation is where to swap? If it is a VMA, whose VMA? Please share your views here. Not a blocker for me to work on the implementation, though. I'll use a private shmem file up until there is a better option. This ioctl API discussion is kind of meaningless for me ATM because it does not have that much effect to the internals even if it wouldn't be perfect in v19. Very trival to change. /Jarkko