Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <cover.1545308167.git.shayenneluzmoura@gmail.com> <c079f461575aece9d598784da25aaadc711a2729.1545308167.git.shayenneluzmoura@gmail.com>
In-Reply-To: <c079f461575aece9d598784da25aaadc711a2729.1545308167.git.shayenneluzmoura@gmail.com>
From:   Benjamin Gaignard <benjamin.gaignard@linaro.org>
Date:   Thu, 20 Dec 2018 14:24:43 +0100
Message-ID: <CA+M3ks5Lh-dQBhM44LrWnphOXfzvaGsZL4CrGMnTgv6nt2Uwdw@mail.gmail.com>
Subject: Re: [PATCH v2 4/7] drm: sti: Cleanup drm_display_mode print str
To:     Shayenne Moura <shayenneluzmoura@gmail.com>
Cc:     Maarten Lankhorst <maarten.lankhorst@linux.intel.com>,
        Maxime Ripard <maxime.ripard@bootlin.com>,
        Sean Paul <sean@poorly.run>, David Airlie <airlied@linux.ie>,
        Rob Clark <robdclark@gmail.com>,
        Vincent Abriou <vincent.abriou@st.com>,
        Jani Nikula <jani.nikula@linux.intel.com>,
        Joonas Lahtinen <joonas.lahtinen@linux.intel.com>,
        Rodrigo Vivi <rodrigo.vivi@intel.com>,
        Tomi Valkeinen <tomi.valkeinen@ti.com>,
        Neil Armstrong <narmstrong@baylibre.com>,
        Carlo Caione <carlo@caione.org>,
        Kevin Hilman <khilman@baylibre.com>,
        ML dri-devel <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Le jeu. 20 d=C3=A9c. 2018 =C3=A0 13:27, Shayenne Moura
<shayenneluzmoura@gmail.com> a =C3=A9crit :
>
> This patch adjust the print string of drm_display_mode object
> to remove drm_mode_object dependency in sti files.
>
> Signed-off-by: Shayenne Moura <shayenneluzmoura@gmail.com>

Acked-by: Benjamin Gaignard <benjamin;gaignard@linaro.org>

>
> ---
> Changes in v2:
>   - Use DRM_MODE_FMT/ARG macros (Daniel)
>   - Make the commit message more clear
>
>  drivers/gpu/drm/sti/sti_crtc.c | 16 ++++------------
>  1 file changed, 4 insertions(+), 12 deletions(-)
>
> diff --git a/drivers/gpu/drm/sti/sti_crtc.c b/drivers/gpu/drm/sti/sti_crt=
c.c
> index ed76e52eb213..ec9f87483e39 100644
> --- a/drivers/gpu/drm/sti/sti_crtc.c
> +++ b/drivers/gpu/drm/sti/sti_crtc.c
> @@ -53,18 +53,10 @@ sti_crtc_mode_set(struct drm_crtc *crtc, struct drm_d=
isplay_mode *mode)
>         struct clk *compo_clk, *pix_clk;
>         int rate =3D mode->clock * 1000;
>
> -       DRM_DEBUG_KMS("CRTC:%d (%s) mode:%d (%s)\n",
> -                     crtc->base.id, sti_mixer_to_str(mixer),
> -                     mode->base.id, mode->name);
> -
> -       DRM_DEBUG_KMS("%d %d %d %d %d %d %d %d %d %d 0x%x 0x%x\n",
> -                     mode->vrefresh, mode->clock,
> -                     mode->hdisplay,
> -                     mode->hsync_start, mode->hsync_end,
> -                     mode->htotal,
> -                     mode->vdisplay,
> -                     mode->vsync_start, mode->vsync_end,
> -                     mode->vtotal, mode->type, mode->flags);
> +       DRM_DEBUG_KMS("CRTC:%d (%s) mode: (%s)\n",
> +                     crtc->base.id, sti_mixer_to_str(mixer), mode->name)=
;
> +
> +       DRM_DEBUG_KMS(DRM_MODE_FMT "\n", DRM_MODE_ARG(mode));
>
>         if (mixer->id =3D=3D STI_MIXER_MAIN) {
>                 compo_clk =3D compo->clk_compo_main;
> --
> 2.17.1
>


--=20
Benjamin Gaignard

Graphic Study Group

Linaro.org =E2=94=82 Open source software for ARM SoCs

Follow Linaro: Facebook | Twitter | Blog