Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp991136imu; Thu, 20 Dec 2018 08:23:57 -0800 (PST) X-Google-Smtp-Source: AFSGD/W1JHXM1NPSf1IrbVbBGBiI5N5cY0kDnvIrNw9wsFsWAiocad0H+2L1n1lj5vFIcfeug2ek X-Received: by 2002:a62:1b50:: with SMTP id b77mr25110710pfb.36.1545323037780; Thu, 20 Dec 2018 08:23:57 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545323037; cv=none; d=google.com; s=arc-20160816; b=Iu5At3Uv2zZfLG7SGRA4TQ1seKdFkr7UlP7qPn1mW3Ds7DBt9kiKb5hEh/hLQYO1cF XWD/RwB4TqxDIq4XoBryJXL7FJ9ocIgUpc4mxl5TEG5ew6I3/Co1MbPoLDtJT9sylnUd a71BorBX+ZsjbeFsy1G+1zVghxbMZzTFOccTz7cxyBfIqwQbz/R/NpXDyr/ZGTEGXV/k KzEPbrYJ45LdlHVLWI7TlulDYgxr60+s06BX/bqesDrQnzeD6gwAt+L0hkkD7BobZfoQ V66+9ECKr6GDCFTG4JeCuuHPyumIdwDVkAa0R6OFX8YHXLo6t04m/LZnfj/205A3q8jO 4pSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=RxrUEgdFq4rLbHKk0WKHHzoAInmbxevQDGKt6fVeY8g=; b=vgU1B+xGuoFwFlq9Vl6j37AS9hT5C5shcVTi1xO/cA8NF9Pv1EuOYgpZLzumt3ox/o 7z8kVYSyW9KgyP7sX0S1VKiqHETZ+2SwAt62jEiPFw0ySk3i+TsTrtYuvAek0pkKaUG/ dLDnQ9SzTVBFTg87FhmyvvQquSxu8zp57RynDAVRh0hwjTHweVGdJnXN/IAk00iOr+3R sLkTIlb1usFtfZf14OSLsziZM5CXs9xaJN2vkeTN8FK9z3SRLIZHiho0948w65cTI3DG GgBlaqMSMAVxRv4irNz0G6G/PYtVKHgGz/iLQF5pfO3j+/AaDAmeM2RDD3PtZ2sySW9X O1Cw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k2si15689245pgh.63.2018.12.20.08.23.42; Thu, 20 Dec 2018 08:23:57 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=fail (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387737AbeLTOqa (ORCPT + 99 others); Thu, 20 Dec 2018 09:46:30 -0500 Received: from mx1.redhat.com ([209.132.183.28]:51414 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732874AbeLTOq3 (ORCPT ); Thu, 20 Dec 2018 09:46:29 -0500 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6ECF9C0495A9; Thu, 20 Dec 2018 14:46:29 +0000 (UTC) Received: from treble (ovpn-120-179.rdu2.redhat.com [10.10.120.179]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 0951A19C7B; Thu, 20 Dec 2018 14:46:27 +0000 (UTC) Date: Thu, 20 Dec 2018 08:46:26 -0600 From: Josh Poimboeuf To: Miroslav Benes Cc: Jiri Kosina , yamada.masahiro@socionext.com, michal.lkml@markovi.net, jeyu@kernel.org, pmladek@suse.com, linux-kbuild@vger.kernel.org, live-patching@vger.kernel.org, linux-kernel@vger.kernel.org, Joao Moreira Subject: Re: [PATCH] kbuild: use -flive-patching when CONFIG_LIVEPATCH is enabled Message-ID: <20181220144626.2uwuzsmdowbrmxxq@treble> References: <20181219141744.32392-1-mbenes@suse.cz> <20181219165428.5udrppedpdvf2u7k@treble> <20181219172127.o753af7pkrsttcgl@treble> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: User-Agent: NeoMutt/20180716 X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.31]); Thu, 20 Dec 2018 14:46:29 +0000 (UTC) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 20, 2018 at 09:33:05AM +0100, Miroslav Benes wrote: > > > Though, upstream, almost everybody seems to use kpatch-build, for which > > > this patch doesn't help. And people will continue to do so until we > > > have decent source-based tooling. Will the klp-convert patches be > > > revived soon? > > > > Let me add Joao, who's working on that. > > > > Joao, I think you had something basically ready for upstream exposure, > > right? > > I think that when Joao posted it a long time ago, the conclusion was that > it would be better to wait for the source-based tooling and have the > complete solution. I may misremember though. > > If Josh thinks that it would be acceptable to have klp-convert merged even > without the tooling, I'm all for it. > > We're about to start using it at SUSE and staying close to upstream would > definitely be better. A complete toolchain should definitely be the end goal. But as a usable first step, only *some* of the tooling is required, since some of the steps can be done manually, right? So starting out, for something usable, I believe the following would be the bare minimum: * -flive-patching * The analysis tool which analyzes the -fdump-ipa-clones files * klp-convert * Documentation describing the end-to-end patch creation process, including the manual steps and how to use the above tools Did I miss anything? Then over time we can fill in the gaps (manual steps) with automation. -- Josh