Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1007085imu; Thu, 20 Dec 2018 08:38:33 -0800 (PST) X-Google-Smtp-Source: AFSGD/W9Smfo1fS3Nghe0Bx0OjIsdeD03OuSB8lWxwFa4U5XSlfNE1ezr2V52ViVbcmd+NSVUj/q X-Received: by 2002:a63:9d05:: with SMTP id i5mr6646854pgd.98.1545323913659; Thu, 20 Dec 2018 08:38:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545323913; cv=none; d=google.com; s=arc-20160816; b=L7MifMjhRWDdSMxFy5b19BK0ivjQZNvIIwS1FapP4fZdsDCG0/6NOevvpkYVs+q/+1 xQ2YYklB7YhU0qfHmex0C0Chnv76ZeSywlnhgSNQUwShzECOKbp4adpOw8Tv+B11wdZm cNMp2rhUmSHkU1RldU5qDPDG5J2262WB4VacvuodL7IzRO5obJaP3k46s/OLSYELbv9Q c3dkhS/wSv4o47lMZVcJH7RjihhmR6ZuiBdtAJtxtqnlKe4lbompA6YHXYnS8pptZykm 4b06rIgr1ItT7q9YzQjdZMg2yb17l1sZgsNMG+MF2te2hvp4avkI1MW45Un1TCS55Dm4 sgyA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:organization:autocrypt:openpgp:from:references:cc:to :subject; bh=Da7pimZPTOQ9VIMXC9mIl2Tx5wQyITKUH7jPJ4w4HVU=; b=jrrpBmjkrBV7noe3pBWYOU49OAPZGu1a3ZLGRI+V0r9S6BUd8ghQjOUawkuhi7sOMH p64VafdL9NFaf5MaWLwRwjgJAiegPEi6p23NRpMFVQtfVmMQbeIjguGy4ox6Q8tNcmeH Te2I3NUEMvLOXNDri+i5nTBnPwyxXrtk2/GAU8GKv2yNSnu3OvyEnXoIoH2MISuDCoHL dAcG+UQyE7gQwfByzBZ0U+2rW1YtaxLwq0cWNU+IwevE0XvYOhLY2hp57q33umZXdmt6 Bhe/vLuM+gjObjgJNBWtIbQLjn5XHfvIawFaWlUrBoo9Xya4ruR2UYpwegmILps+Gp9b Cg4Q== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v7si17903190plo.12.2018.12.20.08.38.18; Thu, 20 Dec 2018 08:38:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730888AbeLTPbm (ORCPT + 99 others); Thu, 20 Dec 2018 10:31:42 -0500 Received: from mx2.suse.de ([195.135.220.15]:56200 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1725440AbeLTPbl (ORCPT ); Thu, 20 Dec 2018 10:31:41 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id 64D85AF8D; Thu, 20 Dec 2018 15:31:38 +0000 (UTC) Subject: Re: [PATCH v5 5/6] net: maclorawan: Implement maclorawan class module To: Ben Whitten Cc: Jian-Hong Pan , Jiri Pirko , "David S. Miller" , Alan Cox , "linux-lpwan@lists.infradead.org" , "netdev@vger.kernel.org" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" , Marcel Holtmann , Dollar Chen , Ken Yu , linux-wpan - ML References: <20181216101858.9585-6-starnight@g.ncu.edu.tw> <20181217140233.GG2096@nanopsycho> <60ff6940-4bcc-750c-ad38-0a183375169f@suse.de> From: =?UTF-8?Q?Andreas_F=c3=a4rber?= Openpgp: preference=signencrypt Autocrypt: addr=afaerber@suse.de; prefer-encrypt=mutual; keydata= xsFNBE6W6ZQBEAC/BIukDnkVenIkK9O14UucicBIVvRB5WSMHC23msS+R2h915mW7/vXfn+V 0nrr5ECmEg/5OjujKf0x/uhJYrsxcp45nDyYCk+RYoOJmGzzUFya1GvT/c04coZ8VmgFUWGE vCfhHJro85dZUL99IoLP21VXEVlCPyIngSstikeuf14SY17LPTN1aIpGQDI2Qt8HHY1zOVWv iz53aiFLFeIVhQlBmOABH2Ifr2M9loRC9yOyGcE2GhlzgyHGlQxEVGFn/QptX6iYbtaTBTU0 c72rpmbe1Nec6hWuzSwu2uE8lF+HYcYi+22ml1XBHNMBeAdSEbSfDbwc///8QKtckUzbDvME S8j4KuqQhwvYkSg7dV9rs53WmjO2Wd4eygkC3tBhPM5s38/6CVGl3ABiWJs3kB08asUNy8Wk juusU/nRJbXDzxu1d+hv0d+s5NOBy/5+7Pa6HeyBnh1tUmCs5/f1D/cJnuzzYwAmZTHFUsfQ ygGBRRKpAVu0VxCFNPSYKW0ULi5eZV6bcj+NAhtafGsWcv8WPFXgVE8s2YU38D1VtlBvCo5/ 0MPtQORqAQ/Itag1EHHtnfuK3MBtA0fNxQbb2jha+/oMAi5hKpmB/zAlFoRtYHwjFPFldHfv Iljpe1S0rDASaF9NsQPfUBEm7dA5UUkyvvi00HZ3e7/uyBGb0QARAQABzSJBbmRyZWFzIEbD pHJiZXIgPGFmYWVyYmVyQHN1c2UuZGU+wsF7BBMBAgAlAhsDBgsJCAcDAgYVCAIJCgsEFgID AQIeAQIXgAUCTqGJnQIZAQAKCRD6LtEtPn4BPzetD/4rF6k/HF+9U9KqykfJaWdUHJvXpI85 Roab12rQbiIrL4hVEYKrYwPEKpCf+FthXpgOq+JdTGJ831DMlTx7Ed5/QJ9KAAQuhZlSNjSc +FNobJm7EbFv9jWFjQC0JcOl17Ji1ikgRcIRDCul1nQh9jCdfh1b848GerZmzteNdT9afRJm 7rrvMqXs1Y52/dTlfIW0ygMA2n5Vv3EwykXJOPF6fRimkErKO84sFMNg0eJV9mXs+Zyionfi g2sZJfVeKjkDqjxy7sDDBZZR68I9HWq5VJQrXqQkCZUvtr6TBLI+uiDLbGRUDNxA3wgjVdS2 v9bhjYceSOHpKU+h3H2S8ju9rjhOADT2F5lUQMTSpjlzglh8IatV5rXLGkXEyum4MzMo2sCE Cr+GD6i2M3pHCtaIVV3xV0nRGALa6DdF7jBWqM54KHaKsE883kFH2+6ARcPCPrnPm7LX98h2 4VpG984ysoq6fpzHHG/KCaYCEOe1bpr3Plmmp3sqj0utA6lwzJy0hj5dqug+lqmg7QKAnxl+ porgluoY56U0X0PIVBc0yO0dWqRxtylJa9kDX/TKwFYNVddMn2NQNjOJXzx2H9hf0We7rG7+ F/vgwALVVYbiTzvp2L0XATTv/oX4BHagAa/Qc3dIsBYJH+KVhBp+ZX4uguxk4xlc2hm75b1s cqeAD87BTQROlumUARAAzd7eu+tw/52FB7xQZWDv5aF+6CAkoz7AuY4s1fo0AQQDqjLOdpQF bifdH7B8SnsA4eo0syfs+1tZW6nn9hdy1GHEMbeuvdhNwkhEfYGDYpSue7oVxB4jajKvRHAP VcewKZIxvIiZ5aSp5n1Bd7B0c0C443DHiWE/0XWSpvbU7fTzTNvdz+2OZmGtqCn610gBqScv 1BOiP3OfLly8ghxcJsos23c0mkB/1iWlzh3UMFIGrzsK3sZJ/3uRaLYFimmqqPlSwFqx3b0M 1gFdHWKfOpvQ4wwP5P10xwvqNXLWC30wB1QmJGD/X8aAoVNnGsmEL7GcWF4cLoOSRidSoccz znShE+Ap+FVDD6MRyesNT4D67l792//B38CGJRdELtNacdwazaFgxH9O85Vnd70ZC7fIcwzG yg/4ZEf96DlAvrSOnu/kgklofEYdzpZmW+Fqas6cnk6ZaHa35uHuBPesdE13MVz5TeiHGQTW xP1jbgWQJGPvJZ+htERT8SZGBQRb1paoRd1KWQ1mlr3CQvXtfA/daq8p/wL48sXrKNwedrLV iZOeJOFwfpJgsFU4xLoO/8N0RNFsnelBgWgZE3ZEctEd4BsWFUw+czYCPYfqOcJ556QUGA9y DeDcxSitpYrNIvpk4C5CHbvskVLKPIUVXxTNl8hAGo1Ahm1VbNkYlocAEQEAAcLBXwQYAQIA CQUCTpbplAIbDAAKCRD6LtEtPn4BPzA6D/9TbSBOPM99SHPX9JiEQAw4ITCBF2oTWeZQ6RJg RKpB15lzyPfyFbNSceJp9dCiwDWe+pzKaX6KYOFZ5+YTS0Ph2eCR+uT2l6Mt6esAun8dvER/ xlPDW7p88dwGUcV8mHEukWdurSEDTj8V3K29vpgvIgRq2lHCn2wqRQBGpiJAt72Vg0HxUlwN GAJNvhpeW8Yb43Ek7lWExkUgOfNsDCTvDInF8JTFtEXMnUcPxC0d/GdAuvBilL9SlmzvoDIZ 5k2k456bkY3+3/ydDvKU5WIgThydyCEQUHlmE6RdA3C1ccIrIvKjVEwSH27Pzy5jKQ78qnhv dtLLAavOXyBJnOGlNDOpOyBXfv02x91RoRiyrSIM7dKmMEINKQlAMgB/UU/6B+mvzosbs5d3 4FPzBLuuRz9WYzXmnC460m2gaEVk1GjpidBWw0yY6kgnAM3KhwCFSecqUQCvwKFDGSXDDbCr w08b3GDk40UoCoUq9xrGfhlf05TUSFTg2NlSrK7+wAEsTUgs2ZYLpHyEeftoDDnKpM4ghs/O ceCeyZUP1zSgRSjgITQp691Uli5Nd1mIzaaM8RjOE/Rw67FwgblKR6HAhSy/LYw1HVOu+Ees RAEdbtRt37A8brlb/ENxbLd9SGC8/j20FQjit7oPNMkTJDs7Uo2eb7WxOt5pSTVVqZkv7Q== Organization: SUSE Linux GmbH Message-ID: Date: Thu, 20 Dec 2018 16:31:34 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.3.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 20.12.18 um 11:19 schrieb Ben Whitten: >>>> The hard-MAC implementations will be on my plate mostly, as both SX1276 >>>> and SX1301 need the soft-MAC. >>> >>> On the SX1301 side of things, the ability to send messages as a LoRaWAN >>> node device is a niche use case, the majority if not all people will use the >>> concentrator card as the pass through gateway to the node. >>> >>> In this mode of operation the parameters for transmission such as; >> frequency, >>> spreading factor / data rate, power, are given by a remote server and passed >>> in from the userspace application which received it. >>> Eventually in the kernel these need to be checked locally to ensure >> regulatory >>> compliance. >>> To that end I have experimented with framing, as CAN does, so that this >>> metadata can be provided on a write from userspace to the SX1301 driver. >>> >>> Sounds like we need different protocols for framing within the protocol >> family. >>> Raw in the case of nodes and framed with metadata in the case of >> concentrator >>> cards, thoughts? >> >> Yes, I have thought the roles of node and gateway. They may have >> different skb passing paths. >> As you mentioned, many things of the gateway is controlled by the >> remote server. So, I only implement the path for nodes right now. >> Maybe, we can have a role flag: node, gateway which can be assigned by >> some way. Then, the skb can be decode, checked and passed according >> to the role flag. And module also checks the integrity (MIC, length >> ...) and filter out the bad skb before sends to next stop. > > As IP have IPPROTO_TCP, IPPROTO_UDP, etc maybe we can have > LORA_PROTO_MODULE, LORA_PROTO_GATEWAY which dictates the > pathway and skb format. No, please don't. You were on track with your earlier comment: The user decides what he wants to do by selecting PF_LORAWAN with SOCK_DGRAM/_SEQPACKET vs. SOCK_RAW (or PF_PACKET with ETH_P_LORA[WAN]). The terminology "gateway" has little to do with it. I've heard of packet forwarders using JSON format for communication with their backend, so it appears to highly depend on what exactly the gateway wants to do and how the user wants to access the needed data. Regards, Andreas -- SUSE Linux GmbH, Maxfeldstr. 5, 90409 Nürnberg, Germany GF: Felix Imendörffer, Jane Smithard, Graham Norton HRB 21284 (AG Nürnberg)