Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp47290imu; Thu, 20 Dec 2018 16:38:31 -0800 (PST) X-Google-Smtp-Source: ALg8bN7gt6dwxT1T789b3KYfihRzhp2+0bPwuX4R37dwzEL4aO7x29PItCOzHh/H45LDnX6Axdy/ X-Received: by 2002:a63:5f50:: with SMTP id t77mr377564pgb.76.1545352711620; Thu, 20 Dec 2018 16:38:31 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545352711; cv=none; d=google.com; s=arc-20160816; b=nKddDoMD9hCn/5/SLIbF3kijEDAxoS6BmahOKImOoI4cc/kIS7IG/Ridbd/ycxrw2Z rZ3iOuDpLKxyLsJh7r+lah2IioSEyj3w3Qn6J3My4uc7Y9nlBzjz1oPJQstrAfeQwyI1 /WyblyWBELq1iVxpTGBdGwQVt4kBcGwXRurta3D+6FiEZtApkeVpy1OpDPceOxUDMa44 toXadYlJ6fyejZ7GZBFCWApkB7zBw+nMyxenvspR3yT6bWgaZ5Vet74v10KIFb5YHUV9 VfVXrS1JOR6XbvhBMAfZOrmxUAANPruGZWCe7oCd0+k3a251QBFYldlaKItUGvu5Fmw8 DoMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-disposition :content-transfer-encoding:mime-version:robot-unsubscribe:robot-id :git-commit-id:subject:to:references:in-reply-to:reply-to:cc :message-id:from:date; bh=9oXgAFKUr9oyTv+J1vSSZBqMaU3GXXENaPGmiRWwZH0=; b=UKm6eorx1b9t/IS2KrDz5aRIFr5qAgeTXLBudrji2AIAYSdxGSBnvHXxKXuYM7U8hK EjVpf1o1x/43JIpvlQE8PjYv2XjbLtfqaLu/1Ca9QIfFSyg6l8MSfHE48JoGTaKPhZUv JfAmbsr9T92EOEfXKV1xe2ksOKrD3KKuP55IFpGxCC1vVz42v+txr+CYGSzhNH3KFCv4 Put5jPXiwauahj14j+X/jkIWYuS2to4pO8/DEAYLD2nF0OoXEOmuOuLLByuoV64gTWxl ThlaT7mN2aeYpf07DgGjhQctP/szD5Ll8P3kjubWhEhA+KKx02+4bL6eO4AT9WOqR5Bn A8CQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id x13si22123931pgx.266.2018.12.20.16.38.15; Thu, 20 Dec 2018 16:38:31 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732086AbeLTSNj (ORCPT + 99 others); Thu, 20 Dec 2018 13:13:39 -0500 Received: from terminus.zytor.com ([198.137.202.136]:49269 "EHLO terminus.zytor.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727993AbeLTSNj (ORCPT ); Thu, 20 Dec 2018 13:13:39 -0500 Received: from terminus.zytor.com (localhost [127.0.0.1]) by terminus.zytor.com (8.15.2/8.15.2) with ESMTPS id wBKIDSrv3682424 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 20 Dec 2018 10:13:28 -0800 Received: (from tipbot@localhost) by terminus.zytor.com (8.15.2/8.15.2/Submit) id wBKIDSID3682420; Thu, 20 Dec 2018 10:13:28 -0800 Date: Thu, 20 Dec 2018 10:13:28 -0800 X-Authentication-Warning: terminus.zytor.com: tipbot set sender to tipbot@zytor.com using -f From: tip-bot for Leo Yan Message-ID: Cc: linux-kernel@vger.kernel.org, mike.leach@linaro.org, hpa@zytor.com, alexander.shishkin@linux.intel.com, tglx@linutronix.de, acme@redhat.com, namhyung@kernel.org, jolsa@redhat.com, leo.yan@linaro.org, robert.walker@arm.com, mingo@kernel.org, mathieu.poirier@linaro.org Reply-To: mathieu.poirier@linaro.org, leo.yan@linaro.org, mingo@kernel.org, robert.walker@arm.com, namhyung@kernel.org, jolsa@redhat.com, acme@redhat.com, tglx@linutronix.de, alexander.shishkin@linux.intel.com, mike.leach@linaro.org, hpa@zytor.com, linux-kernel@vger.kernel.org In-Reply-To: <1544513908-16805-4-git-send-email-leo.yan@linaro.org> References: <1544513908-16805-4-git-send-email-leo.yan@linaro.org> To: linux-tip-commits@vger.kernel.org Subject: [tip:perf/core] perf cs-etm: Remove unused 'trace_on' in cs_etm_decoder Git-Commit-ID: cee7a6a212ddb514d6e2ac1f9733501c43d63d0a X-Mailer: tip-git-log-daemon Robot-ID: Robot-Unsubscribe: Contact to get blacklisted from these emails MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Content-Type: text/plain; charset=UTF-8 Content-Disposition: inline X-Spam-Status: No, score=-2.9 required=5.0 tests=ALL_TRUSTED,BAYES_00 autolearn=ham autolearn_force=no version=3.4.2 X-Spam-Checker-Version: SpamAssassin 3.4.2 (2018-09-13) on terminus.zytor.com Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Commit-ID: cee7a6a212ddb514d6e2ac1f9733501c43d63d0a Gitweb: https://git.kernel.org/tip/cee7a6a212ddb514d6e2ac1f9733501c43d63d0a Author: Leo Yan AuthorDate: Tue, 11 Dec 2018 15:38:23 +0800 Committer: Arnaldo Carvalho de Melo CommitDate: Tue, 18 Dec 2018 12:23:59 -0300 perf cs-etm: Remove unused 'trace_on' in cs_etm_decoder cs_etm_decoder::trace_on is being assigned when TRACE_ON or NO_SYNC element is coming, but it is never used hence it is redundant and can be removed. So let's remove 'trace_on' field from cs_etm_decoder struct. Suggested-by: Mathieu Poirier Signed-off-by: Leo Yan Reviewed-by: Mathieu Poirier Cc: Alexander Shishkin Cc: Jiri Olsa Cc: Mathieu Poirier Cc: Mike Leach Cc: Namhyung Kim Cc: Robert Walker Cc: coresight@lists.linaro.org Cc: linux-arm-kernel@lists.infradead.org Link: http://lkml.kernel.org/r/1544513908-16805-4-git-send-email-leo.yan@linaro.org Signed-off-by: Arnaldo Carvalho de Melo --- tools/perf/util/cs-etm-decoder/cs-etm-decoder.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c index 0b4c8629f578..97b39b1f5759 100644 --- a/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c +++ b/tools/perf/util/cs-etm-decoder/cs-etm-decoder.c @@ -36,7 +36,6 @@ struct cs_etm_decoder { void *data; void (*packet_printer)(const char *msg); - bool trace_on; dcd_tree_handle_t dcd_tree; cs_etm_mem_cb_type mem_access; ocsd_datapath_resp_t prev_return; @@ -411,12 +410,10 @@ static ocsd_datapath_resp_t cs_etm_decoder__gen_trace_elem_printer( case OCSD_GEN_TRC_ELEM_UNKNOWN: break; case OCSD_GEN_TRC_ELEM_NO_SYNC: - decoder->trace_on = false; break; case OCSD_GEN_TRC_ELEM_TRACE_ON: resp = cs_etm_decoder__buffer_trace_on(decoder, trace_chan_id); - decoder->trace_on = true; break; case OCSD_GEN_TRC_ELEM_INSTR_RANGE: resp = cs_etm_decoder__buffer_range(decoder, elem,