Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp96950imu; Thu, 20 Dec 2018 17:46:58 -0800 (PST) X-Google-Smtp-Source: ALg8bN7/dPlHyyrFEC3Vm6cEhjbNXFqgCyzcSkQdfCr7asjJ3xve8xf4y+I6caVLKvDDniBcTRGx X-Received: by 2002:a63:31cc:: with SMTP id x195mr558877pgx.52.1545356818419; Thu, 20 Dec 2018 17:46:58 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545356818; cv=none; d=google.com; s=arc-20160816; b=yiqTRY96l1nJvNEbpfulMUyzKScWYQfffz8uq6lAyMlQgPtYcNE5bmrk2cUsKdCl3T EahF4Y5c6t6/WdtIydcJ13Xa2hQwULDjYFWJatwg8K733oL85SnR5u31+mKWNM7Y9acG HAfEYClxPataJw10ccGDbFv1Z1jSlaqeT2a1YSk5Y6/QNLR3v7J2se1T2bRnmjWV7zcp EUD1OcS+07YCHeiQAqCi0h7rIdpkfSre/ser/7B7OfO+m/1VL7QyDM98Oy18X3IZZApE ZJu3rFhggDbnRPruCI10WbkqtHKtyz+PPZWPehNP3wW0Lz9rylE1uZd8uggVR6m0CDFK phJw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:cms-type :content-transfer-encoding:in-reply-to:mime-version:user-agent:date :message-id:from:cc:to:subject:dkim-signature:dkim-filter; bh=OmsqKTefN/X3Fj5MKU2kcmAyXr69Rl0GRhWimkYIyFs=; b=o9CPkQq0M7IAGE69c2rv+CQusqTXs3VhaRy66dG5sm3NHbg7csr+fmzNwiCGPSGMle PREVP/p2hOXpCErcO7z8Lq50u6L4mMBeAfbUyzqP6jzHfjs7Ur0dBu7wHqui60GteOGW qtHxF1mz2s4fKhFpfFTtKtjVQQrW+VA7yNwsmqWdSXcqcv03ogBH0Kon2gc9jVHUAkhC nG/NtXMnJpNUsAKjHiQ1ieTaZ2Ty4bcfR80dcTC1AAhdFIGSYenxdN4/yOlKjb12QGmr kbf7twg02D5qQGGy5vRTX3f7HMWiybwQTXQ1Aj22FK4dZj6e4TR3ZXm5PMSzE3zx5a28 a/CA== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b="V/T4nlX0"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id c76si19015268pga.70.2018.12.20.17.46.39; Thu, 20 Dec 2018 17:46:58 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@samsung.com header.s=mail20170921 header.b="V/T4nlX0"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=samsung.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2388296AbeLTR6y (ORCPT + 99 others); Thu, 20 Dec 2018 12:58:54 -0500 Received: from mailout2.w1.samsung.com ([210.118.77.12]:43331 "EHLO mailout2.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1732962AbeLTR6x (ORCPT ); Thu, 20 Dec 2018 12:58:53 -0500 Received: from eucas1p2.samsung.com (unknown [182.198.249.207]) by mailout2.w1.samsung.com (KnoxPortal) with ESMTP id 20181220175851euoutp029308cc810ccaa75e550c71e2b3023d33~yHEtObnJE0863608636euoutp026 for ; Thu, 20 Dec 2018 17:58:51 +0000 (GMT) DKIM-Filter: OpenDKIM Filter v2.11.0 mailout2.w1.samsung.com 20181220175851euoutp029308cc810ccaa75e550c71e2b3023d33~yHEtObnJE0863608636euoutp026 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=samsung.com; s=mail20170921; t=1545328731; bh=OmsqKTefN/X3Fj5MKU2kcmAyXr69Rl0GRhWimkYIyFs=; h=Subject:To:Cc:From:Date:In-Reply-To:References:From; b=V/T4nlX0RpG8o9dqAX6i9aORBGM2bcaktpkte8nwZhuV6iQha9kmnq8EV2D726WdY eVQ4z2mQCUpCyqaOJa/mKXWvnr4NtpufVKk/1Ly6gs1XheUy9KJLb6CZmIaSC0CuvZ 7iOxRHppAx4qaN8oBNYVidM3eRATyh384L53WXCo= Received: from eusmges1new.samsung.com (unknown [203.254.199.242]) by eucas1p1.samsung.com (KnoxPortal) with ESMTP id 20181220175851eucas1p16e8f6b602746a85eadfc102e34bce7a6~yHEsySM810166901669eucas1p13; Thu, 20 Dec 2018 17:58:51 +0000 (GMT) Received: from eucas1p1.samsung.com ( [182.198.249.206]) by eusmges1new.samsung.com (EUCPMTA) with SMTP id 95.3F.04441.B58DB1C5; Thu, 20 Dec 2018 17:58:51 +0000 (GMT) Received: from eusmtrp1.samsung.com (unknown [182.198.249.138]) by eucas1p1.samsung.com (KnoxPortal) with ESMTPA id 20181220175850eucas1p1ea29841e7bbde2f76f4ec42cd4db24ba~yHEr8nHg70166801668eucas1p14; Thu, 20 Dec 2018 17:58:50 +0000 (GMT) Received: from eusmgms2.samsung.com (unknown [182.198.249.180]) by eusmtrp1.samsung.com (KnoxPortal) with ESMTP id 20181220175850eusmtrp1323382a5178abd6e3dd1930a07900d6d~yHEruQ-AF0934709347eusmtrp10; Thu, 20 Dec 2018 17:58:50 +0000 (GMT) X-AuditID: cbfec7f2-5c9ff70000001159-27-5c1bd85b6222 Received: from eusmtip2.samsung.com ( [203.254.199.222]) by eusmgms2.samsung.com (EUCPMTA) with SMTP id 4C.DF.04128.A58DB1C5; Thu, 20 Dec 2018 17:58:50 +0000 (GMT) Received: from [106.120.53.102] (unknown [106.120.53.102]) by eusmtip2.samsung.com (KnoxPortal) with ESMTPA id 20181220175849eusmtip2b962ca447031fd8e2b7ec3f832350435~yHErYxF2u2206422064eusmtip2X; Thu, 20 Dec 2018 17:58:49 +0000 (GMT) Subject: Re: [PATCH] fbdev: fsl-diu: remove redundant null check on cmap To: Timur Tabi , Wen Yang Cc: linux-fbdev@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, zhong.weidong@zte.com.cn From: Bartlomiej Zolnierkiewicz Message-ID: Date: Thu, 20 Dec 2018 18:58:49 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: Content-Transfer-Encoding: 7bit X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprMKsWRmVeSWpSXmKPExsWy7djPc7rRN6RjDO7fZbe48vU9m8WJvg+s Fpd3zQGyfqtbnHv1k81iU8dRdgc2j02rOtk87ncfZ/L4vEnOY82+HywBLFFcNimpOZllqUX6 dglcGUfe7GMseMhcsXLZA7YGxmbmLkZODgkBE4kDl7+ydDFycQgJrGCUmLa4nw3C+cIo0bjx LyOE85lRYmfjezaYlmOdh9khEssZJR6d62CCcN4zShzbOYMFpEpYwEPiastdsA4RAWeJxbt/ g8WZBaok/u5ZChZnE7CSmNi+ihHE5hWwk1iy9juYzSKgKnF19VEgm4NDVCBCov+MOkSJoMTJ mU/AxnAClXfMv8QOMVJeYvvbOcwgN0gI9LNLXGv/yAbSKyHgIrFziTvE0cISr45vYYewZSRO T+5hgaifzijx5tdSKGc9o8SaM8eYIKqsJQ4fv8gKMohZQFNi/S59iLCjxIrlj1kh5vNJ3Hgr CHEDn8SkbdOZIcK8Eh1tQhDVahIblm1gg1nbtXMlNNg9JH6+uco+gVFxFpLPZiH5ZhbC3gWM zKsYxVNLi3PTU4sN81LL9YoTc4tL89L1kvNzNzECk8rpf8c/7WD8einpEKMAB6MSD++F7dIx QqyJZcWVuYcYJTiYlUR41x8CCvGmJFZWpRblxxeV5qQWH2KU5mBREuetZngQLSSQnliSmp2a WpBaBJNl4uCUamAsufH53rQEW71I9hrTWXrTnMJiQro3vppiIrz32vfi/YGcaZeE5yTMYxFg MVu56jjLWo3Elyd+3Co9nrv00fvec2UxX7irPrVYpN8KmXadte/rx+S6lzySbK0BXS9nHrOe 9pL33uv3xZedRR5x1qz4Uha9c4fGBzkWn9qKskWNlVmqrilr3z9XYinOSDTUYi4qTgQAGshl TiYDAAA= X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprFIsWRmVeSWpSXmKPExsVy+t/xe7pRN6RjDNobeC2ufH3PZnGi7wOr xeVdc4Cs3+oW5179ZLPY1HGU3YHNY9OqTjaP+93HmTw+b5LzWLPvB0sAS5SeTVF+aUmqQkZ+ cYmtUrShhZGeoaWFnpGJpZ6hsXmslZGpkr6dTUpqTmZZapG+XYJexpE3+xgLHjJXrFz2gK2B sZm5i5GTQ0LAROJY52H2LkYuDiGBpYwSpxY9Zeti5ABKyEgcX18GUSMs8edaFxtEzVtGiZ0n +1hBEsICHhJXW+6ygdgiAs4Si3f/ZoEoOsQosfXGGRaQBLNAlcStv4+YQGw2ASuJie2rGEFs XgE7iSVrv4PZLAKqEldXHwWzRQUiJG497GCBqBGUODnzCZjNCVTfMf8SO8RMdYk/8y4xQ9jy EtvfzmGewCg4C0nLLCRls5CULWBkXsUoklpanJueW2ykV5yYW1yal66XnJ+7iREYL9uO/dyy g7HrXfAhRgEORiUeXo1d0jFCrIllxZW5QE9xMCuJ8K4/BBTiTUmsrEotyo8vKs1JLT7EaAr0 xERmKdHkfGAs55XEG5oamltYGpobmxubWSiJ8543qIwSEkhPLEnNTk0tSC2C6WPi4JRqYDx/ 41ZNhM60m5duTGzcJnyql12f2XgG650X+Q52O+20SnzTlvZYta84lfbZUXvtAVWv76+Vk3Yf yJnZurj6crCb+MI+kX0mF8Sy/y85MePsrhO/u8rEZ9fKfHvZtn3n/UPGHy25FP9s/5Wq/PDL u/el3nmaG7iCWJflLikz+lslsmsSv8fX+OtKLMUZiYZazEXFiQA+QhCGrQIAAA== X-CMS-MailID: 20181220175850eucas1p1ea29841e7bbde2f76f4ec42cd4db24ba X-Msg-Generator: CA Content-Type: text/plain; charset="utf-8" X-RootMTR: 20181203145425epcas5p31989c68b52994dd2e85f4372082a7ebe X-EPHeader: CA CMS-TYPE: 201P X-CMS-RootMailID: 20181203145425epcas5p31989c68b52994dd2e85f4372082a7ebe References: <20181203064317.57054-1-wen.yang99@zte.com.cn> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 12/03/2018 03:53 PM, Timur Tabi wrote: > On 12/3/18 12:43 AM, Wen Yang wrote: >> The null check on &info->cmap is redundant since cmap is a struct >> inside fb_info and can never be null, so the check is always true. >> we may remove it. >> >> Signed-off-by: Wen Yang > > Acked-by: Timur Tabi Patch queued for 4.21, thanks. Best regards, -- Bartlomiej Zolnierkiewicz Samsung R&D Institute Poland Samsung Electronics