Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp408675imu; Fri, 21 Dec 2018 00:59:46 -0800 (PST) X-Google-Smtp-Source: ALg8bN4bUDgI2o2hvWnHEpJ570xHQIp4KU4+Gf5oFumfkHzr9DReBTflrn4AU8rUZe9ddzs0DIkK X-Received: by 2002:a63:70c:: with SMTP id 12mr1533872pgh.352.1545382786719; Fri, 21 Dec 2018 00:59:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545382786; cv=none; d=google.com; s=arc-20160816; b=cnnXIHqZi7UD1w2c0Lm+cAzjZzpUJg6hfthEYiGaoSiTOvXVy/mTNDe+rdlKnKzzBq wK/RC8YtiCNNaG3JgfxdOvAep/8o4tA8Ri9JaOsZRE31ADOP2ivPZCZvNo6J+b54NHSn vXHS6gw8Ix/YFVdWP4bOB7RQGwHFHz+LgApig2X8PWQNaXQuLcFC3Xpwp6QOTdt5KZjV +eSuIneTDEfuZZjE6IZfvU8QZNgmo5vgjzoYUjmLsN6Vj2Lj+MikB2E6WTPveeI6ZI86 i7yR+S11VmS+cJmgJSry273ba0ol2JEL55XA7IyrYofJ5ygi8HYoo3N4Iwf8GWYoB9/J S8Uw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:to :from:date:dkim-signature; bh=BhjaUnK16zGKnRXNgkzTnJdVhtTx9utaISBIjymdBkg=; b=ki3DePAYs9B923UF6Z+7R/JIn9mhgiP1H0Cm9xQFrqajExYD07QEJS/mjZJoOX3P/d nLrzfp5pssh1U3nLafIH7Gs4VotfWmRaf5KKHUnNydGe0lxdoH+n6XXktCQxpRt1lfxf z7PVH5c6Rpx/E7wGqYBT+zaxUtrhC5GJ9Q42LkP4fKC6qBIgUFAHjbEoDXBKddmkd3dN Z615Zipze8suLD4Tf5DYA1PY+0kbWIsUrXmfrUwoel8yf2X28TQNfGovXthIjYqNJcSs oBNbKlwPTeVlRnLSvyzA6N5B3ZD2/rd9soQ5bzYRG38eetm5M8GZhtarY6sIpy3GiDR0 ENwA== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="rERjj/vH"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 64si21646622pfe.74.2018.12.21.00.59.31; Fri, 21 Dec 2018 00:59:46 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b="rERjj/vH"; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731390AbeLUHEx (ORCPT + 99 others); Fri, 21 Dec 2018 02:04:53 -0500 Received: from bombadil.infradead.org ([198.137.202.133]:53308 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbeLUHEw (ORCPT ); Fri, 21 Dec 2018 02:04:52 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version :References:Message-ID:Subject:To:From:Date:Sender:Reply-To:Cc: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=BhjaUnK16zGKnRXNgkzTnJdVhtTx9utaISBIjymdBkg=; b=rERjj/vH4XYpJx6BWorgDV/97 4hP1N1YiTMm+aE4NL2Vaubli693TZUl6FWewFk0sOQOAuMXaHAUepRzh3WwmVNhnwcak9DPRSOSWU AozAbbYB+dNolPb4e1Z95vb/U3KOl6iIUe1nIniQiQRN1UQSpV0+1LqlA3WgK+3vzAT8F+V5X4a17 YB1zuZo6Wix5gJ3+S5M8Veokso7ZzpPXYFHOxpjgvJrfPkNsx+CE70gStDRBmHr7TYsznvwHHhltt A5vG/s6a7fyYYBwO201S2NB+idGiDOPovub9c1yXUWOukGZ+7IWmPYydf34HaptTRA59OyV0Zw4f4 Ss++AdUwg==; Received: from hch by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux)) id 1gaErX-00074U-SD; Fri, 21 Dec 2018 07:04:47 +0000 Date: Thu, 20 Dec 2018 23:04:47 -0800 From: Christoph Hellwig To: "Theodore Y. Ts'o" , Dave Chinner , Christoph Hellwig , "Darrick J. Wong" , Eric Biggers , linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-ext4@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org, Jaegeuk Kim , Victor Hsieh , Chandan Rajendra , Linus Torvalds Subject: Re: [PATCH v2 01/12] fs-verity: add a documentation file Message-ID: <20181221070447.GA21687@infradead.org> References: <20181219071420.GC2628@infradead.org> <20181219021953.GD31274@dastard> <20181219193005.GB6889@mit.edu> <20181219213552.GO6311@dastard> <20181220220158.GC2360@mit.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181220220158.GC2360@mit.edu> User-Agent: Mutt/1.9.2 (2017-12-15) X-SRS-Rewrite: SMTP reverse-path rewritten from by bombadil.infradead.org. See http://www.infradead.org/rpr.html Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 20, 2018 at 05:01:58PM -0500, Theodore Y. Ts'o wrote: > That's simply not true. Number one, fsverity is not mandatory for all > file systems to implement. If XFS doesn't want to implement fscrypt > or fsverity, it doesn't have to. Number two, we're not *making* any > changes to the kernel code; nothing in mm/filemap.c, et. al. So > saying that we are making changes that are impacted by /everyone/ just > doesn't make any sense. Ted, I think you know yourself this isn't true. Whenever we added useful interface to one of the major file systems we had other pick it up, and that is a good thing because the last thing we need is fragmentation of interfaces. And even if that wasn't the case I don't think we should take short cuts, because even if an interface was just for a file system or two it still needs to be properly desgined. There is no reason to rush interfacs in, because everytime we have done that it has turned out to be a very bad idea in retrospective.