Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp408769imu; Fri, 21 Dec 2018 00:59:53 -0800 (PST) X-Google-Smtp-Source: ALg8bN6ZP47wRkwRNYV923n3ovmno0jSFPxqfCb7qbC20p84F8wKDv0uDhuixBQ6N/jE9atO+yh2 X-Received: by 2002:a17:902:a83:: with SMTP id 3mr1573854plp.276.1545382793623; Fri, 21 Dec 2018 00:59:53 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545382793; cv=none; d=google.com; s=arc-20160816; b=pFJNnC+HUtjiNeW5YuaMVBIqFJsjjqidG/6RM7m8QmctHK/FJ8P20iDL85x+clcppg Ec8F/KhttbweLZFoanXreVzlCHKrGYppXnRE+nB8ABUmdSV8zColBRXPC9bNsABaCOk0 2l70hQJYpisU4hiXWlvwKzCDWF3lRWGzUt2RngusAvb4tXuUMCLebdytkQPPlJvdNYl0 R+kb0Md3GdcTIUTRHedpe5uMaHAxlrJfK1kfqEznz3aWhodBhgVS23KJFYuQXTVckEIX 3u7lU04KBPyDbXB3eLsPtOaFBOYhgOAUJKA61PyZG4vaCtXJ7LAGhRGsrGN+lBJf4t7u hBkA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:message-id:date:subject:cc:to:from :dkim-signature; bh=pGIPypqT2PiUODlArqmI2NTe3ZsH7Y81qX+Z5Er/VLk=; b=gegNV0IEsN3v23X7elkFjhkEiGkmbQF/VIg59XxFlsAn/7qAQagco3bBsnhFiMTyEv qBx0dEQjp5NLrkZ+sJlk5r6HvTidqld6MtemeGURT2slbm7dLKyzf8rjeIY4qjVnBosX GsNrAV+RyDmtQNxIsf5IRcluIEzgKYgSCi7psno2PvMkxJ4ZXnfCfhD4pjC/lklar+xB 3sefxjCNWtTn4qKWUlNb4k1qgK5gU5ipyYKmCAp/nJmT2dZZMM6t6FsSdIZg/u+biyNp mI6F4oV6Jw7BlpvRddY9WrkFsyvMIFtRMLs0XuWvhez6bFR/d/47Ew4pWoMfT51/DiIE xwYw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=cPgOYknW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id v75si5418352pfd.157.2018.12.21.00.59.38; Fri, 21 Dec 2018 00:59:53 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@umn.edu header.s=google header.b=cPgOYknW; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=umn.edu Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1731644AbeLUHHr (ORCPT + 99 others); Fri, 21 Dec 2018 02:07:47 -0500 Received: from mta-p8.oit.umn.edu ([134.84.196.208]:48632 "EHLO mta-p8.oit.umn.edu" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725372AbeLUHHr (ORCPT ); Fri, 21 Dec 2018 02:07:47 -0500 Received: from localhost (unknown [127.0.0.1]) by mta-p8.oit.umn.edu (Postfix) with ESMTP id 8C9A1D1C for ; Fri, 21 Dec 2018 07:07:45 +0000 (UTC) X-Virus-Scanned: amavisd-new at umn.edu Received: from mta-p8.oit.umn.edu ([127.0.0.1]) by localhost (mta-p8.oit.umn.edu [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id 5dhhOFunfLrj for ; Fri, 21 Dec 2018 01:07:45 -0600 (CST) Received: from mail-io1-f70.google.com (mail-io1-f70.google.com [209.85.166.70]) (using TLSv1.2 with cipher AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mta-p8.oit.umn.edu (Postfix) with ESMTPS id 5DAC8CF7 for ; Fri, 21 Dec 2018 01:07:45 -0600 (CST) Received: by mail-io1-f70.google.com with SMTP id k4so3575930ioc.10 for ; Thu, 20 Dec 2018 23:07:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=umn.edu; s=google; h=from:to:cc:subject:date:message-id; bh=pGIPypqT2PiUODlArqmI2NTe3ZsH7Y81qX+Z5Er/VLk=; b=cPgOYknW7lcmF3E9I/V+nQp8JLwrCVe4ohunmWTmALIc3tKSDcSUK8GypNoaNOKbIA w1b+XPuXpsZHYwLiKjLlIqR5KU+k/onHZl2/AEmATU8ST5q3RQJ9zKPKDyVe0Z3lzV3b vG/lS0WYwxMRkQFlUHiScdhCQHdohS8jmPZm+1v7dF0VrYP5mQ0RADxiCmvhwb8uLMQb CxgCuOi/lTrYseWBWRM7A0+6gYjVLoKNNISfr8JiT1nuakAQSiVF5WRYRAvLQnog5P95 cWgl1fA5hV4UV01ELrwsM9Co7cGbsWqs9U4uKm4eT7IxbwWOAkuI2x6oW4NcI885BtmS Ky4A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=pGIPypqT2PiUODlArqmI2NTe3ZsH7Y81qX+Z5Er/VLk=; b=JxNbnjhk/9FRKDaFNpyjmBAeiZ0ETU51yKDjgTuduD/mrL8kEpQAOKXSDbo9+uvcTt 91fteNlaDg4LheW0NgViWAFEGBwL51wynkE/ZZ5yEam/WGeThwQyVZQc6ZyZ8pQA1C/E ejLvpTOfjSCsHuJ4I1owXdurZ5P3d3X7S7suORyLs9WDEodqadsvelMGE5AGzOV+AaPd JGXsy5hYSJqISVxzczkzm5uynu6aV13DN2I84rDjYVzcuAHMQ6TJdguof5AFkh4zmCRl n3I2PEQHmpf8UCEe09gOe4gQZMw4tdm0K04zx/BtwwPdmtxLa/EUMDE/U5S49yBj20xd poMg== X-Gm-Message-State: AJcUukeoXsMhgX/TAT30L0QXBXCURWBHqkLM607CR7zCjnfIZYLjxq6T eaJQAIClYsXzlj48xxUcRY216gnOHDForHXJlFmOFkkP15EtDVZgABkvDB8i+NiaS9At0MaZqg2 r/Hb7F0iKBhp82AioKdJMTFiiwEY7 X-Received: by 2002:a5d:8ac6:: with SMTP id e6mr759405iot.235.1545376065004; Thu, 20 Dec 2018 23:07:45 -0800 (PST) X-Received: by 2002:a5d:8ac6:: with SMTP id e6mr759400iot.235.1545376064681; Thu, 20 Dec 2018 23:07:44 -0800 (PST) Received: from localhost.localdomain (host-173-230-104-23.mnmigsc.mn.minneapolis.us.clients.pavlovmedia.net. [173.230.104.23]) by smtp.gmail.com with ESMTPSA id z133sm5820625itb.36.2018.12.20.23.07.43 (version=TLS1_2 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Thu, 20 Dec 2018 23:07:43 -0800 (PST) From: Kangjie Lu To: kjlu@umn.edu Cc: pakki001@umn.edu, Mauro Carvalho Chehab , Hans Verkuil , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH] media: mt312: fix a missing check of mt312 reset Date: Fri, 21 Dec 2018 01:07:20 -0600 Message-Id: <20181221070722.60234-1-kjlu@umn.edu> X-Mailer: git-send-email 2.17.2 (Apple Git-113) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org mt312_reset() may fail. Although it is called in the end of mt312_set_frontend(), we better check its status and return its error code upstream instead of 0. Signed-off-by: Kangjie Lu --- drivers/media/dvb-frontends/mt312.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/drivers/media/dvb-frontends/mt312.c b/drivers/media/dvb-frontends/mt312.c index 03e74a729168..bfbb879469f2 100644 --- a/drivers/media/dvb-frontends/mt312.c +++ b/drivers/media/dvb-frontends/mt312.c @@ -645,7 +645,9 @@ static int mt312_set_frontend(struct dvb_frontend *fe) if (ret < 0) return ret; - mt312_reset(state, 0); + ret = mt312_reset(state, 0); + if (ret < 0) + return ret; return 0; } -- 2.17.2 (Apple Git-113)