Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 20 Dec 2018 16:49:54 -0800 (PST)
Message-Id: <20181220.164954.1492087150966785483.davem@davemloft.net>
To:     semen.protsenko@linaro.org
Cc:     netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
        g.nault@alphalink.fr
Subject: Re: [PATCH v2] ppp: Move PFC decompression to PPP generic layer
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20181220182920.4208-1-semen.protsenko@linaro.org>
References: <20181220182920.4208-1-semen.protsenko@linaro.org>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Sam Protsenko <semen.protsenko@linaro.org>
Date: Thu, 20 Dec 2018 20:29:20 +0200

> Extract "Protocol" field decompression code from transport protocols to
> PPP generic layer, where it actually belongs. As a consequence, this
> patch fixes incorrect place of PFC decompression in L2TP driver (when
> it's not PPPOX_BOUND) and also enables this decompression for other
> protocols, like PPPoE.
> 
> Protocol field decompression also happens in PPP Multilink Protocol
> code and in PPP compression protocols implementations (bsd, deflate,
> mppe). It looks like there is no easy way to get rid of that, so it was
> decided to leave it as is, but provide those cases with appropriate
> comments instead.
> 
> Signed-off-by: Sam Protsenko <semen.protsenko@linaro.org>
> ---
> Changes in v2:
>   - Fix the order of checking skb data room and proto decompression
>   - Remove "inline" keyword from ppp_decompress_proto()
>   - Don't split line before function name
>   - Prefix ppp_decompress_proto() function with "__"
>   - Add ppp_decompress_proto() function with skb data room checks
>   - Add description for introduced functions
>   - Fix comments (as per review on mailing list)

Applied with Guillaume's suggested adjustments made.

Thank you.