Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 20 Dec 2018 18:57:22 -0800
From:   Stephen Hemminger <stephen@networkplumber.org>
To:     Paolo Abeni <pabeni@redhat.com>
Cc:     netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
        Eric Dumazet <eric.dumazet@gmail.com>,
        Paul Turner <pjt@google.com>, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v2 3/4] net: use indirect call wrappers at GRO
 transport layer
Message-ID: <20181220185722.1bc7540d@xeon-e3>
In-Reply-To: <fa7128969d8739cca9018c9577120fed8f44433a.1544032300.git.pabeni@redhat.com>
References: <cover.1544032300.git.pabeni@redhat.com>
        <fa7128969d8739cca9018c9577120fed8f44433a.1544032300.git.pabeni@redhat.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Wed,  5 Dec 2018 19:13:41 +0100
Paolo Abeni <pabeni@redhat.com> wrote:

> This avoids an indirect call in the receive path for TCP and UDP
> packets. TCP takes precedence on UDP, so that we have a single
> additional conditional in the common case.
>=20
> v1 -> v2:
>  - adapted to INDIRECT_CALL_ changes
>=20
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>

This introduces a bunch of new warnings when kernel is built with W=3D1.
Please add the necessary prototypes in header files.

Putting prototypes in C file for global function is not the right way to fix
this.

net/ipv4/tcp_offload.c:310:17: warning: no previous prototype for =E2=80=98=
tcp4_gro_receive=E2=80=99 [-Wmissing-prototypes]
 struct sk_buff *tcp4_gro_receive(struct list_head *head, struct sk_buff *s=
kb)
                 ^~~~~~~~~~~~~~~~
net/ipv4/tcp_offload.c:323:29: warning: no previous prototype for =E2=80=98=
tcp4_gro_complete=E2=80=99 [-Wmissing-prototypes]
 INDIRECT_CALLABLE_SCOPE int tcp4_gro_complete(struct sk_buff *skb, int tho=
ff)
                             ^~~~~~~~~~~~~~~~~
  CC      net/ipv4/datagram.o
  CC      net/ipv4/udp_offload.o
net/ipv4/udp_offload.c:459:17: warning: no previous prototype for =E2=80=98=
udp4_gro_receive=E2=80=99 [-Wmissing-prototypes]
 struct sk_buff *udp4_gro_receive(struct list_head *head, struct sk_buff *s=
kb)
                 ^~~~~~~~~~~~~~~~
net/ipv4/udp_offload.c:533:29: warning: no previous prototype for =E2=80=98=
udp4_gro_complete=E2=80=99 [-Wmissing-prototypes]
 INDIRECT_CALLABLE_SCOPE int udp4_gro_complete(struct sk_buff *skb, int nho=
ff)
                             ^~~~~~~~~~~~~~~~~
  CC      net/ipv4/arp.o
  CC      net/ipv6/ip6_offload.o
net/ipv6/ip6_offload.c:188:41: warning: no previous prototype for =E2=80=98=
ipv6_gro_receive=E2=80=99 [-Wmissing-prototypes]
 INDIRECT_CALLABLE_SCOPE struct sk_buff *ipv6_gro_receive(struct list_head =
*head,
                                         ^~~~~~~~~~~~~~~~
net/ipv6/ip6_offload.c:328:29: warning: no previous prototype for =E2=80=98=
ipv6_gro_complete=E2=80=99 [-Wmissing-prototypes]
 INDIRECT_CALLABLE_SCOPE int ipv6_gro_complete(struct sk_buff *skb, int nho=
ff)
                             ^~~~~~~~~~~~~~~~~
  CC      net/ipv6/tcpv6_offload.o
net/ipv6/tcpv6_offload.c:20:17: warning: no previous prototype for =E2=80=
=98tcp6_gro_receive=E2=80=99 [-Wmissing-prototypes]
 struct sk_buff *tcp6_gro_receive(struct list_head *head, struct sk_buff *s=
kb)
                 ^~~~~~~~~~~~~~~~
net/ipv6/tcpv6_offload.c:33:29: warning: no previous prototype for =E2=80=
=98tcp6_gro_complete=E2=80=99 [-Wmissing-prototypes]
 INDIRECT_CALLABLE_SCOPE int tcp6_gro_complete(struct sk_buff *skb, int tho=
ff)
                             ^~~~~~~~~~~~~~~~~
  CC      net/ipv6/exthdrs_offload.o