Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH 01/10] drm/virtio: log error responses
To:     Gerd Hoffmann <kraxel@redhat.com>, dri-devel@lists.freedesktop.org,
        David Airlie <airlied@redhat.com>
Cc:     David Airlie <airlied@linux.ie>,
        open list <linux-kernel@vger.kernel.org>,
        "open list:VIRTIO GPU DRIVER" 
        <virtualization@lists.linux-foundation.org>
References: <20181219122708.4586-1-kraxel@redhat.com>
 <20181219122708.4586-2-kraxel@redhat.com>
From:   Oleksandr Andrushchenko <andr2000@gmail.com>
Message-ID: <7af5ce00-d751-5c21-51f9-fdea793fd57b@gmail.com>
Date:   Fri, 21 Dec 2018 11:59:53 +0200
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.2.1
MIME-Version: 1.0
In-Reply-To: <20181219122708.4586-2-kraxel@redhat.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 7bit
Content-Language: en-US
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On 12/19/18 2:26 PM, Gerd Hoffmann wrote:
> If we got an error response code from the host, print it to the log.
>
> Signed-off-by: Gerd Hoffmann <kraxel@redhat.com>
Reviewed-by: Oleksandr Andrushchenko <oleksandr_andrushchenko@epam.com>
> ---
>   drivers/gpu/drm/virtio/virtgpu_vq.c | 12 ++++++++++--
>   1 file changed, 10 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/gpu/drm/virtio/virtgpu_vq.c b/drivers/gpu/drm/virtio/virtgpu_vq.c
> index e27c4aedb8..6bc2008b0d 100644
> --- a/drivers/gpu/drm/virtio/virtgpu_vq.c
> +++ b/drivers/gpu/drm/virtio/virtgpu_vq.c
> @@ -192,8 +192,16 @@ void virtio_gpu_dequeue_ctrl_func(struct work_struct *work)
>   
>   	list_for_each_entry_safe(entry, tmp, &reclaim_list, list) {
>   		resp = (struct virtio_gpu_ctrl_hdr *)entry->resp_buf;
> -		if (resp->type != cpu_to_le32(VIRTIO_GPU_RESP_OK_NODATA))
> -			DRM_DEBUG("response 0x%x\n", le32_to_cpu(resp->type));
> +		if (resp->type != cpu_to_le32(VIRTIO_GPU_RESP_OK_NODATA)) {
> +			if (resp->type >= cpu_to_le32(VIRTIO_GPU_RESP_ERR_UNSPEC)) {
> +				struct virtio_gpu_ctrl_hdr *cmd;
> +				cmd = (struct virtio_gpu_ctrl_hdr *)entry->buf;
> +				DRM_ERROR("response 0x%x (command 0x%x)\n",
> +					  le32_to_cpu(resp->type),
> +					  le32_to_cpu(cmd->type));
> +			} else
> +				DRM_DEBUG("response 0x%x\n", le32_to_cpu(resp->type));
> +		}
>   		if (resp->flags & cpu_to_le32(VIRTIO_GPU_FLAG_FENCE)) {
>   			u64 f = le64_to_cpu(resp->fence_id);
>