Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1036287imu; Fri, 21 Dec 2018 11:25:22 -0800 (PST) X-Google-Smtp-Source: ALg8bN7t/BYXBWf/Rde9SZOgIqwcA6XyDxnT7WhW26YSWxblKY/PwTkUBA9xFgvFboz8zYEUirUa X-Received: by 2002:a17:902:bf03:: with SMTP id bi3mr3768950plb.83.1545420322379; Fri, 21 Dec 2018 11:25:22 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545420322; cv=none; d=google.com; s=arc-20160816; b=GKfQ9eaECbrqOrd8pqhQiqFasg6wfp0wOGTe4ydnzRov9pPkySmetbvSy2YcKx3lVj vZYcpRskL+aK89pfPj6nqxOS13gGX6sqNTQJ1kZEX11eJiBEE7Ah9pFaLn7N0aBTob0Y j2w2uY7tUTdbMO1QjWVRaikigBxziYOt/YGeJ/5dZWkOOZd7nO8I8OloZZw6V+Clf58X QB6n48Wbvpn+pIsu8Q+8OQlCiXGj15nqbdWT4ENScSXYeAhqYFS2CrVsE71CAXJtadGx ptnLNOPS2324gC4ppBIzc+WSz191aa7Kru/RCj81Cfq2I3GEl675oqE1gO9c9xdRtGgn oFMQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-transfer-encoding:content-disposition:mime-version :references:message-id:subject:cc:to:from:date; bh=aToelK8wSS3RqmhZCYlSpXHttstbR2UIZ72kGGArY+I=; b=B6dyzg8Kv0Ejsp1FWY3ctNig+ohJvLWv9iAVWzTrPFh+OygMBO4eY+phw+kRkw0p2M Zj5OHX620qI5HcCp25JYi9OBegiF83ALyRAy/83PqdTJUV+J29xgjjeCs7gStL/CjEWN Xx7O4eyoCH4TSGfdAqVqNZy+bn3rO3jbzJ2FGnJjMaqbnma64JTbMLAq05kfw2ColNBg pMwZGTmU5ORn6CwjU3ZjPuv8phmiiNEVf6T+PlP6H1a7jaLS8mcdLzol8nVBtNyOItSX z9BwSrzJZvtKDx+q7nQ6t9mWWOgK1RitZzgaHrcD+/fVsTdAR2XRTD2BgBrP6L6QfTn1 o6FA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o5si4585223pgs.497.2018.12.21.11.25.07; Fri, 21 Dec 2018 11:25:22 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389986AbeLUKrQ (ORCPT + 99 others); Fri, 21 Dec 2018 05:47:16 -0500 Received: from mx2.suse.de ([195.135.220.15]:51882 "EHLO mx1.suse.de" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1731433AbeLUKrP (ORCPT ); Fri, 21 Dec 2018 05:47:15 -0500 X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay1.suse.de (unknown [195.135.220.254]) by mx1.suse.de (Postfix) with ESMTP id B3BA5AFA4; Fri, 21 Dec 2018 10:47:13 +0000 (UTC) Date: Fri, 21 Dec 2018 11:47:05 +0100 From: Borislav Petkov To: WANG Chao Cc: linux-kernel@vger.kernel.org, stable@vger.kernel.org, Peter Zijlstra , Zhenzhong Duan , Thomas Gleixner , David Woodhouse , Daniel Borkmann , "H . Peter Anvin" , Konrad Rzeszutek Wilk , Andy Lutomirski , Masahiro Yamada , Michal Marek , srinivas.eeda@oracle.com Subject: Re: [PATCH] treewide: replace RETPOLINE with CONFIG_RETPOLINE Message-ID: <20181221104705.GA4750@zn.tnic> References: <20181210163725.95977-1-chao.wang@ucloud.cn> <20181221093347.GA88654@WANG-Chaos-MacBook-Pro.local> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20181221093347.GA88654@WANG-Chaos-MacBook-Pro.local> User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 21, 2018 at 05:33:47PM +0800, WANG Chao wrote: > On 12/11/18 at 12:37P, WANG Chao wrote: > > Since commit 4cd24de3a098 ("x86/retpoline: Make CONFIG_RETPOLINE depend > > on compiler support"), RETPOLINE has been replaced by CONFIG_RETPOLINE. > > > > Fixes: 4cd24de3a098 ("x86/retpoline: Make CONFIG_RETPOLINE depend on compiler support") > > Signed-off-by: WANG Chao > > ping ... This one somehow slipped through the cracks... :-\ Ok, let's see: this could be relevant for the case when a module built with a compiler which doesn't support retpolines, gets loaded on a system which is built with retpolines. Which is pretty seldom as the majority of setups out there should have a retpoline-enabled compiler. And should not allow loading external modules anyway, but that's a different story. So, this close to the merge window, I'm inclined to delay this one after it and have it take the x86/urgent fixes path. Unless someone screams and says that patch breaks his system. I haven't seen any reports about it so far so... Thx. -- Regards/Gruss, Boris. SUSE Linux GmbH, GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)