Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp1211399imu;
        Fri, 21 Dec 2018 14:54:57 -0800 (PST)
X-Google-Smtp-Source: ALg8bN7ZpOUuADafU50+WlszmEM9o5OmZTHijWlfnaPxm6N/Hlw3kYZ/zUao1Hivj2+nuQsFQyzl
X-Received: by 2002:a17:902:f64:: with SMTP id 91mr4383390ply.132.1545432897546;
        Fri, 21 Dec 2018 14:54:57 -0800 (PST)
ARC-Seal: i=1; a=rsa-sha256; t=1545432897; cv=none;
        d=google.com; s=arc-20160816;
        b=vZpBIUoVLa5iNBnrzMP7l3YCX/N81G3oDIHgEx5L8zAVai0sjNoklcDGXaZOkVS1JL
         ErndolUTrn45WGDvtsGDX+A2JBWhA5k6HorPlY+P4TOIImphF4mLIEUiH5SZ8HiIYWPn
         7EwD1oSHtTitC/36V32WKVr4rPrbDEMPyZzoqvIzww1DTJwVLVlILvuvt+tXgWJUtje8
         iylXCnZ3IlvVddcd5GY0dmcMlWFkU9knEZjLWijSOlAbVM49IZrcmpu0XM1XssiP+kdU
         FlQ3qkgY7/6eCc5v/qzYKJvaaIttOXgSI4vQD3xUSFHuX3BUwUYDg9hsjv9kYgJF/gsD
         jieQ==
ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816;
        h=list-id:precedence:sender:user-agent:in-reply-to
         :content-disposition:mime-version:references:message-id:subject:cc
         :to:from:date:dkim-signature;
        bh=ZnXtK86vehQg5v88LjMKiev44fjihYkPrPg5wUFELQk=;
        b=rLs01SQcmfWhPwBcJ4H6R52x5O/3DB6qmGWMqJur35eJCItl+acQdmn45Sr+wlmEhe
         +1+lqOqlx2bXnDqYAfZP5s1cL20UPg/YXmeP4UlVSHFjha9OY2+xQ9U4L5H5Q9txqh78
         /s/yL/gmQ6MZC85HECStcf12K1SG6e+JA1AgD7TbuDvthN9lqSlblEDCkXGXy8MCv0Fs
         /y6TucLhH1eCYCYSnh2wpbIsspZJbDFZwp8PHHBf1rJTMjNNhCcz92WXUoY34mV9MC2l
         BZVwZz4mB6BXtJDKd8oQuspoOwzl+sS+d+YqiMG8Y4UM6JmKz656tUx+j1LqpfSbJ91m
         DAJw==
ARC-Authentication-Results: i=1; mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=N+Z02Nk9;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67])
        by mx.google.com with ESMTP id o32si22235926pld.407.2018.12.21.14.54.41;
        Fri, 21 Dec 2018 14:54:57 -0800 (PST)
Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Authentication-Results: mx.google.com;
       dkim=fail header.i=@infradead.org header.s=bombadil.20170209 header.b=N+Z02Nk9;
       spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S2403990AbeLUOsm (ORCPT <rfc822;mahoosoft4you@gmail.com>
        + 99 others); Fri, 21 Dec 2018 09:48:42 -0500
Received: from bombadil.infradead.org ([198.137.202.133]:45874 "EHLO
        bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S2403893AbeLUOsm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Fri, 21 Dec 2018 09:48:42 -0500
DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed;
        d=infradead.org; s=bombadil.20170209; h=In-Reply-To:Content-Type:MIME-Version
        :References:Message-ID:Subject:Cc:To:From:Date:Sender:Reply-To:
        Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date:
        Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:
        List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive;
         bh=ZnXtK86vehQg5v88LjMKiev44fjihYkPrPg5wUFELQk=; b=N+Z02Nk9E6nwnrFxsiwUz185R
        aT/UmP0VcXS4JJwQQe7RsR47GIiUGHLvnYYcpRd4UNbUAdrJcusc0hziEMWXwvwZrAvj5K4HZYcQz
        xeuR03Bl07NDfWmO/VJPmcCDjquaqTWKYitSMofB1klvUV3qlSCxJck+uQ3aSxuRZzBGIeQlAiLWn
        4FNcYCFmAKdzt54R1hMXLmWTcvmOnbjrcoRdi1JLwhPfABYRqDXOuWtOAv/3ivNhONNqPqrac3suf
        ZmVKaRg/gwWpEVntf9MPHfVHYlNwpGBke2pwS4NV8Es3163YFiQ3d3M4jFQPXquNXbJvWoDT1Ey4j
        GX8iIv17Q==;
Received: from willy by bombadil.infradead.org with local (Exim 4.90_1 #2 (Red Hat Linux))
        id 1gaM6S-0003h1-QI; Fri, 21 Dec 2018 14:48:40 +0000
Date:   Fri, 21 Dec 2018 06:48:40 -0800
From:   Matthew Wilcox <willy@infradead.org>
To:     Nikolay Borisov <nborisov@suse.com>
Cc:     linux-mm@kvack.org, akpm@linux-foundation.org,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] mm: Refactor readahead defines in mm.h
Message-ID: <20181221144840.GB10600@bombadil.infradead.org>
References: <20181221144053.24318-1-nborisov@suse.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20181221144053.24318-1-nborisov@suse.com>
User-Agent: Mutt/1.9.2 (2017-12-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Fri, Dec 21, 2018 at 04:40:53PM +0200, Nikolay Borisov wrote:
> All users of VM_MAX_READAHEAD actually convert it to kbytes and then to
> pages. Define the macro explicitly as (SZ_128K / PAGE_SIZE). This
> simplifies the expression in every filesystem. Also rename the macro to
> VM_READAHEAD_PAGES to properly convey its meaning. Finally remove unused
> VM_MIN_READAHEAD
> 
> Signed-off-by: Nikolay Borisov <nborisov@suse.com>

Reviewed-by: Matthew Wilcox <willy@infradead.org>