Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <7478abbc4022a29414367cacdac1b89bff18c54c.camel@intel.com>
Subject: Re: [PATCH] net: 80003es2lan: fix a missing check of read failure
From:   Jeff Kirsher <jeffrey.t.kirsher@intel.com>
To:     Kangjie Lu <kjlu@umn.edu>
Cc:     pakki001@umn.edu, "David S. Miller" <davem@davemloft.net>,
        intel-wired-lan@lists.osuosl.org, netdev@vger.kernel.org,
        linux-kernel@vger.kernel.org
Date:   Fri, 21 Dec 2018 11:18:58 -0800
In-Reply-To: <20181220212359.564-1-kjlu@umn.edu>
References: <20181220212359.564-1-kjlu@umn.edu>
Content-Type: multipart/signed; micalg="pgp-sha512";
        protocol="application/pgp-signature"; boundary="=-+YbPRRiB0GEbaxIaBGso"
User-Agent: Evolution 3.30.3 (3.30.3-1.fc29) 
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk


--=-+YbPRRiB0GEbaxIaBGso
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: quoted-printable

On Thu, 2018-12-20 at 15:23 -0600, Kangjie Lu wrote:
> When e1000_read_kmrn_reg_80003es2lan() fails, "kum_reg_data" is
> uninitialized and may contain random value. However, it is further
> used in the following execution, which will lead to undefined
> behaviors.
> The fix checks the failure of e1000_read_kmrn_reg_80003es2lan() and
> returns with its error code if it fails.
>=20
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
>  drivers/net/ethernet/intel/e1000e/80003es2lan.c | 7 +++++--
>  1 file changed, 5 insertions(+), 2 deletions(-)

This is a good catch, although we do not want to exit out on failure.  I
have an alternative patch to resolve both issues, which I will submit later
today.  Just need to finish holiday shopping for my wife... :-)

--=-+YbPRRiB0GEbaxIaBGso
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: This is a digitally signed message part
Content-Transfer-Encoding: 7bit

-----BEGIN PGP SIGNATURE-----

iQIzBAABCgAdFiEEiTyZWz+nnTrOJ1LZ5W/vlVpL7c4FAlwdPKIACgkQ5W/vlVpL
7c7iog/7BxLiCagwOurMC2peeHxluDO2ehrVQmtZd0DX/c9hGjriznThvo/3xxa8
xgTu4J1te9bMSr7Gl8zt2dKlEIbwoBcdndDSnjVR7t8utuqw4BDyD3sCwXXcn5EU
vS0G73d5PAAJEhpXbzFD9f4Ldbd8hk18aq9K9KCuPLO5RkTCD6S39lIQg1B/+76F
AegW24mPISmz7Qh1VV0wjJD+vpP1YQ6DxoUWs6EIiRi0Pln25Fbg3FBKwp0wGoJA
Ep+qviTtJm4RqNQekcwLpH3S9wMOxsFSrxTW5HHLy3sRTzjDn1+qQMKw7T+rCZ2R
dS4exRbS3qzq/K9ouERiXRr0dosimuIw0mEbsS8n598HjHkqxw79UDZoFK3xKpiW
qRAb8241paF4/3YibxHfDoa7Fzao19ysZH4EJbxZs2eG6cfKO/+qVvQu6vCZHT8A
h7IBD2zwJJwVxqGmCyVCxI1ODxhQnPg8Qog4WN3xmTfwqBueXGr1mPnBKYAMVCT1
QmWFxEM91TBi9s6R7j6qDo2zR1c+ctK1lIQoIoJSkL35XSS6H0txQrQKCbP/fTdX
17dLttnCQo1ErEFXVDdZzJZGGHHdXnnbf5KtcWHn9Pzo12r3NDWeCYIj9rlSV3nH
kBlRlYC195ESeTa1JMEdfdgSfPJGkxBBWJB55DBj4FcGka2/wKk=
=/GqL
-----END PGP SIGNATURE-----

--=-+YbPRRiB0GEbaxIaBGso--