Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181221193244.3a6ed685@canb.auug.org.au> <8ae0ad4e-0c5c-a3dc-51b4-1616f459e45b@infradead.org>
 <CAPcyv4ic3Sf+KGcL3tDUx73GVY_gXmf4WPCxfA63jT6bW3LAEA@mail.gmail.com>
In-Reply-To: <CAPcyv4ic3Sf+KGcL3tDUx73GVY_gXmf4WPCxfA63jT6bW3LAEA@mail.gmail.com>
From:   Dan Williams <dan.j.williams@intel.com>
Date:   Fri, 21 Dec 2018 13:01:05 -0800
Message-ID: <CAPcyv4gfC12nDdhfsT1CVuWdR_oB4Kr3FPf-shXeNgypJ+qBwQ@mail.gmail.com>
Subject: Re: linux-next: Tree for Dec 21 (nvdimm/security.o)
To:     Randy Dunlap <rdunlap@infradead.org>
Cc:     Stephen Rothwell <sfr@canb.auug.org.au>,
        Linux Next Mailing List <linux-next@vger.kernel.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        linux-nvdimm <linux-nvdimm@lists.01.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 21, 2018 at 10:51 AM Dan Williams <dan.j.williams@intel.com> wrote:
>
> On Fri, Dec 21, 2018 at 10:44 AM Randy Dunlap <rdunlap@infradead.org> wrote:
> >
> > On 12/21/18 12:32 AM, Stephen Rothwell wrote:
> > > Hi all,
> > >
> > > News: there will be no linux-next release until Jan 2.  Have a good break.
> > >
> > > Changes since 20181220:
> > >
> >
> > on x86_64:
> >
> > ld: drivers/nvdimm/security.o: in function `nvdimm_request_key':
> > security.c:(.text+0xbe): undefined reference to `key_type_encrypted'
> > ld: drivers/nvdimm/security.o: in function `nvdimm_lookup_user_key.isra.1':
> > security.c:(.text+0x1ea): undefined reference to `key_type_encrypted'
> >
> >
> > Full randconfig file is attached.
>
> Could you send me that randconfig, offlist is fine.
>
> It seems the "depends on ENCRYPTED_KEYS" I added is not sufficient.

Yup, I overlooked the LIBNVDIMM=y + ENCRYPTED_KEYS=m case.

I folded a fix into the problematic commit and added a Reported-by
credit. The option is now:

config NVDIMM_KEYS
        def_bool y
        depends on ENCRYPTED_KEYS
        depends on (LIBNVDIMM=ENCRYPTED_KEYS) || LIBNVDIMM=m