Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2529924imu; Sun, 23 Dec 2018 01:44:20 -0800 (PST) X-Google-Smtp-Source: ALg8bN4wVfjCiWX5gzGWsho/nutM7atQLhjKqeMI7gfI2Wl/AKNXMccciWbZ8GUNgY0YlxJ1Ct05 X-Received: by 2002:a63:3703:: with SMTP id e3mr8579749pga.348.1545558260324; Sun, 23 Dec 2018 01:44:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545558260; cv=none; d=google.com; s=arc-20160816; b=vjevMak7u5GRMJv1SUhyTnJVlM2793TfTFCpcmHA3MZkMlDWRroXyW2tGiHVRhQ/yZ kJgvDWu3Vd5BEpC00krfv47BL7HRH7FF6GhBr18tulSLrAcb8EUO67Lyoeh2E1cdvMNy T8xnDWvt9wdIp1nlASBer05FjuzB8bLTKfM5gm+vyzzaaH6Dsd1Mx0wtmsiv+cSgglrs wNSEFAwoQqNdEfMUJo3azu+vtixcyBsA2r0r/2Ls/w0HJ3laHMoxsxUkZ32JJ/y+AvWe JpiMKyRoyFJIPKPlEmEQ6TSOE/edf9oqlOhspQ1KeQdXGiWQdeZFS10OW1OJo0jh2FUm wn3w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:dkim-signature; bh=RWFx2MmP/okSvy1n/Y6kWzIkSGB2dAYp7bFmgMiY1Pw=; b=bOb7EmLz3nfTtAEXxpPdmYWSPo/TOF8oB5KsIwWgrhM9zvdQ2n/RuXw0PFlmpAmF4i /WYcpPK9Rekc+HN/WsHNitXCPPjxFrssiQfC2jkx+tvOI+ge0WFqKD+aUfEoN12gJ2Xl yfdEBbcQlPA/Y18QZ3EDakcx0orz+/z5Rt0DqdireVU2BaOFgyrLAz/VmxduWdHGmRVM PPQFHa8FggLCZbNjCKpCsGVxbze8o+4flbaA5og80sjv1nZjhQMsiKgy6+Ly9LDbBfEA HOJsZQByVNdiNJe/FVx5leBylGE5G/8kd39MhfdcJuUbfuhAu5mIC/xVvgKxYFrDhRji Q2dw== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HgEeS0dM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 3si26131567plo.102.2018.12.23.01.44.04; Sun, 23 Dec 2018 01:44:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b=HgEeS0dM; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404903AbeLVAjm (ORCPT + 99 others); Fri, 21 Dec 2018 19:39:42 -0500 Received: from mail-wr1-f65.google.com ([209.85.221.65]:46150 "EHLO mail-wr1-f65.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729898AbeLVAjl (ORCPT ); Fri, 21 Dec 2018 19:39:41 -0500 Received: by mail-wr1-f65.google.com with SMTP id l9so6884344wrt.13; Fri, 21 Dec 2018 16:39:40 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=RWFx2MmP/okSvy1n/Y6kWzIkSGB2dAYp7bFmgMiY1Pw=; b=HgEeS0dMGz395pT2i0wBx7Q4W23AZ6Qb7dPRwg0qmHSf4oACPbr8a7UbQW8KdaKEd8 xZ9Tsgse76ZopwUl1NRVvYB48Q2QDGY8PY+YiZo1qp3BhJNb7qgunrkIP+7rzIB7f12k vVcJH5uUpq8etwmOQf27ISMZTASUPuVYOJ6CdrAzGwvyf0ZkyvtQ8e2aUaIG6g9xP/4W AjN7btsM26Zy3xE7cQ2LIcTlDub+eqV9jcbzX+CObs1YJ0HQVUDcu6bLDaojKPcwnJw3 JBU0msr5u+VxZOHeyGNHqGI1tZaOZtRIyZfn88SeiCkgcb2lZ4faP9icZlzqhzv8/lam h8eg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=RWFx2MmP/okSvy1n/Y6kWzIkSGB2dAYp7bFmgMiY1Pw=; b=eSc3gI+4N3SkFDN0gRj15jiDYSdFQLP7RgOkyoH1kYLxaQtWlFYrnd6BC7NmV9ojXq WXDWY7LGFjl1c4RvcxITHTV20U1+XK/0r1ck3vw59v6eIKI9IUJ+jn9oHG8LwSAMXuvK oxPHbkk7kLeb9uxXBbW0oNpU7jd5xYx6BfN78LBwaS7YuTcjlQy3ffTlnAt5BfyPM4U4 k6YvaVQtA8lKhDkiQmnE7Ol3crFu4ddYqdNJWWvJlkh2qLJNgExxWgezkJ0GzetRQzky gQPAdviJ38AL+YwBwrYsVGIqv27aTyQE3g0IdTtEAjOdIJGUSZ7wC0JlCNf09d+qW/LZ 01nw== X-Gm-Message-State: AJcUukdhwt9Q6J3BAAQ2+viXPmcXTX2uOO3AfxvqouWlaZXQN5RuV/Xo eMGqfaiY55Ntu1q81FNilOuDlLN9DLDJjtrtZPA= X-Received: by 2002:a5d:4b01:: with SMTP id v1mr4330590wrq.5.1545439179793; Fri, 21 Dec 2018 16:39:39 -0800 (PST) MIME-Version: 1.0 References: <20181221072716.29017-1-andrew.smirnov@gmail.com> <20181221072716.29017-10-andrew.smirnov@gmail.com> <1545418520.22930.82.camel@impinj.com> In-Reply-To: <1545418520.22930.82.camel@impinj.com> From: Andrey Smirnov Date: Fri, 21 Dec 2018 16:39:28 -0800 Message-ID: Subject: Re: [PATCH 09/21] PCI: imx6: Drop imx6_pcie_link_up() To: Trent Piepho Cc: "linux-pci@vger.kernel.org" , "hongxing.zhu@nxp.com" , "aisheng.dong@nxp.com" , "cphealy@gmail.com" , "linux-imx@nxp.com" , "linux-kernel@vger.kernel.org" , "lorenzo.pieralisi@arm.com" , "fabio.estevam@nxp.com" , "linux-arm-kernel@lists.infradead.org" , "bhelgaas@google.com" , "l.stach@pengutronix.de" , "leonard.crestez@nxp.com" Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 21, 2018 at 10:55 AM Trent Piepho wrote: > > On Thu, 2018-12-20 at 23:27 -0800, Andrey Smirnov wrote: > > Until commit 4d107d3b5a68 ("PCI: imx6: Move link up check into > > imx6_pcie_wait_for_link()") the driver relied on both LINK_UP and > > LINK_IN_TRAINING to determine if PCIE link was up. > > I've already got a patch in that fixed this issue. Queued for 4.19 and > 4.14 stable. > > The problem was created by 886bc5ceb5cc in one branch and by > 4d107d3b5a68 on another branch, that when merged in 562df5c8521e, the > merge kept some pieces from each commit and dropped other pieces, which > resulted in this check getting dropped. OK, cool, this patch can be dropped then. Thanks, Andrey Smirnov