Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
MIME-Version: 1.0
References: <20181206040540.84632-1-cychiang@chromium.org> <20181214122156.GT4497@dell>
 <20181214122245.GU4497@dell> <CAFv8Nw+RbzKrjE1tsgxdRntXKWp9XVq8hbP7MZ3mZ=a2rMyG2Q@mail.gmail.com>
 <20181218084307.GH4497@dell>
In-Reply-To: <20181218084307.GH4497@dell>
From:   Guenter Roeck <groeck@google.com>
Date:   Sat, 22 Dec 2018 11:47:30 -0800
Message-ID: <CABXOdTc36qu=oSz3XS07SqwoQM6Dh_CU0o89JariXMe+EBhyBw@mail.gmail.com>
Subject: Re: [PATCH v2] mfd: cros_ec: Add commands to control codec
To:     Lee Jones <lee.jones@linaro.org>
Cc:     Cheng-yi Chiang <cychiang@chromium.org>,
        Benson Leung <bleung@chromium.org>,
        Guenter Roeck <groeck@chromium.org>,
        linux-kernel <linux-kernel@vger.kernel.org>,
        Mark Brown <broonie@kernel.org>, alsa-devel@alsa-project.org,
        Dylan Reid <dgreid@chromium.org>, tzungbi@chromium.org,
        Rohit kumar <rohitkr@codeaurora.org>,
        Scott <scollyer@chromium.org>
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Tue, Dec 18, 2018 at 12:52 AM Lee Jones <lee.jones@linaro.org> wrote:
>
> On Tue, 18 Dec 2018, Cheng-yi Chiang wrote:
>
> > +Benson, Guenter, Scott
> >
> > On Fri, Dec 14, 2018 at 8:22 PM Lee Jones <lee.jones@linaro.org> wrote:
> > >
> > > On Fri, 14 Dec 2018, Lee Jones wrote:
> > >
> > > > On Thu, 06 Dec 2018, Cheng-Yi Chiang wrote:
> > > >
> > > > > Add EC host commands to control codec on EC.
> > > > >
> > > > > Signed-off-by: Cheng-Yi Chiang <cychiang@chromium.org>
> > > > > ---
> > > > >  V2 fixed the wrong ancestor issue so the patch can be applied cleanly on mfd tree.
> > > > >  Codec driver that uses these commands will be sent separately.
> > > > >  Thanks!
> > > > >
> > > > >  include/linux/mfd/cros_ec_commands.h | 94 ++++++++++++++++++++++++++++
> > > > >  1 file changed, 94 insertions(+)
> > > >
> > > > Would be good to have this reviewed by some more Chrome people.
> > >
> > > See this for reference:
> > >
> > >   https://lore.kernel.org/patchwork/patch/1024985/
> >
> > Hi Benson and Guenter,
> > Could you please review this patch ?
>
> You haven't sent them the patch.
>
> Please resubmit as a [RESEND] and add them as recipients.
>

I was asked separately from one of our engineers if it would be
acceptable to synchronize cros_ec_commands.h with the version from the
EC source. I think that might make more sense than a piece-by-piece
approach.

Thanks,
Guenter