Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2827369imu; Sun, 23 Dec 2018 08:40:34 -0800 (PST) X-Google-Smtp-Source: ALg8bN4RbZw+oKn2OQ6iHff1WjKEfpK1sxVwz3YXMuvygDFxxQZj+YnP76AtXlG2iD2oAWEdcYKM X-Received: by 2002:a63:4611:: with SMTP id t17mr9532746pga.119.1545583234341; Sun, 23 Dec 2018 08:40:34 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545583234; cv=none; d=google.com; s=arc-20160816; b=WUA0jINyxc/Az6uXfZK1Zt+8P/vNTjsmTppQMW1QZ7gu+KP9kVJbuqK7aiJ4dCDcn1 wuw2KQFfCCW3p/qGnej/cMua9w3SuQtqqGY/yHX6z0DvJP/EwszpcnSrnSMA1NHq4xo5 PVxfUtt0XO9rfCDfsjVOeEZ0Uw77S4qiVvONrcffPr+SrOoPYNBj42WXMM4Yo8I0EH0p 7ACTGgPb+/7KRK4ZK4unDuzQ705OgwpsHdXTYfLQtwaVLsbCbbgmWAmgqZcNWXs3P2/5 xELJAQijko4B/dhm5aLf3pe56VGXBFszmxv+XIkKdDq1WvyK5f43MgbVSWRBc7sVNi4F 8phA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=y94+NyhSVTblleMcsHZuuRPHaBEoo4ZLQnygXLzBr90=; b=sUjgnMgrG6FyXHR7mj0Eue0x8o7q1RYOcRNOXmjjqR5c8D+vM1LWRoj/xKCBQHsBtg U6jMrndIiSCUXDymuGn6tjnYRUZUnHg3GasYB1iH9YH67E4MkZFtyLAfwlZn2YprKX1r jdjNu7k3vkeMOpoot1ppUei7d85Qhz/6sZuLvp2gDt7BVmticSakFU2MHzQ+PhzKAhhb NlFwSLYnfQ+1zb9CREHce46vukpKwvBqfp17ol6/c/obIZpgrecp02PEwH3G0PhAMUGo kZ5Ojc7D1dAfMXNTcQNTFm9JApDYqjnm1f6CrFu1GsT825hK99p8EHjrt0b1wFmNHJLv rj7g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z19si27864137pfc.95.2018.12.23.08.40.19; Sun, 23 Dec 2018 08:40:34 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727225AbeLWJd5 (ORCPT + 99 others); Sun, 23 Dec 2018 04:33:57 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:44311 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727153AbeLWJd4 (ORCPT ); Sun, 23 Dec 2018 04:33:56 -0500 X-IronPort-AV: E=Sophos;i="5.56,386,1539640800"; d="scan'208";a="289991764" Received: from palace.lip6.fr ([132.227.105.202]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA256; 23 Dec 2018 10:33:52 +0100 From: Julia Lawall To: Saeed Mahameed Cc: kernel-janitors@vger.kernel.org, Leon Romanovsky , "David S. Miller" , netdev@vger.kernel.org, linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 02/20] net/mlx5e: drop useless LIST_HEAD Date: Sun, 23 Dec 2018 09:56:57 +0100 Message-Id: <1545555435-24576-3-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop LIST_HEAD where the variable it declares is never used. These became useless in 244cd96adb5f ("net_sched: remove list_head from tc_action") The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x; @@ - LIST_HEAD(x); ... when != x // Fixes: 244cd96adb5f ("net_sched: remove list_head from tc_action") Signed-off-by: Julia Lawall --- Successfully 0-day tested on 151 configurations. drivers/net/ethernet/mellanox/mlx5/core/en_tc.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c index 4d6c9757afad..cae6c6d48984 100644 --- a/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c +++ b/drivers/net/ethernet/mellanox/mlx5/core/en_tc.c @@ -2183,7 +2183,6 @@ static bool modify_header_match_supported(struct mlx5_flow_spec *spec, { const struct tc_action *a; bool modify_ip_header; - LIST_HEAD(actions); u8 htype, ip_proto; void *headers_v; u16 ethertype; @@ -2272,7 +2271,6 @@ static int parse_tc_nic_actions(struct mlx5e_priv *priv, struct tcf_exts *exts, { struct mlx5_nic_flow_attr *attr = flow->nic_attr; const struct tc_action *a; - LIST_HEAD(actions); u32 action = 0; int err, i; @@ -2511,7 +2509,6 @@ static int parse_tc_fdb_actions(struct mlx5e_priv *priv, struct tcf_exts *exts, struct mlx5e_rep_priv *rpriv = priv->ppriv; struct ip_tunnel_info *info = NULL; const struct tc_action *a; - LIST_HEAD(actions); bool encap = false; u32 action = 0; int err, i;