Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2828033imu; Sun, 23 Dec 2018 08:41:38 -0800 (PST) X-Google-Smtp-Source: ALg8bN68gtTZtioptueHrGNpXqqXDH5NrIAnahhGsczNm66EfuwLKmo77UQ5QROyLSoZ8RbzcOYf X-Received: by 2002:a17:902:70c6:: with SMTP id l6mr10418469plt.30.1545583298888; Sun, 23 Dec 2018 08:41:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545583298; cv=none; d=google.com; s=arc-20160816; b=Q75BaZVfiQCm+4OJ3Y7KIHQHlTG6ZFm3BBhMNnBeR4f44fke4eWmUuhAzQsf2Bxgcy agVLt3c8nSUqwX2315HMoj6Ux1Rbl9FbPk4axsBlOkulQNI3o/zHx9n86bkkA9oj89W0 tcPVOT9FONJS+8fwJ0fWOPmFkiBTIF5JniK+Ls07FDwevKgDTO+ZYtDcLuQr2ca2nSrb O7Y3q15n6iQFMF44rmFVCRhZBtedd7dCmAIqs6/ULUYtRBfg/3Wfa9eYf+6MfhZgDGhD XsrkEi6tAiP+OJ6UqMWXjldabMkuEkc0HhW77mVHCsy7L2r0+T1+wOH0huhvl8GkuEhP aBSg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=AgYSprNOUuBlPVu7PSQ6y2m817wbU1POjyMF3UspJ2M=; b=rNgWWfkS4ONWu23pUDt+8/7EIQ6QRLCH++PfTgANwiKzmQ4+DMFzadvlG4bCKvY175 upra5e11/CFzoSX7phu/zoF/YyawnVIcfWQyWakWJ4aGHxzVKwfuYzD4d6f9PJ110d6E aLu1wVxkiVKdd674kdRaY7Fx4j8L9ebuN8iJyJb7fkdUcT4Mln+/HS0P+36P5FTWcmAa d2L/PDdQfy/0Yt+e8Xf1ru8/avw/Re0/wjG1w9XWfrfHXTyd4lTsBx3v5CmfdCIlFoz/ G0NW5NIg8j23Aobbu1N7IjUW1fwHaPLX505pXUvlyje3zsX7wsE+GLYTeFyzZzchS+ZN d8EA== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id d189si27761346pfa.70.2018.12.23.08.41.24; Sun, 23 Dec 2018 08:41:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727683AbeLWJfo (ORCPT + 99 others); Sun, 23 Dec 2018 04:35:44 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:44311 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727153AbeLWJd7 (ORCPT ); Sun, 23 Dec 2018 04:33:59 -0500 X-IronPort-AV: E=Sophos;i="5.56,386,1539640800"; d="scan'208";a="289991769" Received: from palace.lip6.fr ([132.227.105.202]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA256; 23 Dec 2018 10:33:53 +0100 From: Julia Lawall To: Doug Ledford Cc: kernel-janitors@vger.kernel.org, Jason Gunthorpe , linux-rdma@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 06/20] IB/ipoib: drop useless LIST_HEAD Date: Sun, 23 Dec 2018 09:57:01 +0100 Message-Id: <1545555435-24576-7-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop LIST_HEAD where the variable it declares is never used. Commit 31c02e215700 ("IPoIB: Avoid using stale last_send counter when reaping AHs") removed the uses, but not the declaration. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x; @@ - LIST_HEAD(x); ... when != x // Fixes: 31c02e215700 ("IPoIB: Avoid using stale last_send counter when reaping AHs") Signed-off-by: Julia Lawall --- Successfully 0-day tested on 151 configurations. drivers/infiniband/ulp/ipoib/ipoib_ib.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/infiniband/ulp/ipoib/ipoib_ib.c b/drivers/infiniband/ulp/ipoib/ipoib_ib.c index 6d35570092d6..78fa777c87b1 100644 --- a/drivers/infiniband/ulp/ipoib/ipoib_ib.c +++ b/drivers/infiniband/ulp/ipoib/ipoib_ib.c @@ -669,7 +669,6 @@ static void __ipoib_reap_ah(struct net_device *dev) { struct ipoib_dev_priv *priv = ipoib_priv(dev); struct ipoib_ah *ah, *tah; - LIST_HEAD(remove_list); unsigned long flags; netif_tx_lock_bh(dev);