Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2828207imu; Sun, 23 Dec 2018 08:41:52 -0800 (PST) X-Google-Smtp-Source: ALg8bN5D0G7sgqX83bt3fqv4x4NSEkk8rgUi36BxluuQUdNAsNcWqWgNOjHD7eY163yl10K5HlZR X-Received: by 2002:a17:902:6b83:: with SMTP id p3mr10087035plk.118.1545583312828; Sun, 23 Dec 2018 08:41:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545583312; cv=none; d=google.com; s=arc-20160816; b=oCIIqBuCjqoETEEHTlPnPYwP8xFsyi7RHdfJWJCJy3qdtjU2MQtr2U29TOV1U5rItX Edvk67AZWx4FrVLTVYALtqDHlxoiCHNXYvoCRI9nzHU1icD8gfmHKcamZUTHzV0c34ce fx4bwBHUiDsVBuoEPxC3M9FcM1Zy/J1LG0ZhtTz6GbzHXNhQpSAskGeCeB5e55VPbg/o ozwD050U774oo+Rh40OlANm54aLdrV0D1ZdE0t4Vrc7CCR4ApybVBWrGO/BU3NSgKoDJ ZjuCKgER5cUV+R3BQ06pA78+rJLq09Kp8cv889M21K8hgYqx0eyIE8pV6azKAGkvkikh lj+w== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=u0V1JJHnICRbInY3xmZpPdmE4m/dUf34dCZBEOUORcs=; b=NJyxh846LeLYDQEHuqf57dGYJS6u1hds3sR3POc6clMRs8IfpOSKcMc6cBbLEy0ZHk o5UeZjVBduZd4feMnBCbSdAU4dFRo12sv/EbdJOptyikdiaYlxJTOSDNfrPz/7pt7YbR R91xJY3s/M0ozfqrwDVLYMpBRSMX4KwwGODVwOLwjUbnXRU8nx3i7yvkp1FZLAqOwJO2 ns24XaI+q9Q8u6eH57F3e8/++45q3vCC21JnFfd8oPqrBGgb+kkDVxaGf4DOuWOYoZlO vzUX4gF6FRgX5qSbKAuHpLIRLPNIQZ+3+1VtfMpMHuwilyocKnHLlw3lAIrnvgACk0RG HV5A== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 1si25223353plk.296.2018.12.23.08.41.37; Sun, 23 Dec 2018 08:41:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727355AbeLWJeD (ORCPT + 99 others); Sun, 23 Dec 2018 04:34:03 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:44319 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727260AbeLWJeA (ORCPT ); Sun, 23 Dec 2018 04:34:00 -0500 X-IronPort-AV: E=Sophos;i="5.56,386,1539640800"; d="scan'208";a="289991772" Received: from palace.lip6.fr ([132.227.105.202]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA256; 23 Dec 2018 10:33:53 +0100 From: Julia Lawall To: "Darrick J. Wong" Cc: kernel-janitors@vger.kernel.org, linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 08/20] xfs: xfs_buf: drop useless LIST_HEAD Date: Sun, 23 Dec 2018 09:57:03 +0100 Message-Id: <1545555435-24576-9-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop LIST_HEAD where the variable it declares has never been used. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x; @@ - LIST_HEAD(x); ... when != x // Fixes: 26f1fe858f274 ("xfs: reduce lock hold times in buffer writeback") Signed-off-by: Julia Lawall --- Successfully 0-day tested on 151 configurations. fs/xfs/xfs_buf.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/xfs/xfs_buf.c b/fs/xfs/xfs_buf.c index b21ea2ba768d..eedc5e0156ff 100644 --- a/fs/xfs/xfs_buf.c +++ b/fs/xfs/xfs_buf.c @@ -1992,7 +1992,6 @@ xfs_buf_delwri_submit_buffers( struct list_head *wait_list) { struct xfs_buf *bp, *n; - LIST_HEAD (submit_list); int pinned = 0; struct blk_plug plug;