Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2828522imu; Sun, 23 Dec 2018 08:42:20 -0800 (PST) X-Google-Smtp-Source: AFSGD/Vl3UrLPwuhyP8InJVKLBQJaARw1pKMr5xJFhJjrkkr7eHZeWm6RYq5NzytrniYpX0BcutH X-Received: by 2002:a62:670f:: with SMTP id b15mr10206119pfc.212.1545583340221; Sun, 23 Dec 2018 08:42:20 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545583340; cv=none; d=google.com; s=arc-20160816; b=ZQQVhfxqJogsmsEj9yh69ZKVb+6zSJ88j8lvf+JcmRQ8FyN7PdCMG2neNLD563ghyG dMdn8YjuNY2NQ9vR8SVvxTV/Po6Uz2OSvvs9InOdmiA5csz0RtBQR409ZY20QkQ+cZ2O ujNC016+wJuTvXRC1XafOUuiFIP2wGN1D6ylwOCLh4OGFiAujfTncZ5WotWbTeAUkhcL j1bQPzvDOCStHbjNG1omUb1KHwCS7ET4c7AaBuhT4AhTrqmbrRchoZIG9+eXDFb38xNP dieb/HyqrsIBAYG++k0aMc0v/TQZipJmoRwGzi67fH5yMVt1qBt76qVRolLQWdkY+MiO D5Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=qviqYfy2nARDkzvaCub00fvaeOUMmr0Xy4qQtsMy8Co=; b=XeGT05gsh6SGPqFQ/yvns6cYOQc4ick6oxG0GMcIUlpmKNlpwQ14G4pryW+/f7Axg4 ZQ3FaOiq0HWdJI12d5XOBLBCBs+f7OYdTSWaSBfS0QFKrnjDm7+1uVZr+0YctnOzq+zm kxukDYRR5n5kPvr3o7M0lsDrI6pbGat3ysS5TfVKgp5DL/ngx8V3XQ4tyqCCd22+4I39 LQOfAfwLZ/ykB74UVBNwXhgH0Fp15XCmbq0hJCeWTwKeQWlF//tQNezjhjGhw3lCqqbB ckDTHU5VkrgqzYOs0tmEJKuZa1NlXHTFf2l8n+s18BlCzavomDOgD6zWF3H0JDpALg2O lZnw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z22si25736870plo.202.2018.12.23.08.42.04; Sun, 23 Dec 2018 08:42:20 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727529AbeLWJeo (ORCPT + 99 others); Sun, 23 Dec 2018 04:34:44 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:44311 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727368AbeLWJeF (ORCPT ); Sun, 23 Dec 2018 04:34:05 -0500 X-IronPort-AV: E=Sophos;i="5.56,386,1539640800"; d="scan'208";a="289991783" Received: from palace.lip6.fr ([132.227.105.202]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA256; 23 Dec 2018 10:33:55 +0100 From: Julia Lawall To: Dan Williams Cc: kernel-janitors@vger.kernel.org, Vinod Koul , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 18/20] dmaengine: sa11x0: drop useless LIST_HEAD Date: Sun, 23 Dec 2018 09:57:13 +0100 Message-Id: <1545555435-24576-19-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop LIST_HEAD where the variable it declares has never been used. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x; @@ - LIST_HEAD(x); ... when != x // Fixes: 4a533218fccf ("dmaengine: sa11x0: Split device_control") Signed-off-by: Julia Lawall --- Successfully 0-day tested on 151 configurations. drivers/dma/sa11x0-dma.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/dma/sa11x0-dma.c b/drivers/dma/sa11x0-dma.c index 784d5f1a473b..3fae23768b47 100644 --- a/drivers/dma/sa11x0-dma.c +++ b/drivers/dma/sa11x0-dma.c @@ -705,7 +705,6 @@ static int sa11x0_dma_device_pause(struct dma_chan *chan) struct sa11x0_dma_chan *c = to_sa11x0_dma_chan(chan); struct sa11x0_dma_dev *d = to_sa11x0_dma(chan->device); struct sa11x0_dma_phy *p; - LIST_HEAD(head); unsigned long flags; dev_dbg(d->slave.dev, "vchan %p: pause\n", &c->vc); @@ -732,7 +731,6 @@ static int sa11x0_dma_device_resume(struct dma_chan *chan) struct sa11x0_dma_chan *c = to_sa11x0_dma_chan(chan); struct sa11x0_dma_dev *d = to_sa11x0_dma(chan->device); struct sa11x0_dma_phy *p; - LIST_HEAD(head); unsigned long flags; dev_dbg(d->slave.dev, "vchan %p: resume\n", &c->vc);