Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2828592imu; Sun, 23 Dec 2018 08:42:24 -0800 (PST) X-Google-Smtp-Source: AFSGD/WO2tUzAfvxnfXT0AygIQTwLwf9fx61MZesFlUTlhBw1o5b7M9Z41KeNnkhPWFWu2KFAS+g X-Received: by 2002:a62:cd44:: with SMTP id o65mr10191196pfg.222.1545583344726; Sun, 23 Dec 2018 08:42:24 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545583344; cv=none; d=google.com; s=arc-20160816; b=Hp9nmpnHDBkH+7JSNimKpdAosCy+fpwWXn8nMAyDMX8GyL1o9gOwK/eOvS9VOnGJ0f CaOIfGvPALu3mwyaqS65WwvnA8x9bGBwh0D1D8TsEkGzUKqQGKbUbVF+0GmGlen1/NwT mwt7UQU0CFfHQnC76PJ8QJ+fJi6JpTrnv7Vznvr8boutwp3Bo0W2z03dO6Uszdd5BEBR Yk6WZQ0u2On4oOmT/KYQdnMsXCF4V7DR3+BDfTG9pB6dz2JynuRQ0a4kVMfibV5i6kd9 lOknNzr8wKRQgdbso11CvAz6fvVK8MSouerXXa0c+la9JtdZMn/NTEi0akB+2UL+pTgY jtvg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=ljBMHOZsenxynnQmKr1XqcgxbT8LuSD4yFMHhZtHwCg=; b=SubPPgZVN4pZyFxpzUNWetcXHAjZ346iSd1zemhZxLs5oWLFAmtV471BOwcEQXHlW4 PZulmymqeeCgcyKTM6+jRbfE1rADLGPLUH7ukGndkcRJL015i8dNOSYxokEKnnDJ4PnV kezAnniraD+q2E0egZBeon6LH4WPmuyFQTB/jJkG6rX8QZIVYES+LMy0erzlCdVxTKZd 8s6VnuGpWWqTtoY8bmTC/0/rl+FECUs1cTxu9rskFDesuIgKAatd8XUvOrz4mYTiQFqQ cwJo1BpabKxmCi7xmBV+q+tCCKh89lpj83QrKOfImb8wheEH4DOImLQRkQDABw549Zqa lgVw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id g10si23127726plm.1.2018.12.23.08.42.09; Sun, 23 Dec 2018 08:42:24 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727572AbeLWJex (ORCPT + 99 others); Sun, 23 Dec 2018 04:34:53 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:44319 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727329AbeLWJeE (ORCPT ); Sun, 23 Dec 2018 04:34:04 -0500 X-IronPort-AV: E=Sophos;i="5.56,386,1539640800"; d="scan'208";a="289991779" Received: from palace.lip6.fr ([132.227.105.202]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA256; 23 Dec 2018 10:33:54 +0100 From: Julia Lawall To: Patrice Chotard Cc: kernel-janitors@vger.kernel.org, Dan Williams , Vinod Koul , linux-arm-kernel@lists.infradead.org, dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 14/20] dmaengine: st_fdma: drop useless LIST_HEAD Date: Sun, 23 Dec 2018 09:57:09 +0100 Message-Id: <1545555435-24576-15-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop LIST_HEAD where the variable it declares is never used. The declarations were introduced with the file, but the declared variables were not used. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x; @@ - LIST_HEAD(x); ... when != x // Fixes: 6b4cd727eaf1 ("dmaengine: st_fdma: Add STMicroelectronics FDMA engine driver support") Signed-off-by: Julia Lawall --- Successfully 0-day tested on 151 configurations. drivers/dma/st_fdma.c | 3 --- 1 file changed, 3 deletions(-) diff --git a/drivers/dma/st_fdma.c b/drivers/dma/st_fdma.c index 07c20aa2e955..954f7cf62bb1 100644 --- a/drivers/dma/st_fdma.c +++ b/drivers/dma/st_fdma.c @@ -294,8 +294,6 @@ static void st_fdma_free_chan_res(struct dma_chan *chan) struct rproc *rproc = fchan->fdev->slim_rproc->rproc; unsigned long flags; - LIST_HEAD(head); - dev_dbg(fchan->fdev->dev, "%s: freeing chan:%d\n", __func__, fchan->vchan.chan.chan_id); @@ -626,7 +624,6 @@ static void st_fdma_issue_pending(struct dma_chan *chan) static int st_fdma_pause(struct dma_chan *chan) { unsigned long flags; - LIST_HEAD(head); struct st_fdma_chan *fchan = to_st_fdma_chan(chan); int ch_id = fchan->vchan.chan.chan_id; unsigned long cmd = FDMA_CMD_PAUSE(ch_id);