Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2828652imu; Sun, 23 Dec 2018 08:42:29 -0800 (PST) X-Google-Smtp-Source: ALg8bN5OF0pZUL6JSm/HF4B5YWiMs6Eo7vX6Ik9tgY9kSG1sFwBzAlddTIsth3IXSnpuP4M6JLo6 X-Received: by 2002:a63:c0f:: with SMTP id b15mr9770266pgl.314.1545583349119; Sun, 23 Dec 2018 08:42:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545583349; cv=none; d=google.com; s=arc-20160816; b=UM4hoQZlccyhiz0gyE0OoU2oZLgwPi5RHSZ4GD0QkhZnwm3+mUloKflVPPJT6t8Ki9 Y9xfb3E24mMQ43olKIzVAiSBoHCb9jj+v4Efb/SHZz6DJri1frZpLueWG8V95qyjYema fL3U+MZURylGzdHysxLt0SiWnQEi1hJ2vyx3wemVP6tSRUZTaxFVuzK3rmu/RU4VIT1M verjKSy17OsJVYk25oBTB1KbD/bsWVQrrueR9vKiH10vox0veJjUEQ2vY4tspeEruwXV G57hYB+Ol839dX5GzPOlQ4jz4A5WzUIAsZNunz22J+Mjn2jrXYLvEIeZu1s9XkVbVHSr 6EnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=++gKUWV7wihnVHGiaPBhpRjAk5HG17gAbu0HOE796Cg=; b=Fel52aYM0HxZs9cKk9lhxkXD7dvd/MTWy9saI4zi2tRH8s7Baz/9HpP41xwm8E2KnW 00eG7v2qVDGrZYunLpGS0JvoAhfaAXe8HfaqV1CU8NlMykG1agHtkKG+t2TzMhfWafe4 g2Y2l1NQT/Ua8CTQM5c843M5sM3GlCsvCEiqoW3Zuggo7+x9Ft8XepdEmA3CKdjjefGH BpRnKujoYg1YTCZVIx62EnNYMN5y+itY4Fd50RQckAfAX7CaZTlNYaGxS4DyQgxRNiT5 qI6M24EBhJSIlMzrAw+aMluLwpquFyR/yfA4e6tXxbyK2u8UGxIni4s5Bl2V4IAqWosO mvdw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id q5si9938532pgb.245.2018.12.23.08.42.14; Sun, 23 Dec 2018 08:42:29 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727610AbeLWJfQ (ORCPT + 99 others); Sun, 23 Dec 2018 04:35:16 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:44311 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727321AbeLWJeC (ORCPT ); Sun, 23 Dec 2018 04:34:02 -0500 X-IronPort-AV: E=Sophos;i="5.56,386,1539640800"; d="scan'208";a="289991777" Received: from palace.lip6.fr ([132.227.105.202]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA256; 23 Dec 2018 10:33:54 +0100 From: Julia Lawall To: Viresh Kumar Cc: kernel-janitors@vger.kernel.org, Andy Shevchenko , Vinod Koul , Dan Williams , dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 12/20] dmaengine: dw: drop useless LIST_HEAD Date: Sun, 23 Dec 2018 09:57:07 +0100 Message-Id: <1545555435-24576-13-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop LIST_HEAD where the variable it declares is never used. Commit ab703f818ac3 ("dmaengine: dw: lazy allocation of dma descriptors") removed the uses, but not the declaration. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x; @@ - LIST_HEAD(x); ... when != x // Fixes: ab703f818ac3 ("dmaengine: dw: lazy allocation of dma descriptors") Signed-off-by: Julia Lawall --- Successfully 0-day tested on 151 configurations. drivers/dma/dw/core.c | 1 - 1 file changed, 1 deletion(-) diff --git a/drivers/dma/dw/core.c b/drivers/dma/dw/core.c index dc053e62f894..290d21be4d4c 100644 --- a/drivers/dma/dw/core.c +++ b/drivers/dma/dw/core.c @@ -1150,7 +1150,6 @@ static void dwc_free_chan_resources(struct dma_chan *chan) struct dw_dma_chan *dwc = to_dw_dma_chan(chan); struct dw_dma *dw = to_dw_dma(chan->device); unsigned long flags; - LIST_HEAD(list); dev_dbg(chan2dev(chan), "%s: descs allocated=%u\n", __func__, dwc->descs_allocated);