Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2828692imu; Sun, 23 Dec 2018 08:42:33 -0800 (PST) X-Google-Smtp-Source: ALg8bN5ukjXDAobPeK3juwxE1yVEdRZOxERjCGpgFnCJuJzYGafpdNfNrY431KFR7+xM7O4jFGL2 X-Received: by 2002:a62:5444:: with SMTP id i65mr10557128pfb.193.1545583353176; Sun, 23 Dec 2018 08:42:33 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545583353; cv=none; d=google.com; s=arc-20160816; b=O0fLnD+1nwp0SwjwL+k8fiUlyvbRl5Tvc9DVgqCAjLF8bVmD5+DDKiSA5SNDWLUtM2 yqPK8gNCZWQYqw7XoIjqI/0R3Tm5l/Tta0+tjPYFz8+QjGdB8vBGLrKLYOt0sCtmGcTV VDmFa9nmWf76N10qdDHGvkat8kRTv0DtZ/Dy3NnMpia9YpQHO2voa8cnRu5dzLWSbZXN ejECMkttX6s0ZTrmaSKO2ic3FVq3+/x6ij5+7FTodeAuBkahsEFnd4gTlCWe+2QIdFWC 1PLElYbRo11Hi3zFcLj56xQRKdRBiIdp6DH3HShsUOQJYZZwaoIZeFu2lk9QWQpSXw7P Hauw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:references:in-reply-to:message-id:date :subject:cc:to:from; bh=GHv8gdTVeqb8/y6oqWOjbtxuS9aChmn1RZ3tyTiWiOQ=; b=p0jay7SsFD6JURIo6B3aHWo7hqga6hgKv04ANEDwiQhVaE7a0j7zQQxaNgh0jlH03F 4d4Enq48zn8/JxJysuTfD6paS5L44eGGgUShnOmRLrDtJ2leNjY4Hkk2q18pUhJCqZ6Q 5zwHBo+wQelvqAsBzHk3gwC+baorDsc7IoWNnWd8acDnEeVBrCZUwNOKr4uw80qSHQh9 akzQKYO7CiQwoqwDdkLtLFZuG/raM5RH4xwvMCGvWLJf8Fz4q24F8vvgl8s1THVeqHnd 325xNerjeWqECQy0jeCO1fgRDIrO/hPP1Up11jH6V4dMdZdvLAulzgCNBFpU/Qi+pF2E W7gw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id r25si27745163pfk.28.2018.12.23.08.42.18; Sun, 23 Dec 2018 08:42:33 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727553AbeLWJeu (ORCPT + 99 others); Sun, 23 Dec 2018 04:34:50 -0500 Received: from mail3-relais-sop.national.inria.fr ([192.134.164.104]:44311 "EHLO mail3-relais-sop.national.inria.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727336AbeLWJeE (ORCPT ); Sun, 23 Dec 2018 04:34:04 -0500 X-IronPort-AV: E=Sophos;i="5.56,386,1539640800"; d="scan'208";a="289991780" Received: from palace.lip6.fr ([132.227.105.202]) by mail3-relais-sop.national.inria.fr with ESMTP/TLS/AES128-SHA256; 23 Dec 2018 10:33:55 +0100 From: Julia Lawall To: Trond Myklebust Cc: kernel-janitors@vger.kernel.org, Anna Schumaker , linux-nfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH 15/20] NFS: drop useless LIST_HEAD Date: Sun, 23 Dec 2018 09:57:10 +0100 Message-Id: <1545555435-24576-16-git-send-email-Julia.Lawall@lip6.fr> X-Mailer: git-send-email 1.9.1 In-Reply-To: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> References: <1545555435-24576-1-git-send-email-Julia.Lawall@lip6.fr> Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Drop LIST_HEAD where the variable it declares has never been used. The semantic patch that fixes this problem is as follows: (http://coccinelle.lip6.fr/) // @@ identifier x; @@ - LIST_HEAD(x); ... when != x // Fixes: 0e20162ed1e9 ("NFSv4.1 Use MDS auth flavor for data server connection") Signed-off-by: Julia Lawall --- Successfully 0-day tested on 151 configurations. fs/nfs/nfs4client.c | 1 - 1 file changed, 1 deletion(-) diff --git a/fs/nfs/nfs4client.c b/fs/nfs/nfs4client.c index 2548405da1f7..735c1056a91c 100644 --- a/fs/nfs/nfs4client.c +++ b/fs/nfs/nfs4client.c @@ -145,7 +145,6 @@ static void nfs4_shutdown_ds_clients(struct nfs_client *clp) { struct nfs4_ds_server *dss; - LIST_HEAD(shutdown_list); while (!list_empty(&clp->cl_ds_clients)) { dss = list_entry(clp->cl_ds_clients.next,