Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp2830596imu; Sun, 23 Dec 2018 08:45:17 -0800 (PST) X-Google-Smtp-Source: AFSGD/V119RrZOE0BGkuUVMiRz7vZdF4tp4nlf7HPDMNesQJvk3O/Yoc9kXVtexcQS2iHNxhcyJI X-Received: by 2002:a24:22c6:: with SMTP id o189mr6294323ito.86.1545583517900; Sun, 23 Dec 2018 08:45:17 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545583517; cv=none; d=google.com; s=arc-20160816; b=dw3NpSVoRnSZ2ePKtRWak+sGF35pFAZeHv+33bSpRIa0pdxX2KSnS5iSD6a6frLiEj 5SVIplZppE5QX83QdH0TrZpfbolmXgbqjPZlbTI+6q4Owx6x1G86jKg25+Cz2tI+7QrG yIhHR0YC9Qjnf02P942gB/to7MEvwB9rFg7QOoZg/EbmJtMCndoXb1jfL/v0PXZ2tib7 txGxg5WtrRFRKqoAVrO+fu4travIrpjkW0vtZMOVC9sV/KJAVlOGXe0w5j9f/RHtD3++ upzAAwy/EmmILP33d2/zFZU23tOHVWnjeVtDBqgZ8z3FJPa9BSPkhVOtQi6PXcr58PoO xJFw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:date:message-id:subject:cc:from:to :in-reply-to; bh=Gxf8Ge/zZ78CfKcDILkSvp3zLze6D7jeDXRMDLhoYPQ=; b=rPw01G0jvu7xJhZV3WMmvXZ1+SuoxW4YXfQB8+gDG9+5kre7Q6mZ8GSxjuD4zwRuyY EGMITIvevc3Pu2PwMz7orKyDK8D4osKpLYZy/NBOHJWs6zbeU+tZKcSUL/czoDVhAtlU 6/pf6Tmf9Te1m0R6h1KIA+sGtN9REK/xJLSNOl5KSunM1hCJeqgh53Y9ee+W/VLT5uX9 1U5MklFh8+TNiDXqsqmm0QGlx3yCc/zLREKU2mHkybHo0eK6KfhHI425jq+rEhC01zFn zRAXf5hhPAPjLpmTapUf25zDHGtDwGDk4ziRQCENbsXEoJThkPwdXWxtg0MiOGFDb3Np jpiQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id o133si5152737itc.19.2018.12.23.08.45.04; Sun, 23 Dec 2018 08:45:17 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728932AbeLWN2i (ORCPT + 99 others); Sun, 23 Dec 2018 08:28:38 -0500 Received: from ozlabs.org ([203.11.71.1]:45771 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728706AbeLWN2G (ORCPT ); Sun, 23 Dec 2018 08:28:06 -0500 Received: by ozlabs.org (Postfix, from userid 1034) id 43N38M4cw7z9sNJ; Mon, 24 Dec 2018 00:28:03 +1100 (AEDT) X-powerpc-patch-notification: thanks X-powerpc-patch-commit: 8a19eeeab66dfdd7c67bc8e3048ac0064e8943d7 X-Patchwork-Hint: ignore In-Reply-To: <1545043236-11649-2-git-send-email-firoz.khan@linaro.org> To: Firoz Khan , linuxppc-dev@lists.ozlabs.org, sathnaga@linux.vnet.ibm.com, Benjamin Herrenschmidt , Paul Mackerras , Arnd Bergmann , Geert Uytterhoeven , Ram Pai , Mathieu Desnoyers , Boqun Feng , Breno Leitao , Greg Kroah-Hartman , Philippe Ombredanne , Thomas Gleixner , Kate Stewart From: Michael Ellerman Cc: linux-arch@vger.kernel.org, y2038@lists.linaro.org, linux-kernel@vger.kernel.org, marcin.juszkiewicz@linaro.org, firoz.khan@linaro.org, deepa.kernel@gmail.com Subject: Re: [v6,1/5] powerpc: add __NR_syscalls along with NR_syscalls Message-Id: <43N38M4cw7z9sNJ@ozlabs.org> Date: Mon, 24 Dec 2018 00:28:03 +1100 (AEDT) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2018-12-17 at 10:40:32 UTC, Firoz Khan wrote: > NR_syscalls macro holds the number of system call exist > in powerpc architecture. We have to change the value of > NR_syscalls, if we add or delete a system call. > > One of the patch in this patch series has a script which > will generate a uapi header based on syscall.tbl file. > The syscall.tbl file contains the number of system call > information. So we have two option to update NR_syscalls > value. > > 1. Update NR_syscalls in asm/unistd.h manually by count- > ing the no.of system calls. No need to update NR_sys- > calls until we either add a new system call or delete > existing system call. > > 2. We can keep this feature in above mentioned script, > that will count the number of syscalls and keep it in > a generated file. In this case we don't need to expli- > citly update NR_syscalls in asm/unistd.h file. > > The 2nd option will be the recommended one. For that, I > added the __NR_syscalls macro in uapi/asm/unistd.h along > with NR_syscalls asm/unistd.h. The macro __NR_syscalls > also added for making the name convention same across all > architecture. While __NR_syscalls isn't strictly part of > the uapi, having it as part of the generated header to > simplifies the implementation. We also need to enclose > this macro with #ifdef __KERNEL__ to avoid side effects. > > Signed-off-by: Firoz Khan Series applied to powerpc next, thanks. https://git.kernel.org/powerpc/c/8a19eeeab66dfdd7c67bc8e3048ac0 cheers