Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Manish Rangankar <mrangankar@marvell.com>
To:     YueHaibing <yuehaibing@huawei.com>,
        "QLogic-Storage-Upstream@qlogic.com" 
        <QLogic-Storage-Upstream@qlogic.com>,
        "jejb@linux.ibm.com" <jejb@linux.ibm.com>,
        "martin.petersen@oracle.com" <martin.petersen@oracle.com>
CC:     "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>
Subject: RE: [EXT] [PATCH -next] scsi: qla4xxx: check return code of
 qla4xxx_copy_from_fwddb_param
Thread-Topic: [EXT] [PATCH -next] scsi: qla4xxx: check return code of
 qla4xxx_copy_from_fwddb_param
Thread-Index: AQHUmBJzywVf+R8mw0iHay6myWDC/6WNmv5w
Date:   Mon, 24 Dec 2018 08:49:49 +0000
Message-ID: <DM5PR18MB21349BAF4AF8E373EE037969D8BB0@DM5PR18MB2134.namprd18.prod.outlook.com>
References: <20181220031607.10588-1-yuehaibing@huawei.com>
In-Reply-To: <20181220031607.10588-1-yuehaibing@huawei.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: 70a17c95-2741-4aad-d074-08d6697cc3c7
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2018 08:49:49.9896
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: DM5PR18MB1482
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-12-24_04:,,
 signatures=0
X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=999 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1812240080
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


> -----Original Message-----
> From: YueHaibing <yuehaibing@huawei.com>
> Sent: Thursday, December 20, 2018 8:46 AM
> To: QLogic-Storage-Upstream@qlogic.com; jejb@linux.ibm.com;
> martin.petersen@oracle.com
> Cc: linux-kernel@vger.kernel.org; linux-scsi@vger.kernel.org; YueHaibing
> <yuehaibing@huawei.com>
> Subject: [EXT] [PATCH -next] scsi: qla4xxx: check return code of
> qla4xxx_copy_from_fwddb_param
>=20
> External Email
>=20
> ----------------------------------------------------------------------
> External Email
>=20
> The return code should be check while qla4xxx_copy_from_fwddb_param fails=
.
>=20
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/scsi/qla4xxx/ql4_os.c | 2 ++
>  1 file changed, 2 insertions(+)
>=20
> diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.=
c index
> 949e186..1bc4db6 100644
> --- a/drivers/scsi/qla4xxx/ql4_os.c
> +++ b/drivers/scsi/qla4xxx/ql4_os.c
> @@ -7232,6 +7232,8 @@ static int qla4xxx_sysfs_ddb_tgt_create(struct
> scsi_qla_host *ha,
>=20
>         rc =3D qla4xxx_copy_from_fwddb_param(fnode_sess, fnode_conn,
>                                            fw_ddb_entry);
> +       if (rc)
> +               goto free_sess;
>=20
>         ql4_printk(KERN_INFO, ha, "%s: sysfs entry %s created\n",
>                    __func__, fnode_sess->dev.kobj.name);
> --
> 2.7.0
>=20

Thanks
Acked-by: Manish Rangankar <mrangankar@marvell.com>