Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Nilesh Javali <njavali@marvell.com>
To:     "Gustavo A. R. Silva" <gustavo@embeddedor.com>,
        "Dept-Eng QLogic Storage Upstream" 
        <QLogic-Storage-Upstream@cavium.com>
CC:     "James E.J. Bottomley" <jejb@linux.ibm.com>,
        "Martin K. Petersen" <martin.petersen@oracle.com>,
        "linux-scsi@vger.kernel.org" <linux-scsi@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 36/41] scsi: qla4xxx: ql4_os: mark expected switch
 fall-through
Thread-Topic: [PATCH 36/41] scsi: qla4xxx: ql4_os: mark expected switch
 fall-through
Thread-Index: AQHUhufpXZzxcjxy50iuv0ezG5qkdqWOHNwA
Date:   Mon, 24 Dec 2018 09:01:26 +0000
Message-ID: <D8469DE5.5427A%njavali@marvell.com>
References: <cover.1543374820.git.gustavo@embeddedor.com>
 <a118ae0eeeb3cdcd4846bc1031ea89ca62af1e00.1543374820.git.gustavo@embeddedor.com>
In-Reply-To: <a118ae0eeeb3cdcd4846bc1031ea89ca62af1e00.1543374820.git.gustavo@embeddedor.com>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: marvell.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-ID: <79F86365B1F85B4BA18E2C91171340EE@namprd18.prod.outlook.com>
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: f255ea41-a232-475f-b693-08d6697e62e1
X-MS-Exchange-CrossTenant-originalarrivaltime: 24 Dec 2018 09:01:26.4678
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 70e1fb47-1155-421d-87fc-2e58f638b6e0
X-MS-Exchange-Transport-CrossTenantHeadersStamped: SN1PR18MB2333
X-OriginatorOrg: marvell.com
X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:,, definitions=2018-12-24_04:,,
 signatures=0
X-Proofpoint-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501
 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0
 clxscore=1011 lowpriorityscore=0 mlxscore=0 impostorscore=0
 mlxlogscore=953 adultscore=0 classifier=spam adjust=0 reason=mlx
 scancount=1 engine=8.0.1-1810050000 definitions=main-1812240082
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org


On 11/28/18, 10:03 AM, "linux-scsi-owner@vger.kernel.org on behalf of
Gustavo A. R. Silva" <linux-scsi-owner@vger.kernel.org on behalf of
gustavo@embeddedor.com> wrote:

>External Email
>
>In preparation to enabling -Wimplicit-fallthrough, mark switch cases
>where we are expecting to fall through.
>
>Notice that, in this particular case, I replaced "allow fall-through"
>with a "fall through" annotation, which is what GCC is expecting to
>find.
>
>Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com>
>---
> drivers/scsi/qla4xxx/ql4_os.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/scsi/qla4xxx/ql4_os.c b/drivers/scsi/qla4xxx/ql4_os.c
>index 1c702cd22359..7fd3491ea2d9 100644
>--- a/drivers/scsi/qla4xxx/ql4_os.c
>+++ b/drivers/scsi/qla4xxx/ql4_os.c
>@@ -2876,7 +2876,7 @@ static int qla4xxx_session_get_param(struct
>iscsi_cls_session *cls_sess,
>                                                chap_tbl.secret_len);
>                        }
>                }
>-               /* allow fall-through */
>+               /* fall through */
>        default:
>                return iscsi_session_get_param(cls_sess, param, buf);
>        }
>--
>2.17.1

Thanks.
Acked-by: Nilesh Javali <njavali@marvell.com>