Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Subject: Re: [PATCH] media: mt312: fix a missing check of mt312 reset
To:     Kangjie Lu <kjlu@umn.edu>
Cc:     pakki001@umn.edu, Mauro Carvalho Chehab <mchehab@kernel.org>,
        Hans Verkuil <hans.verkuil@cisco.com>,
        linux-media@vger.kernel.org, linux-kernel@vger.kernel.org
References: <20181221070722.60234-1-kjlu@umn.edu>
From:   Matthias Schwarzott <zzam@gentoo.org>
Message-ID: <4c8a6a16-eced-db2c-2edf-8cdaf0122382@gentoo.org>
Date:   Mon, 24 Dec 2018 12:23:28 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101
 Thunderbird/60.4.0
MIME-Version: 1.0
In-Reply-To: <20181221070722.60234-1-kjlu@umn.edu>
Content-Type: text/plain; charset=utf-8
Content-Language: en-GB
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Am 21.12.18 um 08:07 schrieb Kangjie Lu:
> mt312_reset() may fail. Although it is called in the end of
> mt312_set_frontend(), we better check its status and return its error
> code upstream instead of 0.
> 
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>

Thanks for submitting this patch. It looks correct.

Reviewed-by: Matthias Schwarzott <zzam@gentoo.org>

> ---
>  drivers/media/dvb-frontends/mt312.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/media/dvb-frontends/mt312.c b/drivers/media/dvb-frontends/mt312.c
> index 03e74a729168..bfbb879469f2 100644
> --- a/drivers/media/dvb-frontends/mt312.c
> +++ b/drivers/media/dvb-frontends/mt312.c
> @@ -645,7 +645,9 @@ static int mt312_set_frontend(struct dvb_frontend *fe)
>  	if (ret < 0)
>  		return ret;
>  
> -	mt312_reset(state, 0);
> +	ret = mt312_reset(state, 0);
> +	if (ret < 0)
> +		return ret;
>  
>  	return 0;
>  }
>