Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 24 Dec 2018 14:14:18 +0200
From:   Mike Rapoport <rppt@linux.ibm.com>
To:     "huang.zijiang" <huang.zijiang@zte.com.cn>
Cc:     akpm@linux-foundation.org, rppt@linux.vnet.ibm.com,
        mhocko@suse.com, sfr@canb.auug.org.au, mpe@ellerman.id.au,
        linux-kernel@vger.kernel.org, xue.zhihong@zte.com.cn,
        wang.yi59@zte.com.cn
Subject: Re: [PATCH] firmware/memmap:Modify memblock_alloc to
 memblock_alloc_nopanic
References: <1545640882-42009-1-git-send-email-huang.zijiang@zte.com.cn>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1545640882-42009-1-git-send-email-huang.zijiang@zte.com.cn>
User-Agent: Mutt/1.5.24 (2015-08-30)
Message-Id: <20181224121417.GB2070@rapoport-lnx>
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, Dec 24, 2018 at 04:41:22PM +0800, huang.zijiang wrote:
> From: "huang.zijiang" <huang.zijiang@zte.com.cn>
> 
> memblock_alloc never returns NULL because panic never returns
> 
> Signed-off-by: huang.zijiang <huang.zijiang@zte.com.cn>

Acked-by: Mike Rapoport <rppt@linux.ibm.com>

> ---
>  drivers/firmware/memmap.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/firmware/memmap.c b/drivers/firmware/memmap.c
> index d168c87..ec4fd25 100644
> --- a/drivers/firmware/memmap.c
> +++ b/drivers/firmware/memmap.c
> @@ -333,7 +333,7 @@ int __init firmware_map_add_early(u64 start, u64 end, const char *type)
>  {
>  	struct firmware_map_entry *entry;
> 
> -	entry = memblock_alloc(sizeof(struct firmware_map_entry),
> +	entry = memblock_alloc_nopanic(sizeof(struct firmware_map_entry),
>  			       SMP_CACHE_BYTES);
>  	if (WARN_ON(!entry))
>  		return -ENOMEM;
> -- 
> 1.8.3.1
> 

-- 
Sincerely yours,
Mike.