Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Message-ID: <4a78261cba6647cd9665ed42f175eeedf412b85b.camel@gmail.com>
Subject: Re: [EXT] [PATCH v1] bnx2x: Fix NULL pointer dereference in
 bnx2x_del_all_vlans() on some hw
From:   Ivan Mironov <mironov.ivan@gmail.com>
To:     Sudarsana Reddy Kalluru <skalluru@marvell.com>,
        "netdev@vger.kernel.org" <netdev@vger.kernel.org>
Cc:     Ariel Elior <ariel.elior@cavium.com>,
        Sudarsana Kalluru <sudarsana.kalluru@cavium.com>,
        "everest-linux-l2@cavium.com" <everest-linux-l2@cavium.com>,
        "David S. Miller" <davem@davemloft.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Date:   Mon, 24 Dec 2018 20:16:38 +0500
In-Reply-To: <CY4PR18MB125333EFFE5875193E66927FD3BB0@CY4PR18MB1253.namprd18.prod.outlook.com>
References: <20181224115609.21752-1-mironov.ivan@gmail.com>
         <CY4PR18MB125333EFFE5875193E66927FD3BB0@CY4PR18MB1253.namprd18.prod.outlook.com>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.30.3 (3.30.3-1.fc29) 
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Mon, 2018-12-24 at 14:26 +0000, Sudarsana Reddy Kalluru wrote:
> Thanks a lot for root-causing the issue and the patch.
> Another (simpler) way to address this would be to invoke bnx2x_del_all_vlans() only for the newer chips, e.g., 
> +       if (!CHIP_IS_E1(bp)) {
> 	/* Remove all currently configured VLANs */
>                rc = bnx2x_del_all_vlans(bp);
>                if (rc < 0)
>                        BNX2X_ERR("Failed to delete all VLANs\n");
> +       }
> Could you please check on this?

Done. See the PATCH v2 in the mailing list. I tested it on my system.