Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Mon, 24 Dec 2018 14:46:35 -0800 (PST)
Message-Id: <20181224.144635.854624726050744324.davem@davemloft.net>
To:     mironov.ivan@gmail.com
Cc:     netdev@vger.kernel.org, ariel.elior@cavium.com,
        sudarsana.kalluru@cavium.com, everest-linux-l2@cavium.com,
        linux-kernel@vger.kernel.org, skalluru@marvell.com
Subject: Re: [PATCH v2] bnx2x: Fix NULL pointer dereference in
 bnx2x_del_all_vlans() on some hw
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20181224151305.31027-1-mironov.ivan@gmail.com>
References: <20181224151305.31027-1-mironov.ivan@gmail.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Ivan Mironov <mironov.ivan@gmail.com>
Date: Mon, 24 Dec 2018 20:13:05 +0500

> This happened when I tried to boot normal Fedora 29 system with latest
> available kernel (from fedora rawhide, plus some unrelated custom
> patches):
 ...
> After some investigation I figured out that recently added cleanup code
> tries to call VLAN filtering de-initialization function which exist only
> for newer hardware. Corresponding function pointer is not
> set (== 0) for older hardware, namely these chips:
> 
> 	#define CHIP_NUM_57710			0x164e
> 	#define CHIP_NUM_57711			0x164f
> 	#define CHIP_NUM_57711E			0x1650
> 
> And I have one of those in my test system:
> 
> 	Broadcom Inc. and subsidiaries NetXtreme II BCM57711E 10-Gigabit PCIe [14e4:1650]
> 
> Function bnx2x_init_vlan_mac_fp_objs() from
> drivers/net/ethernet/broadcom/bnx2x/bnx2x_cmn.h decides whether to
> initialize relevant pointers in bnx2x_sp_objs.vlan_obj or not.
> 
> This regression was introduced after v4.20-rc7, and still exists in v4.20
> release.
> 
> Fixes: 04f05230c5c13 ("bnx2x: Remove configured vlans as part of unload sequence.")
> Signed-off-by: Ivan Mironov <mironov.ivan@gmail.com>

Applied, thanks.