Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Wed, 26 Dec 2018 11:54:32 +0100
From:   Sam Ravnborg <sam@ravnborg.org>
To:     Laurent Pinchart <laurent.pinchart@ideasonboard.com>
Cc:     Brajeswar Ghosh <brajeswar.linux@gmail.com>,
        sabyasachi.linux@gmail.com, airlied@linux.ie,
        linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org,
        jrdr.linux@gmail.com
Subject: Re: [PATCH] drm/bridge/panel: Remove duplicate header
Message-ID: <20181226105432.GA27553@ravnborg.org>
References: <20181224143218.GA3170@hp-pavilion-15-notebook-pc-brajeswar>
 <1891132.39bZHgSTRL@avalon>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1891132.39bZHgSTRL@avalon>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Hi Brajeswar

> On Monday, 24 December 2018 16:32:18 EET Brajeswar Ghosh wrote:
> > Remove drm/drm_panel.h which is included more than once
> > 
> > Signed-off-by: Brajeswar Ghosh <brajeswar.linux@gmail.com>
> > ---
> >  drivers/gpu/drm/bridge/panel.c | 1 -
> >  1 file changed, 1 deletion(-)
> > 
> > diff --git a/drivers/gpu/drm/bridge/panel.c b/drivers/gpu/drm/bridge/panel.c
> > index 7cbaba213ef6..402b318eeeb2 100644
> > --- a/drivers/gpu/drm/bridge/panel.c
> > +++ b/drivers/gpu/drm/bridge/panel.c
> > @@ -15,7 +15,6 @@
> >  #include <drm/drm_crtc_helper.h>
> >  #include <drm/drm_encoder.h>
> >  #include <drm/drm_modeset_helper_vtables.h>
> > -#include <drm/drm_panel.h>
> 
> While at it, how about sorting headers alphabetically to make sure this won't 
> happen again ?

Even better would be to address the todo item:
"Clean up the DRM header mess" (see Documentation/gpu/todo.rst)

In other words - replace the include of "drmP.h" with the relevant header files.
Sorted, as suggested by Laurent.

	Sam