Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp5721554imu; Wed, 26 Dec 2018 07:49:05 -0800 (PST) X-Google-Smtp-Source: ALg8bN5KXB9S1Fq9vngzml/Jq3Y0xh3rPPAfcrKP2Ysgg7SIChhzWPtNWc2op126f9RK+121War4 X-Received: by 2002:a63:7512:: with SMTP id q18mr17876155pgc.231.1545839345528; Wed, 26 Dec 2018 07:49:05 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545839345; cv=none; d=google.com; s=arc-20160816; b=DuOB22BtRuUo16vsGI/al2Nl+ioV07RsOr2Tcn4NvyeVdmCevywxzLQkuVOloc/e0a dMnAiImxUgpI2vFx9zo/cW6RWMXmIl4wjvATYxqmct+RfBTHtS1ghfyHClcW51aYYqzJ 31/guKu1rdfaSc3XwRgZEP98xR+0f6AaVKZoKnIzd2pfO/JvRfmMWxwU9qdOUd8Nx89j nM8LW9RqOegsSfzVq7jKfCpl6Qva6ZMd8m73JAExFnL21Ykx/lqxFEs6IZQkpImAcXDA hJAoIcDyJ4o6XIXcVWL77hFtsRBrcTX3atOU0GM2dQcokmBb8Z0AfVWrTfrFffcK2oWN B4tw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding :content-language:in-reply-to:mime-version:user-agent:date :message-id:from:references:cc:to:subject:dkim-signature; bh=wSSRJEtUgxwPO4F1sYGBr6wXeOOkil8wtqRQ19i/KYg=; b=O5cRKowhHu9RX2pIhR+viEdEAoKxnfLjv2xDTsrqsVDDklG6Rp8ZmcuWveUEgcEdcN HsNMQ5q51ejpbwhOcw+Z9Hj0E7P7onnVwPizrrCxyIfiDVudiFueN5sPW65Juhs1Tspm G4SuBMeL8wjYkHKvmhAl01X3wmm4JHA5KI19tKyBZOHLpMS5O5Omjv7AK1wkONZ1siIt VrPgE8a4UUEbDZmnYrdfpFlRZNH+11Kgo5wWjZpNuPJVFu5zsrzCfmlDttBa25Sv8jVt kyXaX/SKVuxzaANROgHVXclWMCwJpx4CMt8hYbzUKdPjdIlgKq3XuT/FW2rWBQh68/lQ KR9A== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=dscSSnUP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id k16si31093805pls.124.2018.12.26.07.48.50; Wed, 26 Dec 2018 07:49:05 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@synopsys.com header.s=mail header.b=dscSSnUP; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=synopsys.com Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727064AbeLZPbD (ORCPT + 99 others); Wed, 26 Dec 2018 10:31:03 -0500 Received: from smtprelay4.synopsys.com ([198.182.47.9]:52276 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725763AbeLZPbC (ORCPT ); Wed, 26 Dec 2018 10:31:02 -0500 Received: from mailhost.synopsys.com (mailhost1.synopsys.com [10.12.238.239]) by smtprelay.synopsys.com (Postfix) with ESMTP id 153FB24E25B5; Wed, 26 Dec 2018 07:31:02 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=synopsys.com; s=mail; t=1545838262; bh=Te//KRYuxaqva0xlJVkZ+PV9LWlrJf8OLOsnwHq3sO8=; h=Subject:To:CC:References:From:Date:In-Reply-To:From; b=dscSSnUPhoDAP92rIMGL5ig/0glyo7OgdwBJbNiQH704pUhmpBe+u6pK67BQyQ8cL 7gxF718YxtdTl97fTsR7uMMarX9UOm3wxS3cBqeqewyDkMOv06gw5z+kfB2a7N0F4E Um98ZH8rkwT45t+prDGgnPwTl7QlXlr3rXGD0Go0Ku+l78DoCCQ5b2drktMnR6jgcT imOupR+yFm0UjbSgMhgGgOOhKi2H7OUhVFwToWxlJPJmQMZ+KvqhnyY20iIGKesq9z M1vyL9feYcj4jvc7EN3LPRw6eHqHYmhEF7034ktkTQPbSy6/cyU4BuMu+zEhXD0fQU d2oRoUHawhemg== Received: from US01WXQAHTC1.internal.synopsys.com (us01wxqahtc1.internal.synopsys.com [10.12.238.230]) by mailhost.synopsys.com (Postfix) with ESMTP id E44525F8E; Wed, 26 Dec 2018 07:31:01 -0800 (PST) Received: from DE02WEHTCB.internal.synopsys.com (10.225.19.94) by US01WXQAHTC1.internal.synopsys.com (10.12.238.230) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 26 Dec 2018 07:31:01 -0800 Received: from DE02WEHTCA.internal.synopsys.com (10.225.19.92) by DE02WEHTCB.internal.synopsys.com (10.225.19.94) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 26 Dec 2018 16:30:59 +0100 Received: from [10.225.2.19] (10.225.2.19) by DE02WEHTCA.internal.synopsys.com (10.225.19.80) with Microsoft SMTP Server (TLS) id 14.3.408.0; Wed, 26 Dec 2018 16:30:59 +0100 Subject: Re: [PATCH 00/21] i.MX6, DesignWare PCI improvements To: Andrey Smirnov , "linux-pci@vger.kernel.org" CC: Lorenzo Pieralisi , Bjorn Helgaas , Fabio Estevam , Chris Healy , Lucas Stach , Leonard Crestez , "A.s. Dong" , Richard Zhu , "linux-imx@nxp.com" , "linux-arm-kernel@lists.infradead.org" , "linux-kernel@vger.kernel.org" References: <20181221072716.29017-1-andrew.smirnov@gmail.com> From: Gustavo Pimentel Message-ID: <3b3a232c-4991-cdb4-59f3-29fba93dfefc@synopsys.com> Date: Wed, 26 Dec 2018 15:26:29 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.3.3 MIME-Version: 1.0 In-Reply-To: <20181221072716.29017-1-andrew.smirnov@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Language: en-US Content-Transfer-Encoding: 7bit X-Originating-IP: [10.225.2.19] Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, On 21/12/2018 07:26, Andrey Smirnov wrote: > Everyone: > > This is the series containing various small improvements that I made > while reading the code and researching commit history of pci-imx6.c > and pcie-designware*.c files. All changes are optional, so commits > that don't seem like an improvement can be easily dropped. Hopefully > each patch is self-explanatory. > > I tested this series on i.MX6Q, i.MX7D and i.MX8MQ. > > Feedback is welcome! > > Thanks, > Andrey Smirnov > > Andrey Smirnov (21): > PCI: imx6: Simplify imx7d_pcie_wait_for_phy_pll_lock() > PCI: imx6: Remove redundant debug tracing > PCI: imx6: Return -ETIMEOUT from imx6_pcie_wait_for_speed_change() > PCI: imx6: Remove duplicate macro definitions > PCI: imx6: Remove PCIE_PL_PFLR_* constants > PCI: imx6: Remove PCIE_PHY_RX_ASIC_OUT* constants > PCI: designware: Make use of IS_ALIGNED() > PCI: designware: Share code for dw_pcie_rd/wr_other_conf() > PCI: imx6: Drop imx6_pcie_link_up() > PCI: designware: imx6: Share PHY debug register definitions > PCI: designware: Make use of BIT() in constant definitions > PCI: imx6: Make use of BIT() in constant definitions > PCI: imx6: Simplify bit operations in PHY functions > PCI: imx6: Simplify pcie_phy_poll_ack() > PCI: imx6: Restrict PHY register data to 16-bit > PCI: imx6: Pass data to dw_pcie_writel_dbi() directly > PCI: imx6: Use common mask in imx6_pcie_reset_phy() > PCI: imx6: Simplify bit operations in imx6_setup_phy_mpll() > PCI: imx6: Remove magic numbers from imx6_pcie_establish_link() > PCI: designware: Make use of GENMASK/FIELD_PREP > PCI: designware: Remove superfluous shifting in definitions s/DesignWare/dwc in all patches, please. Regards, Gustavo > > drivers/pci/controller/dwc/pci-imx6.c | 151 +++++++----------- > .../pci/controller/dwc/pcie-designware-host.c | 61 +++---- > drivers/pci/controller/dwc/pcie-designware.c | 18 +-- > drivers/pci/controller/dwc/pcie-designware.h | 60 +++---- > 4 files changed, 116 insertions(+), 174 deletions(-) >