Message-ID: <40131778.80008@jpl.nasa.gov>
Date: Sat, 24 Jan 2004 17:10:16 -0800
From: Bryan Whitehead <driver@jpl.nasa.gov>
User-Agent: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.6) Gecko/20040122
MIME-Version: 1.0
To: Bryan Whitehead <driver@megahappy.net>
Cc: Christoph Hellwig <hch@infradead.org>, linux-kernel@vger.kernel.org,
       akpm@osdl.org, nathans@sgi.com, owner-xfs@oss.sgi.com
Subject: Re: [PATCH 2.6.2-rc1-mm2] fs/xfs/xfs_log_recover.c
References: <20040124073111.34B2313A354@mrhankey.megahappy.net> <20040124082606.A3107@infradead.org> <Pine.LNX.4.58.0401241655010.32008@mrhankey.homeip.net>
In-Reply-To: <Pine.LNX.4.58.0401241655010.32008@mrhankey.homeip.net>
Content-Type: text/plain; charset=us-ascii; format=flowed
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1148
Lines: 34

If I'm off base on this then sorry for the trouble. Just thought I'd 
take a hit at getting rid of some compiler warnings..

Bryan Whitehead wrote:
> Oh, one more thing. After removed the superflurous switch statement flags 
> will have a value which fixes the warning.
> 
> If you look at the flow of code it is impossible for flags to not have a 
> value when it gets to the if statement as the previous switch statement 
> would give it a value. But since that switch statement only catches that 
> one case anyway, it's better to merge the 2 switch statemnets.
> 
> On Sat, 24 Jan 2004, Christoph Hellwig wrote:
> 
> 
>>On Fri, Jan 23, 2004 at 11:31:11PM -0800, Bryan Whitehead wrote:
>>
>>>This fixes a warning on compile of the xfs fs module.
>>
>>This patch looks very strange.  What error do you get without it?
>>
> 
> 


-- 
Bryan Whitehead
Email:driver@megahappy.net
WorkE:driver@jpl.nasa.gov
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/