Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
From:   Peter Chen <peter.chen@nxp.com>
To:     Kangjie Lu <kjlu@umn.edu>
CC:     "pakki001@umn.edu" <pakki001@umn.edu>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        "linux-usb@vger.kernel.org" <linux-usb@vger.kernel.org>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [PATCH v2] usb: chipidea: add a check for the availability of
 next child
Thread-Topic: [PATCH v2] usb: chipidea: add a check for the availability of
 next child
Thread-Index: AQHUnUoO9MIG4EkfUUeSNsgWZSwNq6WRvrmg
Date:   Thu, 27 Dec 2018 00:43:50 +0000
Message-ID: <VI1PR04MB5327BBB98B2C0AD6E4D713058BB60@VI1PR04MB5327.eurprd04.prod.outlook.com>
References: <20181226183643.76912-1-kjlu@umn.edu>
In-Reply-To: <20181226183643.76912-1-kjlu@umn.edu>
Accept-Language: en-US
Content-Language: en-US
received-spf: None (protection.outlook.com: nxp.com does not designate
 permitted sender hosts)
spamdiagnosticoutput: 1:99
spamdiagnosticmetadata: NSPM
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: quoted-printable
MIME-Version: 1.0
X-MS-Exchange-CrossTenant-Network-Message-Id: dd8ba70a-3edf-444e-606e-08d66b945ed7
X-MS-Exchange-CrossTenant-originalarrivaltime: 27 Dec 2018 00:43:50.8557
 (UTC)
X-MS-Exchange-CrossTenant-fromentityheader: Hosted
X-MS-Exchange-CrossTenant-id: 686ea1d3-bc2b-4c6f-a92c-d99c5c301635
X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR04MB4672
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

=20
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
>  drivers/usb/chipidea/ci_hdrc_msm.c | 4 ++++
>  1 file changed, 4 insertions(+)
>=20
> diff --git a/drivers/usb/chipidea/ci_hdrc_msm.c
> b/drivers/usb/chipidea/ci_hdrc_msm.c
> index 880009987460..b7f7acef72d4 100644
> --- a/drivers/usb/chipidea/ci_hdrc_msm.c
> +++ b/drivers/usb/chipidea/ci_hdrc_msm.c
> @@ -250,6 +250,10 @@ static int ci_hdrc_msm_probe(struct platform_device
> *pdev)
>  	ulpi_node =3D of_get_child_by_name(pdev->dev.of_node, "ulpi");
>  	if (ulpi_node) {
>  		phy_node =3D of_get_next_available_child(ulpi_node, NULL);
> +		if (!phy_node) {
> +			dev_err(&pdev->dev, "no child nodes found\n");
> +			return -ENODEV;
> +		}

There are still two issues for this patch:
- It can't return -ENODEV directly, instead, it needs to goto err_mux
- Before goto err_mux, it needs to call of_node_put(ulpi_node);

Besides, for kernel code style, you may leave one blank line after if () {}=
 statement.

Peter

>  		ci->hsic =3D of_device_is_compatible(phy_node, "qcom,usb-hsic-phy");
>  		of_node_put(phy_node);
>  	}
> --
> 2.17.2 (Apple Git-113)