Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7247485imu; Thu, 27 Dec 2018 15:44:59 -0800 (PST) X-Google-Smtp-Source: AFSGD/XcUg5evM7SEFxMcdcEdsfgFng0teaph8GmxchSny8O+gCKjCjYN4fwJ5DJe48rJ8uU86Nh X-Received: by 2002:a62:7504:: with SMTP id q4mr25509785pfc.180.1545954299804; Thu, 27 Dec 2018 15:44:59 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545954299; cv=none; d=google.com; s=arc-20160816; b=Tfn//lJca4iTOzYM1kr4RFwriFyqNfJRupEKSEOFYFvaLFQY2Vg9OwV7g93up2GwXk UEnmrPjW3NNT3knqybfCKACNZbgNCzs/g3mM5xP8TONSS/SxFXeYTJjHV6xRrAiLWQCF akmbRCvMGyYyDV6c7DUL6BvgwsYu526DVCShQ84iTko6cxF90Aufm35fUyAlKUx/AkP+ KQTGiu6KyQN7NYY6TuA8T+B/tTo0GeoUGjh7S5f8xU8ICf/munpnvMuFDIQQOIDc6DCQ Qd10m7HBMP8me96QLnmDmDDRLsUndahIuEMXlGlAQAcy15l6hYxe/rAxtHBUZoQuR1fS mvnA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:mail-followup-to :message-id:subject:cc:to:from:date:dkim-signature; bh=GcWCqfedkueofyQnuZgmOcR/5gSP4PtRs9I8Z9HPg70=; b=qG/Vy19mSgX7t6LR1R1f7bYH1JSxKwFE6GcSk7/e2/QKqTb0zdsDISKxlVA5/MVZeB Q8NTJXgU/eJ0pfGPxpeqJKn7q0RzAwgE7iZWuTnKx2JF7s+9F4q+ZH7DvQAAQFhWhCGW uuYsoLsYWB9jeGV736nov7s5PuPBRjAzBXG5oGr9qYTwmDFze8WM85Z927MiauZzVOET +Vo5x7dxsEtdj3+s7+APcSR5X1CM8grNLmm4dk6AfyeXK3oRHukuu8m7uxbcmYxtGyvp 2euvEUpMvqvCsjgUYYfAxNL/+E84rbRk+rLVmzcjUxVD6lypFh/2M5PEjMpjL16kzwDV W7kw== ARC-Authentication-Results: i=1; mx.google.com; dkim=fail header.i=@ffwll.ch header.s=google header.b=DVULk7bU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id z9si2811632pgf.54.2018.12.27.15.44.44; Thu, 27 Dec 2018 15:44:59 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=fail header.i=@ffwll.ch header.s=google header.b=DVULk7bU; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730958AbeL0MJZ (ORCPT + 99 others); Thu, 27 Dec 2018 07:09:25 -0500 Received: from mail-ed1-f66.google.com ([209.85.208.66]:41890 "EHLO mail-ed1-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730264AbeL0MJZ (ORCPT ); Thu, 27 Dec 2018 07:09:25 -0500 Received: by mail-ed1-f66.google.com with SMTP id a20so8302338edc.8 for ; Thu, 27 Dec 2018 04:09:24 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=GcWCqfedkueofyQnuZgmOcR/5gSP4PtRs9I8Z9HPg70=; b=DVULk7bUjbViCGAGuHzoD4l6gW5MHQQt2hMI4oqRKknr0K8bsspOxH1kWGdsOoFyMx mIm19neQ2msIoNzaM96ofEGjHcuOEqM47AklGFnoeoyxTlo4futIzWRZWBsFDY8wuYXu p7f9JeHJM3cLpEnnQox7vuNKLz5YoSmkUL6vs= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=GcWCqfedkueofyQnuZgmOcR/5gSP4PtRs9I8Z9HPg70=; b=RE4dBH1JyGIxHIxuqRdJ/OAbMBd0UyCGpDPlBOwCaxSztMaWsi5PC4sl2ptUeebMcW jIUKMsglNvA0l3SonlF8S8q3d8aDzlxCxCh6bi1PYwVR1xBWi/dhOUJgnQ2fYir4WXWn ecVUH04Ne87G+l51fXPEJChu2Sw4W/caqWyID/s01fwPfrXv1kAbmBPCLO8mgaA57Axi iCHCh+3rK+SlRy1NTWmLFce6l/2pdxiIGRZTTczPXdZOjIZhxj9H6jfJuf6S6Fe0k7Pg +RH9A+2tvSfZnDFdEnuoF6YHywK2uFfF+sm1+74psdGbwxzj/WFa4ykOdinNEQsuruCu R4zA== X-Gm-Message-State: AA+aEWZhZ1Ft8J4NKR4oII2cmd0kW9h2Ht6IjD/PqTwG0j3HpMQ+Ni3c HPEKzGWMx+LhplegWZM21J+nyw== X-Received: by 2002:a50:a974:: with SMTP id m49mr19060640edc.220.1545912563332; Thu, 27 Dec 2018 04:09:23 -0800 (PST) Received: from dvetter-linux.ger.corp.intel.com ([194.230.159.220]) by smtp.gmail.com with ESMTPSA id d56sm11527606ede.76.2018.12.27.04.09.21 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Thu, 27 Dec 2018 04:09:22 -0800 (PST) Date: Thu, 27 Dec 2018 13:09:19 +0100 From: Daniel Vetter To: Sam Ravnborg Cc: Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Sean Paul , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org Subject: Re: [PATCH v1 1/7] drm: move DRM_IF_VERSION to drm_internal.h Message-ID: <20181227120919.GD9058@dvetter-linux.ger.corp.intel.com> Mail-Followup-To: Sam Ravnborg , David Airlie , Maarten Lankhorst , Maxime Ripard , Sean Paul , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org References: <20181226210215.GA27610@ravnborg.org> <20181226210353.13993-1-sam@ravnborg.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181226210353.13993-1-sam@ravnborg.org> X-Operating-System: Linux dvetter-linux.ger.corp.intel.com 4.19.10-200.fc28.x86_64 User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 26, 2018 at 10:03:47PM +0100, Sam Ravnborg wrote: > Move DRM_IF_VERSION out of drmP.h to allow users > to get rid of the drmP include. > > Signed-off-by: Sam Ravnborg > Cc: Maarten Lankhorst > Cc: Maxime Ripard > Cc: Sean Paul > Cc: David Airlie > Cc: Daniel Vetter Applied to drm-misc-next, thanks for your patch. -Daniel > --- > drivers/gpu/drm/drm_internal.h | 2 ++ > include/drm/drmP.h | 2 -- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/gpu/drm/drm_internal.h b/drivers/gpu/drm/drm_internal.h > index 51e06defc8d8..e9374cd43610 100644 > --- a/drivers/gpu/drm/drm_internal.h > +++ b/drivers/gpu/drm/drm_internal.h > @@ -26,6 +26,8 @@ > #define DRM_IF_MAJOR 1 > #define DRM_IF_MINOR 4 > > +#define DRM_IF_VERSION(maj, min) (maj << 16 | min) > + > struct drm_prime_file_private; > struct dma_buf; > > diff --git a/include/drm/drmP.h b/include/drm/drmP.h > index 05350424a4d3..b6b8436b5123 100644 > --- a/include/drm/drmP.h > +++ b/include/drm/drmP.h > @@ -95,8 +95,6 @@ struct dma_buf_attachment; > struct pci_dev; > struct pci_controller; > > -#define DRM_IF_VERSION(maj, min) (maj << 16 | min) > - > #define DRM_SWITCH_POWER_ON 0 > #define DRM_SWITCH_POWER_OFF 1 > #define DRM_SWITCH_POWER_CHANGING 2 > -- > 2.12.0 > -- Daniel Vetter Software Engineer, Intel Corporation http://blog.ffwll.ch