Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7566232imu; Fri, 28 Dec 2018 00:24:54 -0800 (PST) X-Google-Smtp-Source: ALg8bN6FAFsjpzTahPtC6NjYUqPkvK3/eY0lMK8WuXc+o9eOvj2p5ulOdJoNn3L9jzzL/3GcoGUX X-Received: by 2002:a63:200e:: with SMTP id g14mr25628393pgg.235.1545985494520; Fri, 28 Dec 2018 00:24:54 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545985494; cv=none; d=google.com; s=arc-20160816; b=VPjB6zuqfdVOLJwCd+jdCUdcHCySEGn5a9UfPEo5XKm2qocRW8K5gzHDLBzjz4kiep nK2hV7Sqh3EaEWJDNcBdtTwFlTNu1mkSXYdOyQpFZjjRKX6Rs0J0zUcJdu0VWZBdizTa AZ5HtECWhjlFoixWp3omEGPku0mIZdAGl9saH4XmyV2LJGbFwiY9UvZ3/3LiObtnOVEC XrysxtyoIXSArpxPFfkfbs006cLW/wBLByfOAqnTM+vdPnTnSXxaceaHFZ1SzPIZ9nJG CncTFqu3jGfrNYLXiSQoqU3j+1P2r6ycB1V+VsfELi+5fiQKYxbi7Kw9Bscw1n0o9PF6 ddew== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=jaV+ql8hi+LgtLFdtxzQZI2YAaIrtQqUgwo4OSAAb8k=; b=wdsHVmyxnUInuLJEfXJmb+ARjwAXxWjnt0Ll2P0+lx8+5Xw5wud9d5V/X2hPCaNFMc yMGdsJoMf07tnaLyu0Bw9iHLAEl14LpHQg7SiIlbBRBeIpTYJWtRAtCEPfO9EdrOj59f slbuZhdVrUZ8blw5WPw/EcqYlYMUAvlt2mCXukE84sYvUEiFnHi0BoyWgxzB4Zi4NWca jz04pfLaKW0/+xoDQkqb1X+fpSmeTvWvyUuwwV1MbendSIba6bBgSoOsOjR/RrkB+6bZ UBHHv8CoaGUt03ovUCPdn29NqCYBVCMj7OrqpeW95aK2Bbw6Vmnuvu3qtwhlr/TpAYxp Hahw== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 30si36450826pgr.396.2018.12.28.00.24.39; Fri, 28 Dec 2018 00:24:54 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730720AbeL0WWQ (ORCPT + 99 others); Thu, 27 Dec 2018 17:22:16 -0500 Received: from asavdk4.altibox.net ([109.247.116.15]:42514 "EHLO asavdk4.altibox.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730705AbeL0WWP (ORCPT ); Thu, 27 Dec 2018 17:22:15 -0500 Received: from ravnborg.org (unknown [158.248.194.18]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by asavdk4.altibox.net (Postfix) with ESMTPS id 07D1D80431; Thu, 27 Dec 2018 23:22:10 +0100 (CET) Date: Thu, 27 Dec 2018 23:22:09 +0100 From: Sam Ravnborg To: David Lechner Cc: Daniel Vetter , David Airlie , Maarten Lankhorst , Maxime Ripard , Sean Paul , linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, Alexey Brodkin , Yannick Fertre , Philippe Cornu , Benjamin Gaignard , Vincent Abriou , Maxime Coquelin , Alexandre Torgue , Noralf =?iso-8859-1?Q?Tr=F8nnes?= Subject: Re: [PATCH v1 7/7] drm: remove include of drmP.h from drm_gem_cma_helper.h Message-ID: <20181227222209.GB29366@ravnborg.org> References: <20181226210215.GA27610@ravnborg.org> <20181226210353.13993-7-sam@ravnborg.org> <6c792214-ed92-e942-0e3d-72628c037d00@lechnology.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6c792214-ed92-e942-0e3d-72628c037d00@lechnology.com> User-Agent: Mutt/1.5.21 (2010-09-15) X-CMAE-Score: 0 X-CMAE-Analysis: v=2.3 cv=UpRNyd4B c=1 sm=1 tr=0 a=UWs3HLbX/2nnQ3s7vZ42gw==:117 a=UWs3HLbX/2nnQ3s7vZ42gw==:17 a=kj9zAlcOel0A:10 a=FkEfBJW9IQvnzsQHlycA:9 a=CjuIK1q_8ugA:10 Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi David. Thanks for your comments. On Thu, Dec 27, 2018 at 10:28:07AM -0600, David Lechner wrote: > On 12/26/18 3:03 PM, Sam Ravnborg wrote: > >Fix fallout in various files/drivers. > > > > What fallout is being fixed? The removal of drmP.h from drm_gem_cma_helper.h resulted in some build erros that is fixed by this patch. drmP.h was removed from the header file to make it possible to remove drmP.h on a file-by-file (or driver-by-driver) basis for the rest of gpu/drm/* > It would be helpful if we received the full > patch series for context. It would also be nice to have a more detailed > description in this commit message. The cc: list was too long to include everyone in the cover letter. In v2 I will make the individual commit message self explaning. For v2 I also need to re-vist the changes as I have added include files in some cases where a forward declaration would have been enough. Sam