Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Thu, 27 Dec 2018 16:25:50 -0800 (PST)
Message-Id: <20181227.162550.173701726860933882.davem@davemloft.net>
To:     kjlu@umn.edu
Cc:     pakki001@umn.edu, linux-net-drivers@solarflare.com,
        ecree@solarflare.com, bkenward@solarflare.com,
        netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net: sfc: checks status of efx_mcdi_rpc
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20181226050517.74381-1-kjlu@umn.edu>
References: <20181226050517.74381-1-kjlu@umn.edu>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Kangjie Lu <kjlu@umn.edu>
Date: Tue, 25 Dec 2018 23:05:17 -0600

> efx_mcdi_rpc() could fail. The fix checks its status and issues an error
> message if it fails.
> 
> Signed-off-by: Kangjie Lu <kjlu@umn.edu>
> ---
>  drivers/net/ethernet/sfc/mcdi.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/net/ethernet/sfc/mcdi.c b/drivers/net/ethernet/sfc/mcdi.c
> index dfad93fca0a6..9486e6534dea 100644
> --- a/drivers/net/ethernet/sfc/mcdi.c
> +++ b/drivers/net/ethernet/sfc/mcdi.c
> @@ -1819,6 +1819,9 @@ void efx_mcdi_set_id_led(struct efx_nic *efx, enum efx_led_mode mode)
>  
>  	rc = efx_mcdi_rpc(efx, MC_CMD_SET_ID_LED, inbuf, sizeof(inbuf),
>  			  NULL, 0, NULL);
> +	if (rc)
> +		netif_err(efx, hw, efx->net_dev, "%s: failed rc=%d\n",
> +				__func__, rc);

"__func__" did not fail, efx_mcdi_rpc() did.