Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp7724147imu; Fri, 28 Dec 2018 03:51:39 -0800 (PST) X-Google-Smtp-Source: AFSGD/X3zaoGB4M5gMliY4UiAslWk743v9xUx0P6XQGHMILBtTrUoQcIjj4V2UNtINZCP35i8sM5 X-Received: by 2002:a62:c42:: with SMTP id u63mr27278634pfi.73.1545997898926; Fri, 28 Dec 2018 03:51:38 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1545997898; cv=none; d=google.com; s=arc-20160816; b=0udPIBc0iaoNQJHFMesgybSvw8I7XHJFpw7C9qfXHgDHYNt4dB6awyABkc/HjsBghj SH4TwwIQbC2jkFhP9vTyKpNRXMF12te9wyC48F6uuoJh9ccXUcQZUVKjhR+aw7gZ03b4 d3dhW7eq7VpWC/8wRRB9kN30MsevdsH18R/CT/HCc/rhJSys5pYFJbA7U3wn+H6IrVu8 DDKEiFIOwOmP1pbYPc8FDuhqbVVJOBC+Q13wy0MTrauRVAvKehC0hur755C7k5yCjBum /0/kG75rlUmIphMjTcJzTVxO+5VVQXskIZhreT1vWhtXa3RdyZmTYhnnyqjiPuYHPdKC PjSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :references:in-reply-to:from:subject:cc:to:message-id:date; bh=FE4ChJbHmifqzNDwTst+/Qaju4P95MbHuQsTgjuFSrc=; b=GwYz/4zKOlcixC0ZnA+KOXEstHSV0nqGMm3RPX8F5nqWyzcPnraHuJmyxR80HtOy6y VBTr9x9z3HzSQkzDpUm6Wez88H5a+BlAJ44uqoEmvJAyMHuuuMfWuivb6zHOHt5rhA5I RL8u6ic78X4T+w24ts+jqZRhQTc1wHPKIk3ap8YzKoLMdqMOHUfFS777S+AFY0C2oOki kz8JRb4/Ho8HdWve3NTmWeK5CrUpgs2z6gQhsX8Sr+t55bdesGpaRajUQgu/1upoMFWT a1UNQ7C8cUndyRQH4XDuXUMLZM8kjPBU25ZvhqrcFGqCTGJzWlweWfTaIAmgzwM5hBkp fI1w== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id 39si6937812pla.352.2018.12.28.03.51.01; Fri, 28 Dec 2018 03:51:38 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727382AbeL1ATz (ORCPT + 99 others); Thu, 27 Dec 2018 19:19:55 -0500 Received: from shards.monkeyblade.net ([23.128.96.9]:51902 "EHLO shards.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726861AbeL1ATy (ORCPT ); Thu, 27 Dec 2018 19:19:54 -0500 Received: from localhost (unknown [IPv6:2601:601:9f80:35cd::cf9]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) (Authenticated sender: davem-davemloft) by shards.monkeyblade.net (Postfix) with ESMTPSA id 8BA6714E0964B; Thu, 27 Dec 2018 16:19:53 -0800 (PST) Date: Thu, 27 Dec 2018 16:19:53 -0800 (PST) Message-Id: <20181227.161953.1630745956164164839.davem@davemloft.net> To: kjlu@umn.edu Cc: pakki001@umn.edu, shannon.nelson@oracle.com, colin.king@canonical.com, rob@taglang.io, joe@perches.com, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] ethernet: (niu) fix missing checks of niu_pci_eeprom_read From: David Miller In-Reply-To: <20181225075617.68058-1-kjlu@umn.edu> References: <20181225075617.68058-1-kjlu@umn.edu> X-Mailer: Mew version 6.8 on Emacs 26.1 Mime-Version: 1.0 Content-Type: Text/Plain; charset=us-ascii Content-Transfer-Encoding: 7bit X-Greylist: Sender succeeded SMTP AUTH, not delayed by milter-greylist-4.5.12 (shards.monkeyblade.net [149.20.54.216]); Thu, 27 Dec 2018 16:19:53 -0800 (PST) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org From: Kangjie Lu Date: Tue, 25 Dec 2018 01:56:14 -0600 > niu_pci_eeprom_read() may fail, so we should check its return value > before using the read data. > > Signed-off-by: Kangjie Lu Applied.