Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 28 Dec 2018 11:55:48 +0000
From:   Charles Keepax <ckeepax@opensource.cirrus.com>
To:     <broonie@kernel.org>, <matti.vaittinen@fi.rohmeurope.com>
CC:     <linux-kernel@vger.kernel.org>, <patches@opensource.cirrus.com>
Subject: Re: [PATCH] regmap: irq: Make IRQ type support optional
Message-ID: <20181228115548.GM16508@imbe.wolfsonmicro.main>
References: <20181228112358.5914-1-ckeepax@opensource.cirrus.com>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Disposition: inline
In-Reply-To: <20181228112358.5914-1-ckeepax@opensource.cirrus.com>
User-Agent: Mutt/1.5.20 (2009-12-10)
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

On Fri, Dec 28, 2018 at 11:23:58AM +0000, Charles Keepax wrote:
> Currently only gpio-max77620 is using the type support in regmap IRQ,
> but the implementation causes the irq_set_type operation to fail on all
> other regmap IRQ chips. Avoid these regressions by skipping the type
> handling on any chips that don't define a set of supported types.
> 
> Fixes: 1c2928e3e321 ("regmap: regmap-irq/gpio-max77620: add level-irq support")
> Signed-off-by: Charles Keepax <ckeepax@opensource.cirrus.com>
> ---
>  drivers/base/regmap/regmap-irq.c | 3 +++
>  1 file changed, 3 insertions(+)
> 
> diff --git a/drivers/base/regmap/regmap-irq.c b/drivers/base/regmap/regmap-irq.c
> index 1bd1145ad8b5e..8c674f1ad0fc8 100644
> --- a/drivers/base/regmap/regmap-irq.c
> +++ b/drivers/base/regmap/regmap-irq.c
> @@ -257,6 +257,9 @@ static int regmap_irq_set_type(struct irq_data *data, unsigned int type)
>  	int reg;
>  	const struct regmap_irq_type *t = &irq_data->type;
>  
> +	if (!t->types_supported)
> +		return 0;
> +
>  	if ((t->types_supported & type) != type)
>  		return -ENOTSUPP;
>  
> -- 
> 2.11.0

+ Matti Vaittinen, apologies for forgetting to include you on the
original sending.

Thanks,
Charles