Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8272736imu; Fri, 28 Dec 2018 14:15:02 -0800 (PST) X-Google-Smtp-Source: ALg8bN4qDv0ralyjDCZTtki/W9mspsJuT928SegUsSp/ZDdHj44/85qv5ZeX8L8YBbFur5jb3t3P X-Received: by 2002:a63:dc54:: with SMTP id f20mr28124278pgj.410.1546035302781; Fri, 28 Dec 2018 14:15:02 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546035302; cv=none; d=google.com; s=arc-20160816; b=hk+GLtntVNbwewZkw5/77MpjM0Tu885+q+L2NNzWzOYHHjarOUaMZwl88s9A5i5C/x gBnjrf4kslTKbBIJuiOhrrvRbg6jQ10qSJqWHyvClSFOXNaPBT4tlPyfnwFk7e4+RQuc 4j9zX8hoj5QxUylqmbnCY12ssjNNjlrnAfw4Uujujipt6wQ3dobWHtksdJcgHXZiNCCq DR6G/0hQNREpBmTlACwjpjviL7eHOTbsmNSqKBx6LV58AN1SIqejiYnGwOUz3Hmwmag5 ezBX+/9WiBV2+MsJv9qyqR+NzcAzhaWjyfHHJFj6N/bR20aizZiYqEEuZhZxgWfp3lcW dThw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:content-transfer-encoding:mime-version :user-agent:references:in-reply-to:message-id:date:subject:cc:to :from:dkim-signature; bh=tzOtAcvOtsIe7SWeoRa/cRlFgOC9iefCJ0GhlIEe2tY=; b=k7ZsEZTXFLdOjea0ItVLLd+opD10wcJL+IUjrAQiCPgmV+NwYtEpUi4rmV26RJOtUu qcbh9AMBiHEKCaxDodslPA4jwLhTmTmwHcUpJ7BKPAw+OkDHbvlPBGC3fAxZSamK04HZ hW7ofDzJE8OJudaHYOq+doPKG4ri0ShbOeSumMnHvWNH3XYrdCEXGy7tEUI2CxaxWtvb bY0ga5KS2i1HT8lQuDPE8b6q3QE8sVywq8O9jL9IMn7CCYyIu1nxXSmSqWOiFaNEbzPv 5yDKq0JursYuiwLcKXLeoChCx3OMwD0+2Y76zhD45VXU52bKVp/Qwwol6apfAO6bKmzG uWPg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DcGBUnbt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id l23si35647388pgh.533.2018.12.28.14.14.47; Fri, 28 Dec 2018 14:15:02 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=DcGBUnbt; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1732964AbeL1MRe (ORCPT + 99 others); Fri, 28 Dec 2018 07:17:34 -0500 Received: from mail.kernel.org ([198.145.29.99]:36562 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728177AbeL1MRc (ORCPT ); Fri, 28 Dec 2018 07:17:32 -0500 Received: from localhost (5356596B.cm-6-7b.dynamic.ziggo.nl [83.86.89.107]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id AD57920675; Fri, 28 Dec 2018 12:17:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1545999451; bh=wUwE9SvCBqBcyktQSNZb3gccuREclHr+BCDeLBIVrOE=; h=From:To:Cc:Subject:Date:In-Reply-To:References:From; b=DcGBUnbtcifGJsOPu8QDZUtaHuarmUAcKrbO368fchPBMJMHKZELCF+fkw6ebSErL M2BGm9uT62PgXYVR3932mF603o8QJ6DZwLHlpSqVSB90APiH3jjxn8dMr1xYCyV4OO xm4kULOx8VO9dvd6m8/8KgOlESq/Ac1/b/xPDS3Y= From: Greg Kroah-Hartman To: linux-kernel@vger.kernel.org Cc: Greg Kroah-Hartman , stable@vger.kernel.org, "K. Y. Srinivasan" , Haiyang Zhang , Stephen Hemminger , Dexuan Cui , Sasha Levin Subject: [PATCH 4.9 16/22] Drivers: hv: vmbus: Return -EINVAL for the sys files for unopened channels Date: Fri, 28 Dec 2018 12:52:53 +0100 Message-Id: <20181228113127.284712177@linuxfoundation.org> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20181228113126.144310132@linuxfoundation.org> References: <20181228113126.144310132@linuxfoundation.org> User-Agent: quilt/0.65 X-stable: review X-Patchwork-Hint: ignore MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 4.9-stable review patch. If anyone has any objections, please let me know. ------------------ From: Dexuan Cui commit fc96df16a1ce80cbb3c316ab7d4dc8cd5c2852ce upstream. Before 98f4c651762c, we returned zeros for unopened channels. With 98f4c651762c, we started to return random on-stack values. We'd better return -EINVAL instead. Fixes: 98f4c651762c ("hv: move ringbuffer bus attributes to dev_groups") Cc: stable@vger.kernel.org Cc: K. Y. Srinivasan Cc: Haiyang Zhang Cc: Stephen Hemminger Signed-off-by: Dexuan Cui Signed-off-by: Sasha Levin Signed-off-by: Greg Kroah-Hartman --- drivers/hv/vmbus_drv.c | 20 ++++++++++++++++++++ 1 file changed, 20 insertions(+) --- a/drivers/hv/vmbus_drv.c +++ b/drivers/hv/vmbus_drv.c @@ -317,6 +317,8 @@ static ssize_t out_intr_mask_show(struct if (!hv_dev->channel) return -ENODEV; + if (hv_dev->channel->state != CHANNEL_OPENED_STATE) + return -EINVAL; hv_ringbuffer_get_debuginfo(&hv_dev->channel->outbound, &outbound); return sprintf(buf, "%d\n", outbound.current_interrupt_mask); } @@ -330,6 +332,8 @@ static ssize_t out_read_index_show(struc if (!hv_dev->channel) return -ENODEV; + if (hv_dev->channel->state != CHANNEL_OPENED_STATE) + return -EINVAL; hv_ringbuffer_get_debuginfo(&hv_dev->channel->outbound, &outbound); return sprintf(buf, "%d\n", outbound.current_read_index); } @@ -344,6 +348,8 @@ static ssize_t out_write_index_show(stru if (!hv_dev->channel) return -ENODEV; + if (hv_dev->channel->state != CHANNEL_OPENED_STATE) + return -EINVAL; hv_ringbuffer_get_debuginfo(&hv_dev->channel->outbound, &outbound); return sprintf(buf, "%d\n", outbound.current_write_index); } @@ -358,6 +364,8 @@ static ssize_t out_read_bytes_avail_show if (!hv_dev->channel) return -ENODEV; + if (hv_dev->channel->state != CHANNEL_OPENED_STATE) + return -EINVAL; hv_ringbuffer_get_debuginfo(&hv_dev->channel->outbound, &outbound); return sprintf(buf, "%d\n", outbound.bytes_avail_toread); } @@ -372,6 +380,8 @@ static ssize_t out_write_bytes_avail_sho if (!hv_dev->channel) return -ENODEV; + if (hv_dev->channel->state != CHANNEL_OPENED_STATE) + return -EINVAL; hv_ringbuffer_get_debuginfo(&hv_dev->channel->outbound, &outbound); return sprintf(buf, "%d\n", outbound.bytes_avail_towrite); } @@ -385,6 +395,8 @@ static ssize_t in_intr_mask_show(struct if (!hv_dev->channel) return -ENODEV; + if (hv_dev->channel->state != CHANNEL_OPENED_STATE) + return -EINVAL; hv_ringbuffer_get_debuginfo(&hv_dev->channel->inbound, &inbound); return sprintf(buf, "%d\n", inbound.current_interrupt_mask); } @@ -398,6 +410,8 @@ static ssize_t in_read_index_show(struct if (!hv_dev->channel) return -ENODEV; + if (hv_dev->channel->state != CHANNEL_OPENED_STATE) + return -EINVAL; hv_ringbuffer_get_debuginfo(&hv_dev->channel->inbound, &inbound); return sprintf(buf, "%d\n", inbound.current_read_index); } @@ -411,6 +425,8 @@ static ssize_t in_write_index_show(struc if (!hv_dev->channel) return -ENODEV; + if (hv_dev->channel->state != CHANNEL_OPENED_STATE) + return -EINVAL; hv_ringbuffer_get_debuginfo(&hv_dev->channel->inbound, &inbound); return sprintf(buf, "%d\n", inbound.current_write_index); } @@ -425,6 +441,8 @@ static ssize_t in_read_bytes_avail_show( if (!hv_dev->channel) return -ENODEV; + if (hv_dev->channel->state != CHANNEL_OPENED_STATE) + return -EINVAL; hv_ringbuffer_get_debuginfo(&hv_dev->channel->inbound, &inbound); return sprintf(buf, "%d\n", inbound.bytes_avail_toread); } @@ -439,6 +457,8 @@ static ssize_t in_write_bytes_avail_show if (!hv_dev->channel) return -ENODEV; + if (hv_dev->channel->state != CHANNEL_OPENED_STATE) + return -EINVAL; hv_ringbuffer_get_debuginfo(&hv_dev->channel->inbound, &inbound); return sprintf(buf, "%d\n", inbound.bytes_avail_towrite); }