Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Content-Type: text/plain; charset="utf-8"
MIME-Version: 1.0
Content-Transfer-Encoding: quoted-printable
To:     Russell King - ARM Linux <linux@armlinux.org.uk>
Message-ID: <154603400565.179992.15420757926696319367@swboyd.mtv.corp.google.com>
References: <CABGGisxcHWwhUcQML7XmriK_DLFGjmud3cKt8yp+K4G2CAL=9Q@mail.gmail.com> <20181222072452.186726-1-swboyd@chromium.org> <20181222103320.GW26090@n2100.armlinux.org.uk>
Subject: Re: [PATCH] driver core: platform: Add an error message to platform_get_irq*()
Cc:     robh@kernel.org, a.hajda@samsung.com, andy.shevchenko@gmail.com,
        b.zolnierkie@samsung.com, broonie@kernel.org,
        gregkh@linuxfoundation.org, javierm@redhat.com,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org,
        m.szyprowski@samsung.com, rafael@kernel.org
From:   Stephen Boyd <swboyd@chromium.org>
User-Agent: alot/0.8
In-Reply-To: <20181222103320.GW26090@n2100.armlinux.org.uk>
Date:   Fri, 28 Dec 2018 13:53:25 -0800
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

Quoting Russell King - ARM Linux (2018-12-22 02:33:20)
> On Fri, Dec 21, 2018 at 11:24:52PM -0800, Stephen Boyd wrote:
> > A grep of the kernel shows that many drivers print an error message if
> > they fail to get the irq they're looking for. Furthermore, those drivers
> > all decide to print the device name, or not, and the irq they were
> > requesting, or not, etc. Let's consolidate all these error messages into
> > the API itself, allowing us to get rid of the error messages in each
> > driver.
> ...
> > +error:
> > +     if (warn)
> > +             dev_err(&dev->dev, "IRQ%d not found\n", num);
>=20
> Please don't use the notation IRQn - this is normally used when
> referring to interrupt numbers (such as those seen in
> /proc/interrupts) rather than a per-device interrupt index.
> Grep for IRQ% in drivers/ for many examples.
>=20
> dev_err(&dev->dev, "IRQ index %u not found: %d\n", num, ret);

Sure! I'll use that one.

>=20
> would be better - note also the use of %u for unsigned integers.
> Using %d for them is IMHO sloppy coding.
>=20

Ok.