Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp8832167imu; Sat, 29 Dec 2018 04:49:45 -0800 (PST) X-Google-Smtp-Source: ALg8bN7lgzC8spk6LqnB0zNKTQtet0GJguSMaA4P9wnRJQf+tSyU4le+5LI4rxaqRRZs9S/0OiSP X-Received: by 2002:a17:902:780c:: with SMTP id p12mr30317641pll.197.1546087785103; Sat, 29 Dec 2018 04:49:45 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546087785; cv=none; d=google.com; s=arc-20160816; b=S+aAh0NXu574mnQjO5WfF/v4gfO1Jd6le5fHgxjSM4fZZ51Dpw1fbViv7Mx/nDSACI rFcYAgw92xXQTQjOopYeHiF9nXbhLunkgqnti0Z+cbXbmLvhWesNhwFYHqretAO6WTWc nQ0ow4thEneGAF7lMugMKtA2sQq/WNXDHGiCBFjDiaL4ps1ldqyAZPp+DM64tuhnXzWf tl8jV9E2VX525ouHlEuR5oqzESO6hAhDZtkhBIYhE4OMURwj2auYvP91YTD68zUkfyVA s5v1CFi1klKpBJzClmHJVWi8nSIxKVjiFxk5jcqxjsPFKd5AavR9C8HdLOOHhyS/9OZW Z6Pw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date; bh=Jo3E0svXb5nwI5Vj+PNGVuKdsxcEY4LUF54e5KPqg8M=; b=AcJVQ20evWz3Po6YrrLv9vSBIekDHnOYzOSmovZNMG9HF2CpA/cz+Ove1NtaJB7NiD 96SUFJDgvkqPswKsuYTe42gYwLjDa6046nngrfLkDJGDig7m/d/JlksleF4Dt6WYayd4 RfFRH2aD4D17pkeLE3+17L1sGnDEKpExiYUMTWclKH+EfiICT6Dc8QCZI73MXW/VeWdZ YXmeLvVHxtrltRbw0CGfUIvcGuZMVBDfSytyAtyjAaBN6f3PWZoGaoUjUr3tNHJJc1Rl hZXxwTqsQsxnoZoSW/Yvkg0qk6zKZz3R8U7jW4gXq2qh/XpjjvKIAYYFTohX5njiK1Ay vSBg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id b65si40423579pgc.259.2018.12.29.04.49.30; Sat, 29 Dec 2018 04:49:45 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726083AbeL2Buk (ORCPT + 99 others); Fri, 28 Dec 2018 20:50:40 -0500 Received: from mail.us.es ([193.147.175.20]:36756 "EHLO mail.us.es" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726011AbeL2Buk (ORCPT ); Fri, 28 Dec 2018 20:50:40 -0500 Received: from antivirus1-rhel7.int (unknown [192.168.2.11]) by mail.us.es (Postfix) with ESMTP id 5453AFB446 for ; Sat, 29 Dec 2018 02:50:38 +0100 (CET) Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 46585DA7A2 for ; Sat, 29 Dec 2018 02:50:38 +0100 (CET) Received: by antivirus1-rhel7.int (Postfix, from userid 99) id 37246DA799; Sat, 29 Dec 2018 02:50:38 +0100 (CET) X-Spam-Checker-Version: SpamAssassin 3.4.1 (2015-04-28) on antivirus1-rhel7.int X-Spam-Level: X-Spam-Status: No, score=-108.2 required=7.5 tests=ALL_TRUSTED,BAYES_50, SMTPAUTH_US2,USER_IN_WHITELIST autolearn=disabled version=3.4.1 Received: from antivirus1-rhel7.int (localhost [127.0.0.1]) by antivirus1-rhel7.int (Postfix) with ESMTP id 59A65DA78D; Sat, 29 Dec 2018 02:50:36 +0100 (CET) Received: from 192.168.1.97 (192.168.1.97) by antivirus1-rhel7.int (F-Secure/fsigk_smtp/550/antivirus1-rhel7.int); Sat, 29 Dec 2018 02:50:36 +0100 (CET) X-Virus-Status: clean(F-Secure/fsigk_smtp/550/antivirus1-rhel7.int) Received: from us.es (sys.soleta.eu [212.170.55.40]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) (Authenticated sender: 1984lsi) by entrada.int (Postfix) with ESMTPSA id 2EF684265A4E; Sat, 29 Dec 2018 02:50:36 +0100 (CET) Date: Sat, 29 Dec 2018 02:50:35 +0100 X-SMTPAUTHUS: auth mail.us.es From: Pablo Neira Ayuso To: Kangjie Lu Cc: pakki001@umn.edu, Jozsef Kadlecsik , Florian Westphal , "David S. Miller" , netfilter-devel@vger.kernel.org, coreteam@netfilter.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] netfilter: fix a missing check of nla put failure Message-ID: <20181229015035.schsfpi6iikphmxr@salvia> References: <20181221064623.59988-1-kjlu@umn.edu> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20181221064623.59988-1-kjlu@umn.edu> User-Agent: NeoMutt/20170113 (1.7.2) X-Virus-Scanned: ClamAV using ClamSMTP Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 21, 2018 at 12:46:23AM -0600, Kangjie Lu wrote: > If nla_nest_start() may fail. The fix checks its return value and goes > to nla_put_failure if it fails. Applied, thanks.