Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 28 Dec 2018 21:49:05 -0800 (PST)
Message-Id: <20181228.214905.2208487974538707696.davem@davemloft.net>
To:     xuechaojing@huawei.com
Cc:     linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
        wulike1@huawei.com, chiqijun@huawei.com, fy.wang@huawei.com,
        tony.qu@huawei.com, luoshaokai@huawei.com
Subject: Re: [PATCH 1/1] net-next/hinic:add shutdown callback
From:   David Miller <davem@davemloft.net>
In-Reply-To: <20181228002040.1256-1-xuechaojing@huawei.com>
References: <20181228002040.1256-1-xuechaojing@huawei.com>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Xue Chaojing <xuechaojing@huawei.com>
Date: Fri, 28 Dec 2018 00:20:40 +0000

> @@ -1106,6 +1106,13 @@ static void hinic_remove(struct pci_dev *pdev)
>  	dev_info(&pdev->dev, "HiNIC driver - removed\n");
>  }
>  
> +static void hinic_shutdown(struct pci_dev *pdev)
> +{
> +	pci_disable_device(pdev);
> +
> +	dev_info(&pdev->dev, "HiNIC driver - shutdown\n");
> +}

I do not think these messages are appropriate.  I didn't catch
them before, but I'm not going to let new ones get added.