Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67;
Date:   Fri, 28 Dec 2018 21:10:53 -0800 (PST)
Message-Id: <20181228.211053.848330303302862567.davem@davemloft.net>
To:     peng.hao2@zte.com.cn
Cc:     qiang.zhao@nxp.com, leoyang.li@nxp.com,
        linux-kernel@vger.kernel.org, wen.yang99@zte.com.cn,
        julia.lawall@lip6.fr, netdev@vger.kernel.org,
        linuxppc-dev@lists.ozlabs.org
Subject: Re: [PATCH v3] soc/fsl/qe: fix err handling of ucc_of_parse_tdm
From:   David Miller <davem@davemloft.net>
In-Reply-To: <1545812789-77690-1-git-send-email-peng.hao2@zte.com.cn>
References: <1545812789-77690-1-git-send-email-peng.hao2@zte.com.cn>
Mime-Version: 1.0
Content-Type: Text/Plain; charset=us-ascii
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Precedence: bulk

From: Peng Hao <peng.hao2@zte.com.cn>
Date: Wed, 26 Dec 2018 16:26:29 +0800

> diff --git a/drivers/net/wan/fsl_ucc_hdlc.c b/drivers/net/wan/fsl_ucc_hdlc.c
> index 839fa77..8ce4921f 100644
> --- a/drivers/net/wan/fsl_ucc_hdlc.c
> +++ b/drivers/net/wan/fsl_ucc_hdlc.c
> @@ -1057,6 +1057,27 @@ static const struct net_device_ops uhdlc_ops = {
>  	.ndo_tx_timeout	= uhdlc_tx_timeout,
>  };
>  
> +static int ucc_get_resource_by_nodename(char *name, struct resource *res)
> +{
 ...
> +	res = platform_get_resource(pdev, IORESOURCE_MEM, 0);
> +	return 0;

This assignment to 'res' doesn't do what you think it does.  The caller never
sees the value you compute.