Received: by 2002:ad5:474a:0:0:0:0:0 with SMTP id i10csp9134181imu; Sat, 29 Dec 2018 11:04:52 -0800 (PST) X-Google-Smtp-Source: ALg8bN72ZahyF5QM1ylDHOrSVOPMm2vjBIoOih4VO9yGQ2ryWwakYXSxyHhlTbvXnogilF6pKx5a X-Received: by 2002:a62:ae04:: with SMTP id q4mr5466529pff.126.1546110292836; Sat, 29 Dec 2018 11:04:52 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1546110292; cv=none; d=google.com; s=arc-20160816; b=UlSu/1+qjlwJv7MTN5P0ar8BruppqYhNs2sgUwbRcQmNbDyURWZTsN8b29sMYpyhQO C9gNSLenTU3Wn7VDAtvvcRmF/zduFmCFWsjGBtj5+dryPA8HnttXS6DmPu24GYqod3mG DQf4rAHV4qIjW4asFirP5en4pFSuyXJoczij3/h7PSzWFVfeOKO7dAueEmvYogaCzGjI 1ajX9fgO4I5O2N1maKXX3DXn4V4NAl9dezab4RTyvrGKPIGO9xCCTQpVFlPX5tiexpni cJ25Unw3xaLwLCC9r7FnfFTmJO4ai6Ub5okhkj4oHya+p88dkpQqDMdkhzcfqJH7qhZ8 0uAw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=list-id:precedence:sender:user-agent:in-reply-to :content-disposition:mime-version:references:message-id:subject:cc :to:from:date:dkim-signature; bh=A6ips1QPqynIekge+EPqlvPVdc0y1t03KfEF9sWrdH8=; b=eEVJ+UBE0huzhrbexBUk66cLGinXJWdj2se7sLgeBo1w99NpfA/7zBdEba8HIcn9ZP 1gR8mgxmcv1ntN7VGqrRxXJsvgK/XUD3nVCygMsOcS0YlWrsUg0oUG6cd4UaKEStooso pqtiHOp/26zZo3LL8YZufROV3ibqDt5j6uJt60UDlbLri8P0DbbPsbzx4dX0LbU27uEP VVz7FjL6cSX1d5tQo3Yr/CiBerYNEVRnCY9OAWHuIex0Ck2C3nXXQMLLyY9G+f8nrSPa fiHBpImoNg83F19MRyHadinBAlDyBs2q8m89ZKXxJKcx+iRCIOf95sKy81IzsFZR0k0Z 2Pjg== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YUot7qiz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Return-Path: Received: from vger.kernel.org (vger.kernel.org. [209.132.180.67]) by mx.google.com with ESMTP id y189si43092497pfg.75.2018.12.29.11.04.36; Sat, 29 Dec 2018 11:04:52 -0800 (PST) Received-SPF: pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) client-ip=209.132.180.67; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=default header.b=YUot7qiz; spf=pass (google.com: best guess record for domain of linux-kernel-owner@vger.kernel.org designates 209.132.180.67 as permitted sender) smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727820AbeL2MXv (ORCPT + 99 others); Sat, 29 Dec 2018 07:23:51 -0500 Received: from mail.kernel.org ([198.145.29.99]:47124 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726191AbeL2MXv (ORCPT ); Sat, 29 Dec 2018 07:23:51 -0500 Received: from localhost (83-68-17-109.ip.xs4all.nl [83.68.17.109]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPSA id 00D6D20836; Sat, 29 Dec 2018 12:23:49 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=default; t=1546086230; bh=XlqaSizrAjVRPBeRlYMix2/Eicvk8BIZXcBX/Wz1kIo=; h=Date:From:To:Cc:Subject:References:In-Reply-To:From; b=YUot7qiztOqIw3xndeNSacyAPd14YszdskI5/3+Yikosb6+LYDruhKnQL/JKqHrrL fF8QVXMgzDK6CaA43PaEcEij9tPnjp2E7xkJNRuNNlOKd/pHSKxUJrQ2+/g5mwfYB/ YBNaaBRf+SXIKZONpZpZokmUy9cngYdqYJXrJk3s= Date: Sat, 29 Dec 2018 13:23:47 +0100 From: Greg Kroah-Hartman To: NeilBrown Cc: Randy Dunlap , LKML , Andrew Morton , kbuild test robot Subject: Re: [PATCH v3 treewide] headers: separate linux/mod_devicetable.h from linux/platform_device.h Message-ID: <20181229122347.GA24413@kroah.com> References: <7baed3cc-cb9c-66d2-b179-517877324407@infradead.org> <20180707155306.GA23729@kroah.com> <871s61azip.fsf@notabene.neil.brown.name> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <871s61azip.fsf@notabene.neil.brown.name> User-Agent: Mutt/1.11.1 (2018-12-01) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sat, Dec 29, 2018 at 12:32:30PM +1100, NeilBrown wrote: > On Sat, Jul 07 2018, Greg Kroah-Hartman wrote: > > > On Tue, Jun 19, 2018 at 10:47:28PM -0700, Randy Dunlap wrote: > >> From: Randy Dunlap > >> > >> At over 4000 #includes, is the 9th most > >> #included header file in the Linux kernel. It does not need > >> , so drop that header and explicitly add > >> to source files that need it. > >> > >> 4146 #include > >> > >> After this patch, there are 225 files that use , > >> for a reduction of around 3900 times that > >> does not have to be read & parsed. > >> > >> 225 #include > >> > >> This patch was build-tested on 20 different arch-es. > >> > >> It also makes these drivers SubmitChecklist#1 compliant. > >> > >> Signed-off-by: Randy Dunlap > >> Reported-by: kbuild test robot # drivers/media/platform/vimc/ > >> Reported-by: kbuild test robot # drivers/pinctrl/pinctrl-u300.c > >> --- > >> v3: add fix for drivers/pinctrl/pinctrl-u300.c > >> v2: add fixes for drivers/media/platform/vimc/ > > > > I've queued this up now, let's see what else breaks! :) > > Some MIPS watchdog drivers break, at least. > > NeilBrown > > From: NeilBrown > Subject: [PATCH] Fix compilation problem for mt7621_wdt.c and rt2880_wdt.c > > These files need > #include > to compile correctly. > > Fixes: ac3167257b9f ("headers: separate linux/mod_devicetable.h from linux/platform_device.h") > Signed-off-by: NeilBrown > --- > drivers/watchdog/mt7621_wdt.c | 1 + > drivers/watchdog/rt2880_wdt.c | 1 + > 2 files changed, 2 insertions(+) Great, can you send these to the watchdog maintainer to queue up? thanks, greg k-h